From: Tamizh chelvam <tamizhr@codeaurora.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCHv6 1/9] nl80211: New netlink command for TID specific configuration
Date: Sat, 10 Aug 2019 18:10:17 +0530 [thread overview]
Message-ID: <be096df17632b1a71441a23a373682bf@codeaurora.org> (raw)
In-Reply-To: <ea1f9969b52fed2da8b0e88ed8b06527bfc272aa.camel@sipsolutions.net>
On 2019-07-31 14:55, Johannes Berg wrote:
> On Tue, 2019-06-18 at 10:57 +0530, Tamizh chelvam wrote:
>>
>> /**
>> + * enum nl80211_tid_config - TID config state
>> + * @NL80211_TID_CONFIG_DEFAULT: Default config for the TID
>> + * @NL80211_TID_CONFIG_ENABLE: Enable config for the TID
>> + * NL80211_TID_CONFIG_DISABLE: Disable config for the TID
>> + */
>> +enum nl80211_tid_config {
>> + NL80211_TID_CONFIG_DEFAULT,
>> + NL80211_TID_CONFIG_ENABLE,
>> + NL80211_TID_CONFIG_DISABLE,
>> +};
>
> Hmm. Looking at this in more detail in patch 3, I don't understand.
>
> How is DEFAULT different from "attribute not present", i.e. "no
> changes"?
>
This DEFAULT is used to notify the driver to use default configuration
value of driver/vif.
This will be used when the attribute is not present.
WARNING: multiple messages have this Message-ID (diff)
From: Tamizh chelvam <tamizhr@codeaurora.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCHv6 1/9] nl80211: New netlink command for TID specific configuration
Date: Sat, 10 Aug 2019 18:10:17 +0530 [thread overview]
Message-ID: <be096df17632b1a71441a23a373682bf@codeaurora.org> (raw)
In-Reply-To: <ea1f9969b52fed2da8b0e88ed8b06527bfc272aa.camel@sipsolutions.net>
On 2019-07-31 14:55, Johannes Berg wrote:
> On Tue, 2019-06-18 at 10:57 +0530, Tamizh chelvam wrote:
>>
>> /**
>> + * enum nl80211_tid_config - TID config state
>> + * @NL80211_TID_CONFIG_DEFAULT: Default config for the TID
>> + * @NL80211_TID_CONFIG_ENABLE: Enable config for the TID
>> + * NL80211_TID_CONFIG_DISABLE: Disable config for the TID
>> + */
>> +enum nl80211_tid_config {
>> + NL80211_TID_CONFIG_DEFAULT,
>> + NL80211_TID_CONFIG_ENABLE,
>> + NL80211_TID_CONFIG_DISABLE,
>> +};
>
> Hmm. Looking at this in more detail in patch 3, I don't understand.
>
> How is DEFAULT different from "attribute not present", i.e. "no
> changes"?
>
This DEFAULT is used to notify the driver to use default configuration
value of driver/vif.
This will be used when the attribute is not present.
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2019-08-10 12:40 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 5:27 [PATCHv6 0/9] cfg80211/mac80211: Add support for TID specific configuration Tamizh chelvam
2019-06-18 5:27 ` Tamizh chelvam
2019-06-18 5:27 ` [PATCHv6 1/9] nl80211: New netlink command " Tamizh chelvam
2019-06-18 5:27 ` Tamizh chelvam
2019-07-11 12:51 ` Sergey Matyukevich
2019-07-11 12:51 ` Sergey Matyukevich
2019-07-31 10:04 ` Tamizh chelvam
2019-07-31 10:04 ` Tamizh chelvam
2019-07-11 13:13 ` Sergey Matyukevich
2019-07-11 13:13 ` Sergey Matyukevich
2019-07-31 9:19 ` Johannes Berg
2019-07-31 9:19 ` Johannes Berg
2019-07-31 10:28 ` Tamizh chelvam
2019-07-31 10:28 ` Tamizh chelvam
2019-07-31 9:25 ` Johannes Berg
2019-07-31 9:25 ` Johannes Berg
2019-08-10 12:40 ` Tamizh chelvam [this message]
2019-08-10 12:40 ` Tamizh chelvam
2019-08-21 7:42 ` Johannes Berg
2019-08-21 7:42 ` Johannes Berg
2019-06-18 5:27 ` [PATCHv6 2/9] nl80211: Add new netlink attribute for TID speicific retry count Tamizh chelvam
2019-06-18 5:27 ` Tamizh chelvam
2019-07-31 9:24 ` Johannes Berg
2019-07-31 9:24 ` Johannes Berg
2019-08-10 12:06 ` Tamizh chelvam
2019-08-10 12:06 ` Tamizh chelvam
2019-08-21 7:41 ` Johannes Berg
2019-08-21 7:41 ` Johannes Berg
2019-06-18 5:27 ` [PATCHv6 3/9] nl80211: Add netlink attribute for AMPDU aggregation enable/disable Tamizh chelvam
2019-06-18 5:27 ` Tamizh chelvam
2019-07-31 9:28 ` Johannes Berg
2019-07-31 9:28 ` Johannes Berg
2019-08-10 12:41 ` Tamizh chelvam
2019-08-10 12:41 ` Tamizh chelvam
2019-06-18 5:27 ` [PATCHv6 4/9] nl80211: Add netlink attribute to enable/disable RTS_CTS Tamizh chelvam
2019-06-18 5:27 ` Tamizh chelvam
2019-06-18 5:27 ` [PATCHv6 5/9] nl80211: Add netlink attribute to configure TID specific tx rate Tamizh chelvam
2019-06-18 5:27 ` Tamizh chelvam
2019-07-11 12:54 ` Sergey Matyukevich
2019-07-11 12:54 ` Sergey Matyukevich
2019-07-31 10:08 ` Tamizh chelvam
2019-07-31 10:08 ` Tamizh chelvam
2019-07-31 9:32 ` Johannes Berg
2019-07-31 9:32 ` Johannes Berg
2019-06-18 5:27 ` [PATCHv6 6/9] mac80211: Add api to support configuring TID specific configuration Tamizh chelvam
2019-06-18 5:27 ` Tamizh chelvam
2019-07-31 9:34 ` Johannes Berg
2019-07-31 9:34 ` Johannes Berg
2019-06-18 5:27 ` [PATCHv6 7/9] ath10k: Add wmi command support for station specific TID config Tamizh chelvam
2019-06-18 5:27 ` Tamizh chelvam
2019-06-18 5:27 ` [PATCHv6 8/9] ath10k: Add new api to support TID specific configuration Tamizh chelvam
2019-06-18 5:27 ` Tamizh chelvam
2019-06-18 5:27 ` [PATCHv6 9/9] ath10k: Add extended TID configuration support Tamizh chelvam
2019-06-18 5:27 ` Tamizh chelvam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be096df17632b1a71441a23a373682bf@codeaurora.org \
--to=tamizhr@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.