bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] um: vector: use GFP_ATOMIC under spin lock
@ 2019-11-28  2:01 Wei Yongjun
  2019-11-28  7:51 ` Anton Ivanov
  2019-11-28  8:06 ` Dan Carpenter
  0 siblings, 2 replies; 8+ messages in thread
From: Wei Yongjun @ 2019-11-28  2:01 UTC (permalink / raw)
  To: Jeff Dike, Richard Weinberger, Anton Ivanov, Alexei Starovoitov,
	Daniel Borkmann, Martin KaFai Lau, Song Liu
  Cc: Wei Yongjun, linux-um, netdev, bpf, kernel-janitors

A spin lock is taken here so we should use GFP_ATOMIC.

Fixes: 9807019a62dc ("um: Loadable BPF "Firmware" for vector drivers")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 arch/um/drivers/vector_kern.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c
index 92617e16829e..6ff0065a271d 100644
--- a/arch/um/drivers/vector_kern.c
+++ b/arch/um/drivers/vector_kern.c
@@ -1402,7 +1402,7 @@ static int vector_net_load_bpf_flash(struct net_device *dev,
 		kfree(vp->bpf->filter);
 		vp->bpf->filter = NULL;
 	} else {
-		vp->bpf = kmalloc(sizeof(struct sock_fprog), GFP_KERNEL);
+		vp->bpf = kmalloc(sizeof(struct sock_fprog), GFP_ATOMIC);
 		if (vp->bpf == NULL) {
 			netdev_err(dev, "failed to allocate memory for firmware\n");
 			goto flash_fail;
@@ -1414,7 +1414,7 @@ static int vector_net_load_bpf_flash(struct net_device *dev,
 	if (request_firmware(&fw, efl->data, &vdevice->pdev.dev))
 		goto flash_fail;
 
-	vp->bpf->filter = kmemdup(fw->data, fw->size, GFP_KERNEL);
+	vp->bpf->filter = kmemdup(fw->data, fw->size, GFP_ATOMIC);
 	if (!vp->bpf->filter)
 		goto free_buffer;




^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2019-11-28  9:24 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-28  2:01 [PATCH -next] um: vector: use GFP_ATOMIC under spin lock Wei Yongjun
2019-11-28  7:51 ` Anton Ivanov
2019-11-28  8:06 ` Dan Carpenter
2019-11-28  8:18   ` Anton Ivanov
2019-11-28  8:37     ` Dan Carpenter
2019-11-28  9:22       ` Anton Ivanov
2019-11-28  8:41     ` Richard Weinberger
2019-11-28  9:24       ` Anton Ivanov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).