* [PATCH] xdp: fix xsk_generic_xmit errno
@ 2020-06-11 5:11 Li RongQing
2020-06-11 8:18 ` Björn Töpel
2020-06-11 19:44 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Li RongQing @ 2020-06-11 5:11 UTC (permalink / raw)
To: netdev, bpf
propagate sock_alloc_send_skb error code, not set it
to EAGAIN unconditionally, when fail to allocate skb,
which maybe causes that user space unnecessary loops
Fixes: 35fcde7f8deb "(xsk: support for Tx)"
Signed-off-by: Li RongQing <lirongqing@baidu.com>
---
net/xdp/xsk.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/xdp/xsk.c b/net/xdp/xsk.c
index b6c0f08bd80d..1ba3ea262c15 100644
--- a/net/xdp/xsk.c
+++ b/net/xdp/xsk.c
@@ -353,7 +353,6 @@ static int xsk_generic_xmit(struct sock *sk)
len = desc.len;
skb = sock_alloc_send_skb(sk, len, 1, &err);
if (unlikely(!skb)) {
- err = -EAGAIN;
goto out;
}
--
2.16.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] xdp: fix xsk_generic_xmit errno
2020-06-11 5:11 [PATCH] xdp: fix xsk_generic_xmit errno Li RongQing
@ 2020-06-11 8:18 ` Björn Töpel
2020-06-11 14:24 ` Daniel Borkmann
2020-06-11 19:44 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Björn Töpel @ 2020-06-11 8:18 UTC (permalink / raw)
To: Li RongQing, Alexei Starovoitov, Daniel Borkmann; +Cc: Netdev, bpf
On Thu, 11 Jun 2020 at 07:11, Li RongQing <lirongqing@baidu.com> wrote:
>
> propagate sock_alloc_send_skb error code, not set it
> to EAGAIN unconditionally, when fail to allocate skb,
> which maybe causes that user space unnecessary loops
>
> Fixes: 35fcde7f8deb "(xsk: support for Tx)"
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
Thanks!
Acked-by: Björn Töpel <bjorn.topel@intel.com>
Alexei/Daniel: This should go into "bpf".
Björn
> ---
> net/xdp/xsk.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/xdp/xsk.c b/net/xdp/xsk.c
> index b6c0f08bd80d..1ba3ea262c15 100644
> --- a/net/xdp/xsk.c
> +++ b/net/xdp/xsk.c
> @@ -353,7 +353,6 @@ static int xsk_generic_xmit(struct sock *sk)
> len = desc.len;
> skb = sock_alloc_send_skb(sk, len, 1, &err);
> if (unlikely(!skb)) {
> - err = -EAGAIN;
> goto out;
> }
>
> --
> 2.16.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xdp: fix xsk_generic_xmit errno
2020-06-11 8:18 ` Björn Töpel
@ 2020-06-11 14:24 ` Daniel Borkmann
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Borkmann @ 2020-06-11 14:24 UTC (permalink / raw)
To: Björn Töpel, Li RongQing, Alexei Starovoitov; +Cc: Netdev, bpf
On 6/11/20 10:18 AM, Björn Töpel wrote:
> On Thu, 11 Jun 2020 at 07:11, Li RongQing <lirongqing@baidu.com> wrote:
>>
>> propagate sock_alloc_send_skb error code, not set it
>> to EAGAIN unconditionally, when fail to allocate skb,
>> which maybe causes that user space unnecessary loops
>>
>> Fixes: 35fcde7f8deb "(xsk: support for Tx)"
>> Signed-off-by: Li RongQing <lirongqing@baidu.com>
>
> Thanks!
> Acked-by: Björn Töpel <bjorn.topel@intel.com>
>
> Alexei/Daniel: This should go into "bpf".
Yep, applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xdp: fix xsk_generic_xmit errno
2020-06-11 5:11 [PATCH] xdp: fix xsk_generic_xmit errno Li RongQing
2020-06-11 8:18 ` Björn Töpel
@ 2020-06-11 19:44 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2020-06-11 19:44 UTC (permalink / raw)
To: lirongqing; +Cc: netdev, bpf
From: Li RongQing <lirongqing@baidu.com>
Date: Thu, 11 Jun 2020 13:11:06 +0800
> @@ -353,7 +353,6 @@ static int xsk_generic_xmit(struct sock *sk)
> len = desc.len;
> skb = sock_alloc_send_skb(sk, len, 1, &err);
> if (unlikely(!skb)) {
> - err = -EAGAIN;
> goto out;
> }
Since the result is a single-statement basic block you must remove the
curly braces.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-11 19:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-11 5:11 [PATCH] xdp: fix xsk_generic_xmit errno Li RongQing
2020-06-11 8:18 ` Björn Töpel
2020-06-11 14:24 ` Daniel Borkmann
2020-06-11 19:44 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).