bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] selftests/bpf: Copy runqslower to OUTPUT directory
       [not found] <20200427132940.2857289-1-vkabatov@redhat.com>
@ 2020-04-27 14:02 ` Jesper Dangaard Brouer
  2020-04-27 15:48   ` Jesper Dangaard Brouer
  2020-04-27 20:18   ` Andrii Nakryiko
  0 siblings, 2 replies; 4+ messages in thread
From: Jesper Dangaard Brouer @ 2020-04-27 14:02 UTC (permalink / raw)
  To: Veronika Kabatova; +Cc: brouer, bpf, andriin

On Mon, 27 Apr 2020 15:29:40 +0200
Veronika Kabatova <vkabatov@redhat.com> wrote:

> $(OUTPUT)/runqslower makefile target doesn't actually create runqslower
> binary in the $(OUTPUT) directory. As lib.mk expects all
> TEST_GEN_PROGS_EXTENDED (which runqslower is a part of) to be present in
> the OUTPUT directory, this results in an error when running e.g. `make
> install`:
> 
> rsync: link_stat "tools/testing/selftests/bpf/runqslower" failed: No
>        such file or directory (2)
> 
> Copy the binary into the OUTPUT directory after building it to fix the
> error.
> 
> Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
> ---

Looks good to me

Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>

>  tools/testing/selftests/bpf/Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
> index 7729892e0b04..cb8e7e5b2307 100644
> --- a/tools/testing/selftests/bpf/Makefile
> +++ b/tools/testing/selftests/bpf/Makefile
> @@ -142,6 +142,7 @@ $(OUTPUT)/runqslower: $(BPFOBJ)
>  	$(Q)$(MAKE) $(submake_extras) -C $(TOOLSDIR)/bpf/runqslower	\
>  		    OUTPUT=$(SCRATCH_DIR)/ VMLINUX_BTF=$(VMLINUX_BTF)   \
>  		    BPFOBJ=$(BPFOBJ) BPF_INCLUDE=$(INCLUDE_DIR)
> +	@cp $(SCRATCH_DIR)/runqslower $(OUTPUT)/runqslower
>  
>  $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED): $(OUTPUT)/test_stub.o $(BPFOBJ)

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] selftests/bpf: Copy runqslower to OUTPUT directory
  2020-04-27 14:02 ` [PATCH] selftests/bpf: Copy runqslower to OUTPUT directory Jesper Dangaard Brouer
@ 2020-04-27 15:48   ` Jesper Dangaard Brouer
  2020-04-27 20:18   ` Andrii Nakryiko
  1 sibling, 0 replies; 4+ messages in thread
From: Jesper Dangaard Brouer @ 2020-04-27 15:48 UTC (permalink / raw)
  To: Veronika Kabatova; +Cc: bpf, andriin, brouer

On Mon, 27 Apr 2020 16:02:40 +0200
Jesper Dangaard Brouer <brouer@redhat.com> wrote:

> On Mon, 27 Apr 2020 15:29:40 +0200
> Veronika Kabatova <vkabatov@redhat.com> wrote:
> 
> > $(OUTPUT)/runqslower makefile target doesn't actually create runqslower
> > binary in the $(OUTPUT) directory. As lib.mk expects all
> > TEST_GEN_PROGS_EXTENDED (which runqslower is a part of) to be present in
> > the OUTPUT directory, this results in an error when running e.g. `make
> > install`:
> > 
> > rsync: link_stat "tools/testing/selftests/bpf/runqslower" failed: No
> >        such file or directory (2)
> > 
> > Copy the binary into the OUTPUT directory after building it to fix the
> > error.
> > 
> > Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
> > ---  
> 
> Looks good to me
> 
> Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>

Let us add a Fixes tag (patchwork should pick this up).

Fixes: 3a0d3092a4ed ("selftests/bpf: Build runqslower from selftests")

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] selftests/bpf: Copy runqslower to OUTPUT directory
  2020-04-27 14:02 ` [PATCH] selftests/bpf: Copy runqslower to OUTPUT directory Jesper Dangaard Brouer
  2020-04-27 15:48   ` Jesper Dangaard Brouer
@ 2020-04-27 20:18   ` Andrii Nakryiko
  2020-04-28 14:40     ` Veronika Kabatova
  1 sibling, 1 reply; 4+ messages in thread
From: Andrii Nakryiko @ 2020-04-27 20:18 UTC (permalink / raw)
  To: Jesper Dangaard Brouer; +Cc: Veronika Kabatova, bpf, Andrii Nakryiko

On Mon, Apr 27, 2020 at 7:03 AM Jesper Dangaard Brouer
<brouer@redhat.com> wrote:
>
> On Mon, 27 Apr 2020 15:29:40 +0200
> Veronika Kabatova <vkabatov@redhat.com> wrote:
>
> > $(OUTPUT)/runqslower makefile target doesn't actually create runqslower
> > binary in the $(OUTPUT) directory. As lib.mk expects all
> > TEST_GEN_PROGS_EXTENDED (which runqslower is a part of) to be present in
> > the OUTPUT directory, this results in an error when running e.g. `make
> > install`:
> >
> > rsync: link_stat "tools/testing/selftests/bpf/runqslower" failed: No
> >        such file or directory (2)
> >
> > Copy the binary into the OUTPUT directory after building it to fix the
> > error.
> >
> > Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
> > ---
>

Did I miss original patch somewhere on bpf@vger mailing list?..

> Looks good to me
>
> Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
>
> >  tools/testing/selftests/bpf/Makefile | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
> > index 7729892e0b04..cb8e7e5b2307 100644
> > --- a/tools/testing/selftests/bpf/Makefile
> > +++ b/tools/testing/selftests/bpf/Makefile
> > @@ -142,6 +142,7 @@ $(OUTPUT)/runqslower: $(BPFOBJ)
> >       $(Q)$(MAKE) $(submake_extras) -C $(TOOLSDIR)/bpf/runqslower     \
> >                   OUTPUT=$(SCRATCH_DIR)/ VMLINUX_BTF=$(VMLINUX_BTF)   \
> >                   BPFOBJ=$(BPFOBJ) BPF_INCLUDE=$(INCLUDE_DIR)
> > +     @cp $(SCRATCH_DIR)/runqslower $(OUTPUT)/runqslower

This should be AND'ed (&&) with $(MAKE) to not attempt copy on failed
make run. Also in general @cp should be $(Q)cp, but if you use $$ you
shouldn't need $(Q).

Also, just use $@ instead of $(OUTPUT)/runqslower:

cp $(SCRATCH_DIR)/runqslower $@

> >
> >  $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED): $(OUTPUT)/test_stub.o $(BPFOBJ)
>
> --
> Best regards,
>   Jesper Dangaard Brouer
>   MSc.CS, Principal Kernel Engineer at Red Hat
>   LinkedIn: http://www.linkedin.com/in/brouer
>

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] selftests/bpf: Copy runqslower to OUTPUT directory
  2020-04-27 20:18   ` Andrii Nakryiko
@ 2020-04-28 14:40     ` Veronika Kabatova
  0 siblings, 0 replies; 4+ messages in thread
From: Veronika Kabatova @ 2020-04-28 14:40 UTC (permalink / raw)
  To: Andrii Nakryiko; +Cc: Jesper Dangaard Brouer, bpf



----- Original Message -----
> From: "Andrii Nakryiko" <andrii.nakryiko@gmail.com>
> To: "Jesper Dangaard Brouer" <brouer@redhat.com>
> Cc: "Veronika Kabatova" <vkabatov@redhat.com>, "bpf" <bpf@vger.kernel.org>, "Andrii Nakryiko" <andriin@fb.com>
> Sent: Monday, April 27, 2020 10:18:37 PM
> Subject: Re: [PATCH] selftests/bpf: Copy runqslower to OUTPUT directory
> 
> On Mon, Apr 27, 2020 at 7:03 AM Jesper Dangaard Brouer
> <brouer@redhat.com> wrote:
> >
> > On Mon, 27 Apr 2020 15:29:40 +0200
> > Veronika Kabatova <vkabatov@redhat.com> wrote:
> >
> > > $(OUTPUT)/runqslower makefile target doesn't actually create runqslower
> > > binary in the $(OUTPUT) directory. As lib.mk expects all
> > > TEST_GEN_PROGS_EXTENDED (which runqslower is a part of) to be present in
> > > the OUTPUT directory, this results in an error when running e.g. `make
> > > install`:
> > >
> > > rsync: link_stat "tools/testing/selftests/bpf/runqslower" failed: No
> > >        such file or directory (2)
> > >
> > > Copy the binary into the OUTPUT directory after building it to fix the
> > > error.
> > >
> > > Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
> > > ---
> >
> 
> Did I miss original patch somewhere on bpf@vger mailing list?..
> 

Sorry about that, it looks like the smtp setup selectively drops external
addresses. I'll send the v2 from my private email account to avoid this
problem until I figure out what's wrong.

> > Looks good to me
> >
> > Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
> >
> > >  tools/testing/selftests/bpf/Makefile | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/tools/testing/selftests/bpf/Makefile
> > > b/tools/testing/selftests/bpf/Makefile
> > > index 7729892e0b04..cb8e7e5b2307 100644
> > > --- a/tools/testing/selftests/bpf/Makefile
> > > +++ b/tools/testing/selftests/bpf/Makefile
> > > @@ -142,6 +142,7 @@ $(OUTPUT)/runqslower: $(BPFOBJ)
> > >       $(Q)$(MAKE) $(submake_extras) -C $(TOOLSDIR)/bpf/runqslower     \
> > >                   OUTPUT=$(SCRATCH_DIR)/ VMLINUX_BTF=$(VMLINUX_BTF)   \
> > >                   BPFOBJ=$(BPFOBJ) BPF_INCLUDE=$(INCLUDE_DIR)
> > > +     @cp $(SCRATCH_DIR)/runqslower $(OUTPUT)/runqslower
> 
> This should be AND'ed (&&) with $(MAKE) to not attempt copy on failed
> make run. Also in general @cp should be $(Q)cp, but if you use $$ you
> shouldn't need $(Q).
> 
> Also, just use $@ instead of $(OUTPUT)/runqslower:
> 
> cp $(SCRATCH_DIR)/runqslower $@
> 

Sounds reasonable, thanks.

Veronika

> > >
> > >  $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED): $(OUTPUT)/test_stub.o
> > >  $(BPFOBJ)
> >
> > --
> > Best regards,
> >   Jesper Dangaard Brouer
> >   MSc.CS, Principal Kernel Engineer at Red Hat
> >   LinkedIn: http://www.linkedin.com/in/brouer
> >
> 
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-28 14:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20200427132940.2857289-1-vkabatov@redhat.com>
2020-04-27 14:02 ` [PATCH] selftests/bpf: Copy runqslower to OUTPUT directory Jesper Dangaard Brouer
2020-04-27 15:48   ` Jesper Dangaard Brouer
2020-04-27 20:18   ` Andrii Nakryiko
2020-04-28 14:40     ` Veronika Kabatova

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).