* Re: [PATCH v2 1/2] perf tools: Fix potential memory leaks in perf events parser
[not found] ` <20200611145605.21427-2-chenwandun@huawei.com>
@ 2020-06-11 18:50 ` Markus Elfring
2020-06-12 10:01 ` Greg KH
2020-06-14 3:39 ` Chen Wandun
0 siblings, 2 replies; 4+ messages in thread
From: Markus Elfring @ 2020-06-11 18:50 UTC (permalink / raw)
To: Cheng Jian, Chen Wandun, netdev, bpf
Cc: linux-kernel, Arnaldo Carvalho de Melo, Ingo Molnar, Peter Zijlstra
> Fix memory leak of in function parse_events_term__sym_hw()
> and parse_events_term__clone() when error occur.
How do you think about a wording variant like the following?
Release a configuration object after a string duplication failed.
Regards,
Markus
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 2/2] perf tools: Improve exception handling in two functions of perf events parser
[not found] ` <20200611145605.21427-3-chenwandun@huawei.com>
@ 2020-06-11 19:09 ` Markus Elfring
0 siblings, 0 replies; 4+ messages in thread
From: Markus Elfring @ 2020-06-11 19:09 UTC (permalink / raw)
To: Chen Wandun, netdev, linux-kernel, bpf
Cc: Arnaldo Carvalho de Melo, Cheng Jian, Ingo Molnar, Peter Zijlstra
> Fix potential memory leak. Function new_term may return error, so
> it is need to free memory when the return value is negative.
How do you think about a wording variant like the following?
Add jump targets so that a configuration object and a duplicated string
are released after a call of the function “strdup” or “new_term” failed.
Regards,
Markus
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/2] perf tools: Fix potential memory leaks in perf events parser
2020-06-11 18:50 ` [PATCH v2 1/2] perf tools: Fix potential memory leaks in perf events parser Markus Elfring
@ 2020-06-12 10:01 ` Greg KH
2020-06-14 3:39 ` Chen Wandun
1 sibling, 0 replies; 4+ messages in thread
From: Greg KH @ 2020-06-12 10:01 UTC (permalink / raw)
To: Markus Elfring
Cc: Cheng Jian, Chen Wandun, netdev, bpf, linux-kernel,
Arnaldo Carvalho de Melo, Ingo Molnar, Peter Zijlstra
On Thu, Jun 11, 2020 at 08:50:58PM +0200, Markus Elfring wrote:
> > Fix memory leak of in function parse_events_term__sym_hw()
> > and parse_events_term__clone() when error occur.
>
> How do you think about a wording variant like the following?
>
> Release a configuration object after a string duplication failed.
>
> Regards,
> Markus
Hi,
This is the semi-friendly patch-bot of Greg Kroah-Hartman.
Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list. I strongly suggest that you not do this anymore. Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.
Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all. The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback. Please feel free to also ignore emails
from them.
thanks,
greg k-h's patch email bot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/2] perf tools: Fix potential memory leaks in perf events parser
2020-06-11 18:50 ` [PATCH v2 1/2] perf tools: Fix potential memory leaks in perf events parser Markus Elfring
2020-06-12 10:01 ` Greg KH
@ 2020-06-14 3:39 ` Chen Wandun
1 sibling, 0 replies; 4+ messages in thread
From: Chen Wandun @ 2020-06-14 3:39 UTC (permalink / raw)
To: Markus Elfring, Cheng Jian, netdev, bpf
Cc: linux-kernel, Arnaldo Carvalho de Melo, Ingo Molnar, Peter Zijlstra
在 2020/6/12 2:50, Markus Elfring 写道:
>> Fix memory leak of in function parse_events_term__sym_hw()
>> and parse_events_term__clone() when error occur.
> How do you think about a wording variant like the following?
>
> Release a configuration object after a string duplication failed.
Thank you for your reply, I will update in v3
Best Regards,
Chen Wandun
>
> Regards,
> Markus
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-14 3:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200611145605.21427-1-chenwandun@huawei.com>
[not found] ` <20200611145605.21427-2-chenwandun@huawei.com>
2020-06-11 18:50 ` [PATCH v2 1/2] perf tools: Fix potential memory leaks in perf events parser Markus Elfring
2020-06-12 10:01 ` Greg KH
2020-06-14 3:39 ` Chen Wandun
[not found] ` <20200611145605.21427-3-chenwandun@huawei.com>
2020-06-11 19:09 ` [PATCH v2 2/2] perf tools: Improve exception handling in two functions of " Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).