Re: [PATCH v2 1/2] perf tools: Fix potential memory leaks in perf events parser

Re: [PATCH v2 1/2] perf tools: Fix potential memory leaks in perf events parser

[Markus Elfring]

> Fix memory leak of in function parse_events_term__sym_hw()
> and parse_events_term__clone() when error occur.

How do you think about a wording variant like the following?

   Release a configuration object after a string duplication failed.

Regards,
Markus

Re: [PATCH v2 1/2] perf tools: Fix potential memory leaks in perf events parser

[Greg KH]

On Thu, Jun 11, 2020 at 08:50:58PM +0200, Markus Elfring wrote:
> > Fix memory leak of in function parse_events_term__sym_hw()
> > and parse_events_term__clone() when error occur.
> 
> How do you think about a wording variant like the following?
> 
>    Release a configuration object after a string duplication failed.
> 
> Regards,
> Markus

Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list.  I strongly suggest that you not do this anymore.  Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback.  Please feel free to also ignore emails
from them.

thanks,

greg k-h's patch email bot

Re: [PATCH v2 1/2] perf tools: Fix potential memory leaks in perf events parser

[Chen Wandun]

在 2020/6/12 2:50, Markus Elfring 写道:
>> Fix memory leak of in function parse_events_term__sym_hw()
>> and parse_events_term__clone() when error occur.
> How do you think about a wording variant like the following?
>
>     Release a configuration object after a string duplication failed.

Thank you for your reply, I will update in v3

Best Regards,

     Chen Wandun


>
> Regards,
> Markus
>

Re: [PATCH v2 2/2] perf tools: Improve exception handling in two functions of perf events parser

[Markus Elfring]

> Fix potential memory leak. Function new_term may return error, so
> it is need to free memory when the return value is negative.

How do you think about a wording variant like the following?

   Add jump targets so that a configuration object and a duplicated string
   are released after a call of the function “strdup” or “new_term” failed.

Regards,
Markus