From: "G, GurucharanX" <gurucharanx.g@intel.com>
To: "Fijalkowski, Maciej" <maciej.fijalkowski@intel.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>
Cc: "joamaki@gmail.com" <joamaki@gmail.com>,
"Lobakin, Alexandr" <alexandr.lobakin@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"toke@redhat.com" <toke@redhat.com>,
"bjorn@kernel.org" <bjorn@kernel.org>,
"kuba@kernel.org" <kuba@kernel.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"Karlsson, Magnus" <magnus.karlsson@intel.com>
Subject: RE: [Intel-wired-lan] [PATCH v7 intel-next 3/9] ice: split ice_ring onto Tx/Rx separate structs
Date: Wed, 22 Sep 2021 18:28:07 +0000 [thread overview]
Message-ID: <BL0PR11MB336312F04BF37B31B133B8DBFCA29@BL0PR11MB3363.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210819120004.34392-4-maciej.fijalkowski@intel.com>
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Maciej Fijalkowski
> Sent: Thursday, August 19, 2021 5:30 PM
> To: intel-wired-lan@lists.osuosl.org
> Cc: joamaki@gmail.com; Lobakin, Alexandr <alexandr.lobakin@intel.com>;
> netdev@vger.kernel.org; toke@redhat.com; bjorn@kernel.org;
> kuba@kernel.org; bpf@vger.kernel.org; davem@davemloft.net; Karlsson,
> Magnus <magnus.karlsson@intel.com>
> Subject: [Intel-wired-lan] [PATCH v7 intel-next 3/9] ice: split ice_ring onto
> Tx/Rx separate structs
>
> While it was convenient to have a generic ring structure that served
> both Tx and Rx sides, next commits are going to introduce several
> Tx-specific fields, so in order to avoid hurting the Rx side, let's
> pull out the Tx ring onto new ice_tx_ring and ice_rx_ring structs.
>
> Rx ring could be handled by the old ice_ring which would reduce the code
> churn within this patch, but this would make things asymmetric.
>
> Make the union out of the ring container within ice_q_vector so that it
> is possible to iterate over newly introduced ice_tx_ring.
>
> Remove the @size as it's only accessed from control path and it can be
> calculated pretty easily.
>
> Change definitions of ice_update_ring_stats and
> ice_fetch_u64_stats_per_ring so that they are ring agnostic and can be
> used for both Rx and Tx rings.
>
> Sizes of Rx and Tx ring structs are 256 and 192 bytes, respectively. In
> Rx ring xdp_rxq_info occupies its own cacheline, so it's the major
> difference now.
>
> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice.h | 33 +++--
> drivers/net/ethernet/intel/ice/ice_base.c | 57 ++++----
> drivers/net/ethernet/intel/ice/ice_base.h | 8 +-
> drivers/net/ethernet/intel/ice/ice_dcb_lib.c | 5 +-
> drivers/net/ethernet/intel/ice/ice_dcb_lib.h | 10 +-
> drivers/net/ethernet/intel/ice/ice_eswitch.c | 35 ++---
> drivers/net/ethernet/intel/ice/ice_eswitch.h | 4 +-
> drivers/net/ethernet/intel/ice/ice_ethtool.c | 49 ++++---
> drivers/net/ethernet/intel/ice/ice_lib.c | 64 +++++----
> drivers/net/ethernet/intel/ice/ice_lib.h | 6 +-
> drivers/net/ethernet/intel/ice/ice_main.c | 69 +++++----
> drivers/net/ethernet/intel/ice/ice_ptp.c | 2 +-
> drivers/net/ethernet/intel/ice/ice_ptp.h | 4 +-
> drivers/net/ethernet/intel/ice/ice_trace.h | 28 ++--
> drivers/net/ethernet/intel/ice/ice_txrx.c | 131 ++++++++++--------
> drivers/net/ethernet/intel/ice/ice_txrx.h | 114 +++++++++------
> drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 18 +--
> drivers/net/ethernet/intel/ice/ice_txrx_lib.h | 14 +-
> .../net/ethernet/intel/ice/ice_virtchnl_pf.c | 2 +-
> drivers/net/ethernet/intel/ice/ice_xsk.c | 49 ++++---
> drivers/net/ethernet/intel/ice/ice_xsk.h | 20 +--
> 21 files changed, 397 insertions(+), 325 deletions(-)
>
Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at Intel)
next prev parent reply other threads:[~2021-09-22 18:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 11:59 [PATCH v7 intel-next 0/9] XDP_TX improvements for ice Maciej Fijalkowski
2021-08-19 11:59 ` [PATCH v7 intel-next 1/9] ice: remove ring_active from ice_ring Maciej Fijalkowski
2021-09-13 6:47 ` [Intel-wired-lan] " G, GurucharanX
2021-08-19 11:59 ` [PATCH v7 intel-next 2/9] ice: move ice_container_type onto ice_ring_container Maciej Fijalkowski
2021-09-13 6:50 ` [Intel-wired-lan] " G, GurucharanX
2021-08-19 11:59 ` [PATCH v7 intel-next 3/9] ice: split ice_ring onto Tx/Rx separate structs Maciej Fijalkowski
2021-09-22 18:28 ` G, GurucharanX [this message]
2021-08-19 11:59 ` [PATCH v7 intel-next 4/9] ice: unify xdp_rings accesses Maciej Fijalkowski
2021-09-03 6:37 ` [Intel-wired-lan] " Kuruvinakunnel, George
2021-08-19 12:00 ` [PATCH v7 intel-next 5/9] ice: do not create xdp_frame on XDP_TX Maciej Fijalkowski
2021-09-03 6:40 ` [Intel-wired-lan] " Kuruvinakunnel, George
2021-08-19 12:00 ` [PATCH v7 intel-next 6/9] ice: propagate xdp_ring onto rx_ring Maciej Fijalkowski
2021-09-03 6:45 ` [Intel-wired-lan] " Kuruvinakunnel, George
2021-08-19 12:00 ` [PATCH v7 intel-next 7/9] ice: optimize XDP_TX workloads Maciej Fijalkowski
2021-09-03 6:50 ` [Intel-wired-lan] " Kuruvinakunnel, George
2021-08-19 12:00 ` [PATCH v7 intel-next 8/9] ice: introduce XDP_TX fallback path Maciej Fijalkowski
2021-09-03 6:50 ` [Intel-wired-lan] " Kuruvinakunnel, George
2021-08-19 12:00 ` [PATCH v7 intel-next 9/9] ice: make use of ice_for_each_* macros Maciej Fijalkowski
2021-09-22 18:26 ` [Intel-wired-lan] " G, GurucharanX
2021-08-25 7:57 ` [Intel-wired-lan] [PATCH v7 intel-next 0/9] XDP_TX improvements for ice Magnus Karlsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BL0PR11MB336312F04BF37B31B133B8DBFCA29@BL0PR11MB3363.namprd11.prod.outlook.com \
--to=gurucharanx.g@intel.com \
--cc=alexandr.lobakin@intel.com \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=joamaki@gmail.com \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).