From: Grant Seltzer Richman <grantseltzer@gmail.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>, Martin Lau <kafai@fb.com>,
Song Liu <songliubraving@fb.com>,
john fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>, Ian Rogers <irogers@google.com>,
Yonghong Song <yhs@fb.com>, Tobias Klauser <tklauser@distanz.ch>,
Networking <netdev@vger.kernel.org>,
Michal Rostecki <mrostecki@opensuse.org>,
Alexei Starovoitov <ast@kernel.org>,
Quentin Monnet <quentin@isovalent.com>, bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH v3 bpf-next] Add CONFIG_DEBUG_INFO_BTF check to bpftool feature command
Date: Mon, 22 Feb 2021 15:05:49 -0500 [thread overview]
Message-ID: <CAO658oUGKCrE8f-OvAD=1qZOOeFEYub=bLUZC1hCCQ_jVaps8g@mail.gmail.com> (raw)
In-Reply-To: <CAEf4BzYMvLg=B=ppjJpyr9VrjCFZepqyBKqgeaG8CakvpWq-Tw@mail.gmail.com>
I submitted a new patch that includes CONFIG_DEBUG_INFO_BTF_MODULES. I
renamed the patch to include this change so it's showing up as a new
thread, I also fixed the time issue, apologies for the confusion!
On Mon, Feb 22, 2021 at 2:22 PM Andrii Nakryiko
<andrii.nakryiko@gmail.com> wrote:
>
> On Mon, Feb 22, 2021 at 7:34 AM grantseltzer <grantseltzer@gmail.com> wrote:
> >
> > This adds the CONFIG_DEBUG_INFO_BTF kernel compile option to output of
> > the bpftool feature command. This is relevant for developers that want
> > to use libbpf to account for data structure definition differences
> > between kernels.
> >
> > Signed-off-by: grantseltzer <grantseltzer@gmail.com>
>
> Signed-off-by should have a properly capitalized (where it makes
> sense) real name of the author. Is it Grant Seltzer then?
>
> > ---
> > tools/bpf/bpftool/feature.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/tools/bpf/bpftool/feature.c b/tools/bpf/bpftool/feature.c
> > index 359960a8f..b90cc6832 100644
> > --- a/tools/bpf/bpftool/feature.c
> > +++ b/tools/bpf/bpftool/feature.c
> > @@ -336,6 +336,8 @@ static void probe_kernel_image_config(const char *define_prefix)
> > { "CONFIG_BPF_JIT", },
> > /* Avoid compiling eBPF interpreter (use JIT only) */
> > { "CONFIG_BPF_JIT_ALWAYS_ON", },
> > + /* Kernel BTF debug information available */
> > + { "CONFIG_DEBUG_INFO_BTF", },
>
> How about checking CONFIG_DEBUG_INFO_BTF_MODULES as well (i.e.,
> "Kernel module BTF information is available")?
>
> >
> > /* cgroups */
> > { "CONFIG_CGROUPS", },
> > --
> > 2.29.2
> >
prev parent reply other threads:[~2021-02-22 20:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-20 17:13 [PATCH v3 bpf-next] Add CONFIG_DEBUG_INFO_BTF check to bpftool feature command grantseltzer
2021-02-22 16:02 ` Quentin Monnet
2021-02-22 19:05 ` Martin KaFai Lau
2021-02-22 19:22 ` Andrii Nakryiko
2021-02-22 20:05 ` Grant Seltzer Richman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAO658oUGKCrE8f-OvAD=1qZOOeFEYub=bLUZC1hCCQ_jVaps8g@mail.gmail.com' \
--to=grantseltzer@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=irogers@google.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=mrostecki@opensuse.org \
--cc=netdev@vger.kernel.org \
--cc=quentin@isovalent.com \
--cc=songliubraving@fb.com \
--cc=tklauser@distanz.ch \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).