BPF Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v3 bpf-next] Add CONFIG_DEBUG_INFO_BTF check to bpftool feature command
@ 2021-02-20 17:13 grantseltzer
  2021-02-22 16:02 ` Quentin Monnet
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: grantseltzer @ 2021-02-20 17:13 UTC (permalink / raw)
  To: andrii, daniel, kafai, songliubraving, john.fastabend, kpsingh
  Cc: irogers, yhs, tklauser, netdev, mrostecki, ast, quentin, bpf,
	grantseltzer

This adds the CONFIG_DEBUG_INFO_BTF kernel compile option to output of
the bpftool feature command. This is relevant for developers that want
to use libbpf to account for data structure definition differences
between kernels.

Signed-off-by: grantseltzer <grantseltzer@gmail.com>
---
 tools/bpf/bpftool/feature.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/bpf/bpftool/feature.c b/tools/bpf/bpftool/feature.c
index 359960a8f..b90cc6832 100644
--- a/tools/bpf/bpftool/feature.c
+++ b/tools/bpf/bpftool/feature.c
@@ -336,6 +336,8 @@ static void probe_kernel_image_config(const char *define_prefix)
 		{ "CONFIG_BPF_JIT", },
 		/* Avoid compiling eBPF interpreter (use JIT only) */
 		{ "CONFIG_BPF_JIT_ALWAYS_ON", },
+		/* Kernel BTF debug information available */
+		{ "CONFIG_DEBUG_INFO_BTF", },
 
 		/* cgroups */
 		{ "CONFIG_CGROUPS", },
-- 
2.29.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v3 bpf-next] Add CONFIG_DEBUG_INFO_BTF check to bpftool feature command
  2021-02-20 17:13 [PATCH v3 bpf-next] Add CONFIG_DEBUG_INFO_BTF check to bpftool feature command grantseltzer
@ 2021-02-22 16:02 ` Quentin Monnet
  2021-02-22 19:05 ` Martin KaFai Lau
  2021-02-22 19:22 ` Andrii Nakryiko
  2 siblings, 0 replies; 5+ messages in thread
From: Quentin Monnet @ 2021-02-22 16:02 UTC (permalink / raw)
  To: grantseltzer, andrii, daniel, kafai, songliubraving,
	john.fastabend, kpsingh
  Cc: irogers, yhs, tklauser, netdev, mrostecki, ast, bpf

2021-02-20 17:13 UTC+0000 ~ grantseltzer <grantseltzer@gmail.com>
> This adds the CONFIG_DEBUG_INFO_BTF kernel compile option to output of
> the bpftool feature command. This is relevant for developers that want
> to use libbpf to account for data structure definition differences
> between kernels.
> 
> Signed-off-by: grantseltzer <grantseltzer@gmail.com>
> ---
>  tools/bpf/bpftool/feature.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/bpf/bpftool/feature.c b/tools/bpf/bpftool/feature.c
> index 359960a8f..b90cc6832 100644
> --- a/tools/bpf/bpftool/feature.c
> +++ b/tools/bpf/bpftool/feature.c
> @@ -336,6 +336,8 @@ static void probe_kernel_image_config(const char *define_prefix)
>  		{ "CONFIG_BPF_JIT", },
>  		/* Avoid compiling eBPF interpreter (use JIT only) */
>  		{ "CONFIG_BPF_JIT_ALWAYS_ON", },
> +		/* Kernel BTF debug information available */
> +		{ "CONFIG_DEBUG_INFO_BTF", },
>  
>  		/* cgroups */
>  		{ "CONFIG_CGROUPS", },
> 


Thanks for the change!

Reviewed-by: Quentin Monnet <quentin@isovalent.com>

(Note: the date of the email is not correct, but I discussed offline
with Grant and this is now sorted out for future submissions.)

Quentin

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v3 bpf-next] Add CONFIG_DEBUG_INFO_BTF check to bpftool feature command
  2021-02-20 17:13 [PATCH v3 bpf-next] Add CONFIG_DEBUG_INFO_BTF check to bpftool feature command grantseltzer
  2021-02-22 16:02 ` Quentin Monnet
@ 2021-02-22 19:05 ` Martin KaFai Lau
  2021-02-22 19:22 ` Andrii Nakryiko
  2 siblings, 0 replies; 5+ messages in thread
From: Martin KaFai Lau @ 2021-02-22 19:05 UTC (permalink / raw)
  To: grantseltzer
  Cc: andrii, daniel, songliubraving, john.fastabend, kpsingh, irogers,
	yhs, tklauser, netdev, mrostecki, ast, quentin, bpf

On Sat, Feb 20, 2021 at 05:13:07PM +0000, grantseltzer wrote:
> This adds the CONFIG_DEBUG_INFO_BTF kernel compile option to output of
> the bpftool feature command. This is relevant for developers that want
> to use libbpf to account for data structure definition differences
> between kernels.
Acked-by: Martin KaFai Lau <kafai@fb.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v3 bpf-next] Add CONFIG_DEBUG_INFO_BTF check to bpftool feature command
  2021-02-20 17:13 [PATCH v3 bpf-next] Add CONFIG_DEBUG_INFO_BTF check to bpftool feature command grantseltzer
  2021-02-22 16:02 ` Quentin Monnet
  2021-02-22 19:05 ` Martin KaFai Lau
@ 2021-02-22 19:22 ` Andrii Nakryiko
  2021-02-22 20:05   ` Grant Seltzer Richman
  2 siblings, 1 reply; 5+ messages in thread
From: Andrii Nakryiko @ 2021-02-22 19:22 UTC (permalink / raw)
  To: grantseltzer
  Cc: Andrii Nakryiko, Daniel Borkmann, Martin Lau, Song Liu,
	john fastabend, KP Singh, Ian Rogers, Yonghong Song,
	Tobias Klauser, Networking, Michal Rostecki, Alexei Starovoitov,
	Quentin Monnet, bpf

On Mon, Feb 22, 2021 at 7:34 AM grantseltzer <grantseltzer@gmail.com> wrote:
>
> This adds the CONFIG_DEBUG_INFO_BTF kernel compile option to output of
> the bpftool feature command. This is relevant for developers that want
> to use libbpf to account for data structure definition differences
> between kernels.
>
> Signed-off-by: grantseltzer <grantseltzer@gmail.com>

Signed-off-by should have a properly capitalized (where it makes
sense) real name of the author. Is it Grant Seltzer then?

> ---
>  tools/bpf/bpftool/feature.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tools/bpf/bpftool/feature.c b/tools/bpf/bpftool/feature.c
> index 359960a8f..b90cc6832 100644
> --- a/tools/bpf/bpftool/feature.c
> +++ b/tools/bpf/bpftool/feature.c
> @@ -336,6 +336,8 @@ static void probe_kernel_image_config(const char *define_prefix)
>                 { "CONFIG_BPF_JIT", },
>                 /* Avoid compiling eBPF interpreter (use JIT only) */
>                 { "CONFIG_BPF_JIT_ALWAYS_ON", },
> +               /* Kernel BTF debug information available */
> +               { "CONFIG_DEBUG_INFO_BTF", },

How about checking CONFIG_DEBUG_INFO_BTF_MODULES as well (i.e.,
"Kernel module BTF information is available")?

>
>                 /* cgroups */
>                 { "CONFIG_CGROUPS", },
> --
> 2.29.2
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v3 bpf-next] Add CONFIG_DEBUG_INFO_BTF check to bpftool feature command
  2021-02-22 19:22 ` Andrii Nakryiko
@ 2021-02-22 20:05   ` Grant Seltzer Richman
  0 siblings, 0 replies; 5+ messages in thread
From: Grant Seltzer Richman @ 2021-02-22 20:05 UTC (permalink / raw)
  To: Andrii Nakryiko
  Cc: Andrii Nakryiko, Daniel Borkmann, Martin Lau, Song Liu,
	john fastabend, KP Singh, Ian Rogers, Yonghong Song,
	Tobias Klauser, Networking, Michal Rostecki, Alexei Starovoitov,
	Quentin Monnet, bpf

I submitted a new patch that includes CONFIG_DEBUG_INFO_BTF_MODULES. I
renamed the patch to include this change so it's showing up as a new
thread, I also fixed the time issue, apologies for the confusion!

On Mon, Feb 22, 2021 at 2:22 PM Andrii Nakryiko
<andrii.nakryiko@gmail.com> wrote:
>
> On Mon, Feb 22, 2021 at 7:34 AM grantseltzer <grantseltzer@gmail.com> wrote:
> >
> > This adds the CONFIG_DEBUG_INFO_BTF kernel compile option to output of
> > the bpftool feature command. This is relevant for developers that want
> > to use libbpf to account for data structure definition differences
> > between kernels.
> >
> > Signed-off-by: grantseltzer <grantseltzer@gmail.com>
>
> Signed-off-by should have a properly capitalized (where it makes
> sense) real name of the author. Is it Grant Seltzer then?
>
> > ---
> >  tools/bpf/bpftool/feature.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/tools/bpf/bpftool/feature.c b/tools/bpf/bpftool/feature.c
> > index 359960a8f..b90cc6832 100644
> > --- a/tools/bpf/bpftool/feature.c
> > +++ b/tools/bpf/bpftool/feature.c
> > @@ -336,6 +336,8 @@ static void probe_kernel_image_config(const char *define_prefix)
> >                 { "CONFIG_BPF_JIT", },
> >                 /* Avoid compiling eBPF interpreter (use JIT only) */
> >                 { "CONFIG_BPF_JIT_ALWAYS_ON", },
> > +               /* Kernel BTF debug information available */
> > +               { "CONFIG_DEBUG_INFO_BTF", },
>
> How about checking CONFIG_DEBUG_INFO_BTF_MODULES as well (i.e.,
> "Kernel module BTF information is available")?
>
> >
> >                 /* cgroups */
> >                 { "CONFIG_CGROUPS", },
> > --
> > 2.29.2
> >

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-20 17:13 [PATCH v3 bpf-next] Add CONFIG_DEBUG_INFO_BTF check to bpftool feature command grantseltzer
2021-02-22 16:02 ` Quentin Monnet
2021-02-22 19:05 ` Martin KaFai Lau
2021-02-22 19:22 ` Andrii Nakryiko
2021-02-22 20:05   ` Grant Seltzer Richman

BPF Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/bpf/0 bpf/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 bpf bpf/ https://lore.kernel.org/bpf \
		bpf@vger.kernel.org
	public-inbox-index bpf

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.bpf


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git