BPF Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 1/2] selftests: bpf: test_lwt_ip_encap: add missing object file to TEST_FILES
@ 2019-11-07 12:52 Anders Roxell
  2019-11-07 12:52 ` [PATCH 2/2] selftests: bpf: test_tc_edt: " Anders Roxell
  2019-11-07 17:54 ` [PATCH 1/2] selftests: bpf: test_lwt_ip_encap: " Song Liu
  0 siblings, 2 replies; 5+ messages in thread
From: Anders Roxell @ 2019-11-07 12:52 UTC (permalink / raw)
  To: ast, daniel, davem
  Cc: netdev, bpf, linux-kselftest, linux-kernel, shuah, Anders Roxell

When installing kselftests to its own directory and running the
test_lwt_ip_encap.sh it will complain that test_lwt_ip_encap.o can't be
find.

$ ./test_lwt_ip_encap.sh
starting egress IPv4 encap test
Error opening object test_lwt_ip_encap.o: No such file or directory
Object hashing failed!
Cannot initialize ELF context!
Failed to parse eBPF program: Invalid argument

Rework to add test_lwt_ip_encap.o to TEST_FILES so the object file gets
installed when installing kselftest.

Fixes: 74b5a5968fe8 ("selftests/bpf: Replace test_progs and test_maps w/ general rule")
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
 tools/testing/selftests/bpf/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
index b334a6db15c1..cc09b5df9403 100644
--- a/tools/testing/selftests/bpf/Makefile
+++ b/tools/testing/selftests/bpf/Makefile
@@ -38,7 +38,7 @@ TEST_GEN_PROGS += test_progs-bpf_gcc
 endif
 
 TEST_GEN_FILES =
-TEST_FILES =
+TEST_FILES = test_lwt_ip_encap.o
 
 # Order correspond to 'make run_tests' order
 TEST_PROGS := test_kmod.sh \
-- 
2.20.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 2/2] selftests: bpf: test_tc_edt: add missing object file to TEST_FILES
  2019-11-07 12:52 [PATCH 1/2] selftests: bpf: test_lwt_ip_encap: add missing object file to TEST_FILES Anders Roxell
@ 2019-11-07 12:52 ` " Anders Roxell
  2019-11-07 17:55   ` Song Liu
  2019-11-07 17:54 ` [PATCH 1/2] selftests: bpf: test_lwt_ip_encap: " Song Liu
  1 sibling, 1 reply; 5+ messages in thread
From: Anders Roxell @ 2019-11-07 12:52 UTC (permalink / raw)
  To: ast, daniel, davem
  Cc: netdev, bpf, linux-kselftest, linux-kernel, shuah, Anders Roxell

When installing kselftests to its own directory and running the
test_tc_edt.sh it will complain that test_tc_edt.o can't be find.

$ ./test_tc_edt.sh
Error opening object test_tc_edt.o: No such file or directory
Object hashing failed!
Cannot initialize ELF context!
Unable to load program

Rework to add test_tc_edt.o to TEST_FILES so the object file gets
installed when installing kselftest.

Fixes: 74b5a5968fe8 ("selftests/bpf: Replace test_progs and test_maps w/ general rule")
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
 tools/testing/selftests/bpf/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
index cc09b5df9403..b03dc2298fea 100644
--- a/tools/testing/selftests/bpf/Makefile
+++ b/tools/testing/selftests/bpf/Makefile
@@ -38,7 +38,8 @@ TEST_GEN_PROGS += test_progs-bpf_gcc
 endif
 
 TEST_GEN_FILES =
-TEST_FILES = test_lwt_ip_encap.o
+TEST_FILES = test_lwt_ip_encap.o \
+	test_tc_edt.o
 
 # Order correspond to 'make run_tests' order
 TEST_PROGS := test_kmod.sh \
-- 
2.20.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] selftests: bpf: test_lwt_ip_encap: add missing object file to TEST_FILES
  2019-11-07 12:52 [PATCH 1/2] selftests: bpf: test_lwt_ip_encap: add missing object file to TEST_FILES Anders Roxell
  2019-11-07 12:52 ` [PATCH 2/2] selftests: bpf: test_tc_edt: " Anders Roxell
@ 2019-11-07 17:54 ` " Song Liu
  2019-11-10  9:15   ` Anders Roxell
  1 sibling, 1 reply; 5+ messages in thread
From: Song Liu @ 2019-11-07 17:54 UTC (permalink / raw)
  To: Anders Roxell
  Cc: Alexei Starovoitov, Daniel Borkmann, David S . Miller,
	Networking, bpf, linux-kselftest, open list, Shuah Khan

On Thu, Nov 7, 2019 at 4:53 AM Anders Roxell <anders.roxell@linaro.org> wrote:
>
> When installing kselftests to its own directory and running the
> test_lwt_ip_encap.sh it will complain that test_lwt_ip_encap.o can't be
> find.
>
> $ ./test_lwt_ip_encap.sh
> starting egress IPv4 encap test
> Error opening object test_lwt_ip_encap.o: No such file or directory
> Object hashing failed!
> Cannot initialize ELF context!
> Failed to parse eBPF program: Invalid argument
>
> Rework to add test_lwt_ip_encap.o to TEST_FILES so the object file gets
> installed when installing kselftest.
>
> Fixes: 74b5a5968fe8 ("selftests/bpf: Replace test_progs and test_maps w/ general rule")
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

Please highlight that this set is on top of bpf-next tree with
"[PATCH bpf-next 1/2]".

Otherwise, looks good to me.

Acked-by: Song Liu <songliubraving@fb.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] selftests: bpf: test_tc_edt: add missing object file to TEST_FILES
  2019-11-07 12:52 ` [PATCH 2/2] selftests: bpf: test_tc_edt: " Anders Roxell
@ 2019-11-07 17:55   ` Song Liu
  0 siblings, 0 replies; 5+ messages in thread
From: Song Liu @ 2019-11-07 17:55 UTC (permalink / raw)
  To: Anders Roxell
  Cc: Alexei Starovoitov, Daniel Borkmann, David S . Miller,
	Networking, bpf, linux-kselftest, open list, Shuah Khan

On Thu, Nov 7, 2019 at 4:53 AM Anders Roxell <anders.roxell@linaro.org> wrote:
>
> When installing kselftests to its own directory and running the
> test_tc_edt.sh it will complain that test_tc_edt.o can't be find.
>
> $ ./test_tc_edt.sh
> Error opening object test_tc_edt.o: No such file or directory
> Object hashing failed!
> Cannot initialize ELF context!
> Unable to load program
>
> Rework to add test_tc_edt.o to TEST_FILES so the object file gets
> installed when installing kselftest.
>
> Fixes: 74b5a5968fe8 ("selftests/bpf: Replace test_progs and test_maps w/ general rule")
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

Acked-by: Song Liu <songliubraving@fb.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] selftests: bpf: test_lwt_ip_encap: add missing object file to TEST_FILES
  2019-11-07 17:54 ` [PATCH 1/2] selftests: bpf: test_lwt_ip_encap: " Song Liu
@ 2019-11-10  9:15   ` Anders Roxell
  0 siblings, 0 replies; 5+ messages in thread
From: Anders Roxell @ 2019-11-10  9:15 UTC (permalink / raw)
  To: Song Liu
  Cc: Alexei Starovoitov, Daniel Borkmann, David S . Miller,
	Networking, bpf, open list:KERNEL SELFTEST FRAMEWORK, open list,
	Shuah Khan

On Thu, 7 Nov 2019 at 18:55, Song Liu <liu.song.a23@gmail.com> wrote:
>
> On Thu, Nov 7, 2019 at 4:53 AM Anders Roxell <anders.roxell@linaro.org> wrote:
> >
> > When installing kselftests to its own directory and running the
> > test_lwt_ip_encap.sh it will complain that test_lwt_ip_encap.o can't be
> > find.
> >
> > $ ./test_lwt_ip_encap.sh
> > starting egress IPv4 encap test
> > Error opening object test_lwt_ip_encap.o: No such file or directory
> > Object hashing failed!
> > Cannot initialize ELF context!
> > Failed to parse eBPF program: Invalid argument
> >
> > Rework to add test_lwt_ip_encap.o to TEST_FILES so the object file gets
> > installed when installing kselftest.
> >
> > Fixes: 74b5a5968fe8 ("selftests/bpf: Replace test_progs and test_maps w/ general rule")
> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>
> Please highlight that this set is on top of bpf-next tree with
> "[PATCH bpf-next 1/2]".

Oh right, I'll send out that shortly

Cheers,
Anders

>
> Otherwise, looks good to me.
>
> Acked-by: Song Liu <songliubraving@fb.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-07 12:52 [PATCH 1/2] selftests: bpf: test_lwt_ip_encap: add missing object file to TEST_FILES Anders Roxell
2019-11-07 12:52 ` [PATCH 2/2] selftests: bpf: test_tc_edt: " Anders Roxell
2019-11-07 17:55   ` Song Liu
2019-11-07 17:54 ` [PATCH 1/2] selftests: bpf: test_lwt_ip_encap: " Song Liu
2019-11-10  9:15   ` Anders Roxell

BPF Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/bpf/0 bpf/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 bpf bpf/ https://lore.kernel.org/bpf \
		bpf@vger.kernel.org
	public-inbox-index bpf

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.bpf


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git