Re: [Buildroot] [PATCH v9 05/11] board/ti/am62x_sk: add new board

From: Andreas Dannenberg via buildroot <buildroot@buildroot.org>
To: "François Perrad" <francois.perrad@gadz.org>,
	"Bryce Johnson" <bryce@redpinelabs.com>
Cc: Xuanhao Shi <x-shi@ti.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v9 05/11] board/ti/am62x_sk: add new board
Date: Tue, 15 Aug 2023 02:21:30 -0500	[thread overview]
Message-ID: <20230815072130.4sibvsh3wuql46xc@dasso> (raw)
In-Reply-To: <CAAE6iEVZSojnPcJxyM_o=jqi7huc_ymN00hyzLp0gkxNcUfEWA@mail.gmail.com>

François,
thanks for the feedback. Comment inlined...

On Sun, Jun 25, 2023 at 07:42:47AM +0200, François Perrad wrote:
> Le jeu. 22 juin 2023 à 18:07, Andreas Dannenberg via buildroot <
> buildroot@buildroot.org> a écrit :
> 
> > From: Xuanhao Shi <x-shi@ti.com>
> >
> > Adds support for TI's SK-AM62 board by introducing the
> > am62x_sk_defconfig file and related support files.
> >
> > More information about the board can be found at:
> > https://www.ti.com/tool/SK-AM62
> >
> > Signed-off-by: Xuanhao Shi <x-shi@ti.com>
> > Signed-off-by: Andreas Dannenberg <dannenberg@ti.com>
> > ---
> >  DEVELOPERS                     |  4 +++
> >  board/ti/am62x_sk/genimage.cfg | 27 ++++++++++++++++++++
> >  board/ti/am62x_sk/readme.txt   | 26 ++++++++++++++++++++
> >  configs/am62x_sk_defconfig     | 45 ++++++++++++++++++++++++++++++++++
> >  4 files changed, 102 insertions(+)
> >  create mode 100644 board/ti/am62x_sk/genimage.cfg
> >  create mode 100644 board/ti/am62x_sk/readme.txt
> >  create mode 100644 configs/am62x_sk_defconfig
> >
> > diff --git a/DEVELOPERS b/DEVELOPERS
> > index a4d729983b..8ce903b294 100644
> > --- a/DEVELOPERS
> > +++ b/DEVELOPERS
> > @@ -129,9 +129,11 @@ F: package/libxmlrpc/
> >  F:     package/python-docopt/
> >
> >  N:     Anand Gadiyar <gadiyar@ti.com>
> > +F:     board/ti/am62x_sk/
> >  F:     board/ti/am64x_sk/
> >  F:     boot/ti-k3-image-gen/
> >  F:     boot/ti-k3-r5-loader/
> > +F:     configs/am62x_sk_defconfig
> >  F:     configs/am64x_sk_defconfig
> >
> >  N:     André Zwing <nerv@dawncrow.de>
> > @@ -3023,9 +3025,11 @@ N:       Wojciech Niziński <niziak@spox.org>
> >  F:     package/fwup/
> >
> >  N:     Xuanhao Shi <X15000177@gmail.com>
> > +F:     board/ti/am62x_sk/
> >  F:     board/ti/am64x_sk/
> >  F:     boot/ti-k3-image-gen/
> >  F:     boot/ti-k3-r5-loader/
> > +F:     configs/am62x_sk_defconfig
> >  F:     configs/am64x_sk_defconfig
> >
> >  N:     Yair Ben Avraham <yairba@protonmail.com>
> > diff --git a/board/ti/am62x_sk/genimage.cfg
> > b/board/ti/am62x_sk/genimage.cfg
> > new file mode 100644
> > index 0000000000..26304fe98f
> > --- /dev/null
> > +++ b/board/ti/am62x_sk/genimage.cfg
> > @@ -0,0 +1,27 @@
> > +image boot.vfat {
> > +       vfat {
> > +               files = {
> > +                       "tiboot3.bin",
> > +                       "tispl.bin",
> > +                       "u-boot.img",
> > +               }
> > +       }
> > +
> > +       size = 16M
> > +}
> > +
> > +image sdcard.img {
> > +       hdimage {
> > +       }
> > +
> > +       partition u-boot {
> > +               partition-type = 0xC
> > +               bootable = "true"
> > +               image = "boot.vfat"
> > +       }
> > +
> > +       partition rootfs {
> > +               partition-type = 0x83
> > +               image = "rootfs.ext4"
> > +       }
> > +}
> > diff --git a/board/ti/am62x_sk/readme.txt b/board/ti/am62x_sk/readme.txt
> > new file mode 100644
> > index 0000000000..ccbb24896b
> > --- /dev/null
> > +++ b/board/ti/am62x_sk/readme.txt
> > @@ -0,0 +1,26 @@
> > +Texas Instuments SK-AM62 Test and Development Board
> > +
> > +Description
> > +===========
> > +This configuration will build a complete image for the TI SK-AM62 board.
> > +
> > +How to Build
> > +============
> > +Select the default configuration for the target:
> > +$ make am62x_sk_defconfig
> > +
> > +Optional: modify the configuration:
> > +$ make menuconfig
> > +
> > +Build:
> > +$ make
> > +
> > +To copy the resultimg output image file to an SD card use dd:
> > +$ dd if=output/images/sdcard.img of=/dev/sdX bs=1M
> > +
> > +How to Run
> > +==========
> > +Insert the SD card into the SK-AM62 board, and power it up through
> > +the USB Type-C connector. The system should come up. You can use
> > +a micro-USB cable to connect to the connector labeled UART to
> > +communicate with the board.
> > diff --git a/configs/am62x_sk_defconfig b/configs/am62x_sk_defconfig
> > new file mode 100644
> > index 0000000000..083720f512
> > --- /dev/null
> > +++ b/configs/am62x_sk_defconfig
> > @@ -0,0 +1,45 @@
> > +BR2_aarch64=y
> > +BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
> > +BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/ti/am62x_sk/genimage.cfg"
> > +BR2_LINUX_KERNEL=y
> > +BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFIG=y
> > +BR2_LINUX_KERNEL_DTS_SUPPORT=y
> > +BR2_LINUX_KERNEL_INTREE_DTS_NAME="ti/k3-am625-sk"
> > +BR2_LINUX_KERNEL_INSTALL_TARGET=y
> >
> 
> BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y  is missing at least at the end of
> the serie.

Yes good find, the same was since reported by Bryce (via DM), who
encountered build issues that he confirmed got fixed by adding this
line. Will include into v10.

--
Andreas Dannenberg
Texas Instruments Inc

> 
> François
> 
> 
> > +BR2_PACKAGE_LINUX_FIRMWARE=y
> > +BR2_PACKAGE_LINUX_FIRMWARE_TI_WL18XX=y
> > +BR2_TARGET_ROOTFS_EXT2=y
> > +BR2_TARGET_ROOTFS_EXT2_4=y
> > +BR2_TARGET_ROOTFS_EXT2_SIZE="256M"
> > +BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
> > +BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION=y
> > +BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_VERSION_VALUE="v2.7.0"
> > +BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="k3"
> > +BR2_TARGET_ARM_TRUSTED_FIRMWARE_TARGET_BOARD="lite"
> > +BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL32_OPTEE=y
> > +BR2_TARGET_OPTEE_OS=y
> > +BR2_TARGET_OPTEE_OS_PLATFORM="k3"
> > +BR2_TARGET_TI_K3_IMAGE_GEN=y
> > +BR2_TARGET_TI_K3_IMAGE_GEN_SOC="am62x"
> > +BR2_TARGET_TI_K3_IMAGE_GEN_SOC_TYPE_GP=y
> > +BR2_TARGET_TI_K3_IMAGE_GEN_CONFIG="evm"
> > +BR2_TARGET_TI_K3_R5_LOADER=y
> > +BR2_TARGET_TI_K3_R5_LOADER_BOARD_DEFCONFIG="am62x_evm_r5"
> > +BR2_TARGET_UBOOT=y
> > +BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
> > +BR2_TARGET_UBOOT_CUSTOM_VERSION=y
> > +BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2022.10"
> > +BR2_TARGET_UBOOT_BOARD_DEFCONFIG="am62x_evm_a53"
> > +BR2_TARGET_UBOOT_NEEDS_DTC=y
> > +BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
> > +BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y
> > +BR2_TARGET_UBOOT_NEEDS_TI_K3_DM=y
> > +BR2_TARGET_UBOOT_TI_K3_DM_SOC="am62xx"
> > +# BR2_TARGET_UBOOT_FORMAT_BIN is not set
> > +BR2_TARGET_UBOOT_FORMAT_IMG=y
> > +BR2_TARGET_UBOOT_SPL=y
> > +BR2_TARGET_UBOOT_SPL_NAME="tispl.bin"
> > +BR2_TARGET_UBOOT_CUSTOM_MAKEOPTS="TEE=$(BINARIES_DIR)/tee-pager_v2.bin"
> > +BR2_PACKAGE_HOST_DOSFSTOOLS=y
> > +BR2_PACKAGE_HOST_GENIMAGE=y
> > +BR2_PACKAGE_HOST_MTOOLS=y
> > --
> > 2.34.1
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
> >
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot