From: Arnout Vandecappelle via buildroot <buildroot@buildroot.org>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>,
Andreas Dannenberg <dannenberg@ti.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v9 01/11] boot/ti-k3-r5-loader: allow for full build source customization
Date: Sun, 25 Jun 2023 15:21:21 +0200 [thread overview]
Message-ID: <3c0e66a6-4ce2-f4d4-92b6-7b112190051e@mind.be> (raw)
In-Reply-To: <20230624212331.GE24952@scaer>
On 24/06/2023 23:23, Yann E. MORIN wrote:
> Andreas, All,
>
> On 2023-06-22 11:02 -0500, Andreas Dannenberg via buildroot spake thusly:
>> The TI K3 R5 loader package essentially is a wrapper to build a special
>> version of U-boot SPL used as part of a multi-stage boot flow on TI K3
>> devices, and as such needs full flexibility as to specifying the U-Boot
>> sources used for the build. To accomodate this, add the same options as
>> already available in the regular U-Boot package. For most use cases, the
>> same source settings (repo URL, versions, etc.) should be used for both
>> ti-k3-r5-loader and uboot packages.
>
> Currently, there is no dependency ("depends on" or "select") between
> uboot and ti-k3-r5-loader; yet, your phrasing seems to imply that it
> does not make sense to build ti-k3-r5-loader without building uboot.
That's not what I read in that paragraph. I think it means that the same
source should be used as U-Boot. It's just a separate package because, AFAIU, it
may use a different .config.
If that is true, and I'm not missing anything else, then the situation
actually looks quite similar to barebox-aux. With the difference that for Falcon
boot you want to have only "u-boot-aux" and not the full u-boot. So, if what I'm
saying is true, then perhaps it's better to approach it the same way as in barebox?
At the very minimum, I think there should be a "same version as U-Boot"
option, which is the default (if U-Boot is enabled). There's a bit the
unfortunate aspect that this package becomes before U-Boot in the menu, but
let's assume people typically start from a defconfig.
Regards,
Arnout
>
> Then, in the comment below, you add a note about "Falcon boot (which
> would skip the uboot package completely)".
>
> So, I'm a bit curious here: what should the user do when uboot is not
> enabled, if we instruct it to use the same version?
>
>> Signed-off-by: Andreas Dannenberg <dannenberg@ti.com>
>> ---
>> boot/ti-k3-r5-loader/Config.in | 65 +++++++++++++++++++++++--
>> boot/ti-k3-r5-loader/ti-k3-r5-loader.mk | 32 +++++++++++-
>> 2 files changed, 93 insertions(+), 4 deletions(-)
>>
>> diff --git a/boot/ti-k3-r5-loader/Config.in b/boot/ti-k3-r5-loader/Config.in
>> index 10602c8df3..2419babe70 100644
>> --- a/boot/ti-k3-r5-loader/Config.in
>> +++ b/boot/ti-k3-r5-loader/Config.in
>> @@ -1,14 +1,73 @@
>> config BR2_TARGET_TI_K3_R5_LOADER
>> - bool "ti-k3-r5-loader"
>> + bool "TI K3 R5 Loader"
>
> Our prompts always match the package name in Buildroot, i.e. the
> directory name. In this case, ti-k3-r5-loader is exactly that and we
> want to keep that.
>
>> depends on BR2_aarch64
>> help
>> - Separate U-Boot build for R5 cores on TI's k3 boards.
>> + Separate U-Boot SPL build for R5 core on TI's K3 processors.
>> Usually used to build tiboot3.bin with k3-image-gen.
>>
>> if BR2_TARGET_TI_K3_R5_LOADER
>>
>> choice
>> - prompt "Configuration"
>> + prompt "U-Boot Version"
>
> It is a bit confusing tho see "U-Boot version" in the "ti-k3-r5-loader"
> package. I know it is really just a uboot being compiled, but still this
> is confusing. I'd keep ti-k3-r5-loader in the prompts. I could be
> convinced for the middle ground "ti-k3-r5-loader U-Boot version" if you
> really want to have U-Boot there.
>
> Since you want the defaults to be the same as uboot, you can do that:
>
> choice
> bool "U-Boot version"
> default BR2_TARGET_TI_K3_R5_LOADER_LATEST_VERSION if BR2_TARGET_UBOOT_LATEST_VERSION
> default BR2_TARGET_TI_K3_R5_LOADER_CUSTOM_VERSION if BR2_TARGET_UBOOT_CUSTOM_VERSION
> default BR2_TARGET_TI_K3_R5_LOADER_CUSTOM_TARBALL if BR2_TARGET_UBOOT_CUSTOM_TARBALL
> default BR2_TARGET_TI_K3_R5_LOADER_CUSTOM_GIT if BR2_TARGET_UBOOT_CUSTOM_GIT
> default BR2_TARGET_TI_K3_R5_LOADER_CUSTOM_HG if BR2_TARGET_UBOOT_CUSTOM_HG
> default BR2_TARGET_TI_K3_R5_LOADER_CUSTOM_SVN if BR2_TARGET_UBOOT_CUSTOM_SVN
> default BR2_TARGET_TI_K3_R5_LOADER_LATEST_VERSION # Fallback if uboot not enabled
>
> ...
> endchoice
>
> config BR2_TARGET_TI_K3_R5_LOADER_CUSTOM_VERSION_VALUE
> string "U-Boot version"
> default BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE
> depends on BR2_TARGET_TI_K3_R5_LOADER_CUSTOM_VERSION
>
> config BR2_TARGET_TI_K3_R5_LOADER_CUSTOM_TARBALL_LOCATION
> string "URL of custom U-Boot tarball"
> default BR2_TARGET_UBOOT_CUSTOM_TARBALL_LOCATION
> depends on BR2_TARGET_TI_K3_R5_LOADER_CUSTOM_TARBALL
>
> ... and so on, you get the gist.
>
> [--SNIP--]
>> + prompt "U-Boot Configuration"
>
> Same comment as for the version prompt.
>
> [--SNIP--]
>> diff --git a/boot/ti-k3-r5-loader/ti-k3-r5-loader.mk b/boot/ti-k3-r5-loader/ti-k3-r5-loader.mk
>> index afa309aa98..341888623e 100644
>> --- a/boot/ti-k3-r5-loader/ti-k3-r5-loader.mk
>> +++ b/boot/ti-k3-r5-loader/ti-k3-r5-loader.mk
>> @@ -2,11 +2,41 @@
>> #
>> # ti-k3-r5-loader
>> #
>> +# The ti-k3-r5 loader package should really be built from the same U-Boot
>> +# sources as the uboot package itself, so for most users so all LOADER_SITE /
>> +# LOADER_SOURCE type definitions should be set the same for both packages.
>> +# However it still makes sense to keep the ti-k3-r5-loader package somewhat
>> +# separated and independent from the uboot package to allow for special use
>> +# cases such as Falcon boot (which would skip the uboot package completely).
>
> Do you mean that uboot would not be built at all, or that the uboot
> binary would not be loaded at runtime?
>
> Regards,
> Yann E. MORIN.
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-06-25 13:21 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 16:02 [Buildroot] [PATCH v9 00/11] add support for TI's AM64x and AM62x boards Andreas Dannenberg via buildroot
2023-06-22 16:02 ` [Buildroot] [PATCH v9 01/11] boot/ti-k3-r5-loader: allow for full build source customization Andreas Dannenberg via buildroot
2023-06-24 21:23 ` Yann E. MORIN
2023-06-25 13:21 ` Arnout Vandecappelle via buildroot [this message]
2023-06-25 13:35 ` Yann E. MORIN
2023-06-26 19:44 ` Julien Olivain
2023-06-26 19:53 ` Julien Olivain
2023-06-22 16:02 ` [Buildroot] [PATCH v9 02/11] boot/ti-k3-image-gen: new package Andreas Dannenberg via buildroot
2023-06-24 22:28 ` Yann E. MORIN
2023-08-08 23:38 ` Bryce Johnson
2023-08-15 7:15 ` Andreas Dannenberg via buildroot
2023-08-15 22:54 ` Bryce Johnson
2023-06-22 16:02 ` [Buildroot] [PATCH v9 03/11] boot/uboot: add support for building the TI K3 DM into U-Boot Andreas Dannenberg via buildroot
2023-06-25 7:02 ` Yann E. MORIN
2023-06-25 7:08 ` Yann E. MORIN
2023-06-22 16:02 ` [Buildroot] [PATCH v9 04/11] board/ti/am64x_sk: add new board Andreas Dannenberg via buildroot
2023-06-25 5:41 ` François Perrad
2023-06-25 13:43 ` Yann E. MORIN
2023-06-22 16:02 ` [Buildroot] [PATCH v9 05/11] board/ti/am62x_sk: " Andreas Dannenberg via buildroot
2023-06-25 5:42 ` François Perrad
2023-08-15 7:21 ` Andreas Dannenberg via buildroot
2023-06-22 16:02 ` [Buildroot] [PATCH v9 06/11] board/ti/am62x_sk|am64x_sk: switch to TI SDK v8.6 sources Andreas Dannenberg via buildroot
2023-06-25 13:54 ` Yann E. MORIN
2023-06-25 14:33 ` Arnout Vandecappelle via buildroot
2023-06-25 15:22 ` Peter Korsgaard
2023-06-25 18:59 ` Arnout Vandecappelle via buildroot
2023-06-25 19:14 ` Peter Korsgaard
2023-06-25 19:36 ` Yann E. MORIN
2023-06-22 16:02 ` [Buildroot] [PATCH v9 07/11] package/ti-core-secdev-k3: new package Andreas Dannenberg via buildroot
2023-06-23 3:48 ` Patrick Oppenlander
2023-06-23 14:53 ` Andreas Dannenberg via buildroot
2023-06-24 0:32 ` Patrick Oppenlander
2023-06-24 1:11 ` Andreas Dannenberg via buildroot
2023-06-24 4:09 ` Patrick Oppenlander
2023-06-25 7:55 ` Yann E. MORIN
2023-06-25 13:26 ` Arnout Vandecappelle via buildroot
2023-06-22 16:02 ` [Buildroot] [PATCH v9 08/11] board/ti/am62x_sk|am64x_sk: switch to HS-FS device variants Andreas Dannenberg via buildroot
2023-06-22 16:02 ` [Buildroot] [PATCH v9 09/11] package/ti-rogue-km: new package Andreas Dannenberg via buildroot
2023-06-25 8:59 ` Yann E. MORIN
2023-08-18 17:30 ` Bryce Johnson
2023-06-22 16:02 ` [Buildroot] [PATCH v9 10/11] package/ti-rogue-um: " Andreas Dannenberg via buildroot
2023-06-23 7:30 ` François Perrad
2023-06-23 14:59 ` Andreas Dannenberg via buildroot
2023-06-25 5:37 ` François Perrad
2023-06-25 10:15 ` Yann E. MORIN
2023-06-27 2:02 ` Andreas Dannenberg via buildroot
2023-08-22 15:15 ` Thomas Petazzoni via buildroot
2023-06-27 22:48 ` Andreas Dannenberg via buildroot
2023-08-22 10:40 ` Thomas Petazzoni via buildroot
2023-06-22 16:02 ` [Buildroot] [PATCH v9 11/11] configs/am62x_sk_defconfig: enable IMG Rogue graphics driver Andreas Dannenberg via buildroot
2023-06-23 4:02 ` [Buildroot] [PATCH v9 00/11] add support for TI's AM64x and AM62x boards Patrick Oppenlander
2023-06-23 15:04 ` Andreas Dannenberg via buildroot
2023-08-22 10:14 ` Thomas Petazzoni via buildroot
2023-08-22 18:05 ` Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c0e66a6-4ce2-f4d4-92b6-7b112190051e@mind.be \
--to=buildroot@buildroot.org \
--cc=arnout@mind.be \
--cc=dannenberg@ti.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).