Re: [Buildroot] [PATCH v9 07/11] package/ti-core-secdev-k3: new package

[Arnout Vandecappelle via buildroot <buildroot@buildroot.org>]

On 25/06/2023 09:55, Yann E. MORIN wrote:
> Andreas, Patrick, All,
> 
> On 2023-06-23 09:53 -0500, Andreas Dannenberg via buildroot spake thusly:
>> On Fri, Jun 23, 2023 at 01:48:30PM +1000, Patrick Oppenlander wrote:
> [--SNIP--]
>>>> diff --git a/package/ti-core-secdev-k3/ti-core-secdev-k3.mk b/package/ti-core-secdev-k3/ti-core-secdev-k3.mk
>>>> new file mode 100644
>>>> index 0000000000..c388af2865
>>>> --- /dev/null
>>>> +++ b/package/ti-core-secdev-k3/ti-core-secdev-k3.mk
>>>> @@ -0,0 +1,31 @@
>>>> +################################################################################
>>>> +#
>>>> +# ti-core-secdev-k3
>>>> +#
>>>> +################################################################################
>>>> +
>>>> +TI_CORE_SECDEV_K3_VERSION = 08.06.00.007
> 
> I see this version present (either used or referenced) in multiple
> packages. Would it be possible, and would it make sense to share a
> it in a single location?
> 
> This is going to be a bit tricky, because the variable must be set
> _before_ any package that uses it gets parsed. WE usually ensure this by
> having all packages in a common directory (like the Qt5 stuff in
> package/qt5/), but here we have packages in package/ and in boot/, so I
> can see a little issue...

  Well, package/ is parsed before boot/ is, so the order is implicitly 
guaranteed. It's a bit meh to rely on that though.

  Regards,
  Arnout

[snip]
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot