* [Buildroot] [PATCH 1/1] package/dcron: fix /etc/cron.d/system cron jobs
@ 2022-09-02 22:28 Mario Haustein
2022-09-24 8:30 ` Thomas Petazzoni
2022-09-26 16:08 ` [Buildroot] [PATCH v2] " Mario Haustein
0 siblings, 2 replies; 6+ messages in thread
From: Mario Haustein @ 2022-09-02 22:28 UTC (permalink / raw)
To: buildroot; +Cc: Mario Haustein, Alvaro G . M
Jobs with the syntax @hourly, @daily, ... were not executed since the
recent version bump. This patch fixes the bug downstream.
Signed-off-by: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
---
package/dcron/0002-system-crontab.patch | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
create mode 100644 package/dcron/0002-system-crontab.patch
diff --git a/package/dcron/0002-system-crontab.patch b/package/dcron/0002-system-crontab.patch
new file mode 100644
index 0000000000..5573c68111
--- /dev/null
+++ b/package/dcron/0002-system-crontab.patch
@@ -0,0 +1,23 @@
+commit 1fd99b71b063b1573beaf9f6b801ec5be2fbe24f
+Author: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
+Date: Fri Sep 2 23:20:14 2022 +0200
+
+ Make @hourly, @daily, ... work again
+
+ closes #15
+
+ Signed-off-by: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
+
+diff --git a/database.c b/database.c
+index 37cf17a..6ec720e 100644
+--- a/database.c
++++ b/database.c
+@@ -455,6 +455,8 @@ SynchronizeFile(const char *dpath, const char *fileName, const char *userName)
+ line.cl_Days[j] = 1;
+ for (j=0; j<12; ++j)
+ line.cl_Mons[j] = 1;
++ for (j=0; j<7; ++j)
++ line.cl_Dow[j] = ALL_DOW;
+ }
+
+ while (*ptr == ' ' || *ptr == '\t')
--
2.30.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/dcron: fix /etc/cron.d/system cron jobs
2022-09-02 22:28 [Buildroot] [PATCH 1/1] package/dcron: fix /etc/cron.d/system cron jobs Mario Haustein
@ 2022-09-24 8:30 ` Thomas Petazzoni
2022-09-26 16:15 ` Mario Haustein
2022-09-26 16:08 ` [Buildroot] [PATCH v2] " Mario Haustein
1 sibling, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2022-09-24 8:30 UTC (permalink / raw)
To: Mario Haustein; +Cc: Alvaro G . M, buildroot
Hello Mario,
Thanks for your patch. See below some questions/comments.
On Sat, 3 Sep 2022 00:28:49 +0200
Mario Haustein <mario.haustein@hrz.tu-chemnitz.de> wrote:
> Jobs with the syntax @hourly, @daily, ... were not executed since the
> recent version bump. This patch fixes the bug downstream.
Which "recent" version bump ?
The last commit on package/dcron/ in Builroot is from January 2021, I
wouldn't call it recent. It bumped from version 4.5 to
1ba33c3325df48de46263276a43ed76cf9d81518, while switching to
https://github.com/dubiousjim/dcron/ as the upstream location.
Is it this version bump that broke things?
> diff --git a/package/dcron/0002-system-crontab.patch b/package/dcron/0002-system-crontab.patch
> new file mode 100644
> index 0000000000..5573c68111
> --- /dev/null
> +++ b/package/dcron/0002-system-crontab.patch
> @@ -0,0 +1,23 @@
> +commit 1fd99b71b063b1573beaf9f6b801ec5be2fbe24f
> +Author: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
> +Date: Fri Sep 2 23:20:14 2022 +0200
> +
> + Make @hourly, @daily, ... work again
> +
> + closes #15
> +
> + Signed-off-by: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
Could you use "git format-patch" to generate this patch, and include in
it a reference to the upstream pull request
https://github.com/dubiousjim/dcron/pull/35.
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/dcron: fix /etc/cron.d/system cron jobs
2022-09-24 8:30 ` Thomas Petazzoni
@ 2022-09-26 16:15 ` Mario Haustein
0 siblings, 0 replies; 6+ messages in thread
From: Mario Haustein @ 2022-09-26 16:15 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: Alvaro G . M, buildroot
[-- Attachment #1.1: Type: text/plain, Size: 1379 bytes --]
Am Samstag, 24. September 2022, 10:30:36 CEST schrieb Thomas Petazzoni:
> Hello Mario,
Hello Thomas,
> Thanks for your patch. See below some questions/comments.
>
> On Sat, 3 Sep 2022 00:28:49 +0200
>
> Mario Haustein <mario.haustein@hrz.tu-chemnitz.de> wrote:
> > Jobs with the syntax @hourly, @daily, ... were not executed since the
> > recent version bump. This patch fixes the bug downstream.
>
> Which "recent" version bump ?
I meant the latest version bump in buildroot, so effectively the bump from
version 4.5 to commit 1ba33c3325df48de46263276a43ed76cf9d81518.
The bug was introduced by the upstream commit
f048a83da348c1d62204fcbdf407b7abf33e3db0 AFAIR.
> The last commit on package/dcron/ in Builroot is from January 2021, I
> wouldn't call it recent. It bumped from version 4.5 to
> 1ba33c3325df48de46263276a43ed76cf9d81518, while switching to
> https://github.com/dubiousjim/dcron/ as the upstream location.
>
> Is it this version bump that broke things?
Yes.
> Could you use "git format-patch" to generate this patch, and include in
> it a reference to the upstream pull request
> https://github.com/dubiousjim/dcron/pull/35.
I prepared an updated version of the patch. I hope you are satisfied with the
update. If there is something I missed, just tell. It's my first patch to
buildroot, so I'm not familiar with the procedure.
Kind Regards
Mario
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 150 bytes --]
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2] package/dcron: fix /etc/cron.d/system cron jobs
2022-09-02 22:28 [Buildroot] [PATCH 1/1] package/dcron: fix /etc/cron.d/system cron jobs Mario Haustein
2022-09-24 8:30 ` Thomas Petazzoni
@ 2022-09-26 16:08 ` Mario Haustein
2023-04-17 6:48 ` Yann E. MORIN
2023-04-23 10:37 ` Peter Korsgaard
1 sibling, 2 replies; 6+ messages in thread
From: Mario Haustein @ 2022-09-26 16:08 UTC (permalink / raw)
To: buildroot; +Cc: Mario Haustein, Alvaro G. M
Jobs with the syntax @hourly, @daily, ... were not executed since the
version bump from `v4.5` to commit `1ba33c3325df48de46263276a43ed76cf9d81518`.
This patch fixes the bug downstream.
Signed-off-by: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
---
Changes v1 -> v2:
- Use `git format-patch` to export the patch
- Specify the version bump which broke dcron in the commit message
Signed-off-by: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
---
package/dcron/0002-system-crontab.patch | 28 +++++++++++++++++++++++++
1 file changed, 28 insertions(+)
create mode 100644 package/dcron/0002-system-crontab.patch
diff --git a/package/dcron/0002-system-crontab.patch b/package/dcron/0002-system-crontab.patch
new file mode 100644
index 0000000000..95d9606b7a
--- /dev/null
+++ b/package/dcron/0002-system-crontab.patch
@@ -0,0 +1,28 @@
+From 1fd99b71b063b1573beaf9f6b801ec5be2fbe24f Mon Sep 17 00:00:00 2001
+From: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
+Date: Fri, 2 Sep 2022 23:20:14 +0200
+Subject: [PATCH] Make @hourly, @daily, ... work again
+
+closes #15
+
+Signed-off-by: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
+[Upstream status: https://github.com/dubiousjim/dcron/pull/35]
+---
+ database.c | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/database.c b/database.c
+index 37cf17a..6ec720e 100644
+--- a/database.c
++++ b/database.c
+@@ -455,6 +455,8 @@ SynchronizeFile(const char *dpath, const char *fileName, const char *userName)
+ line.cl_Days[j] = 1;
+ for (j=0; j<12; ++j)
+ line.cl_Mons[j] = 1;
++ for (j=0; j<7; ++j)
++ line.cl_Dow[j] = ALL_DOW;
+ }
+
+ while (*ptr == ' ' || *ptr == '\t')
+--
+2.35.1
--
2.30.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH v2] package/dcron: fix /etc/cron.d/system cron jobs
2022-09-26 16:08 ` [Buildroot] [PATCH v2] " Mario Haustein
@ 2023-04-17 6:48 ` Yann E. MORIN
2023-04-23 10:37 ` Peter Korsgaard
1 sibling, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2023-04-17 6:48 UTC (permalink / raw)
To: Mario Haustein; +Cc: Alvaro G. M, buildroot
Mario, All,
Sorry, for the long delay...
> Jobs with the syntax @hourly, @daily, ... were not executed since the
> version bump from `v4.5` to commit `1ba33c3325df48de46263276a43ed76cf9d81518`.
> This patch fixes the bug downstream.
>
> Signed-off-by: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
Without any feedback from upstream, which has been inactive for more
than a year now: applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> Changes v1 -> v2:
> - Use `git format-patch` to export the patch
> - Specify the version bump which broke dcron in the commit message
>
> Signed-off-by: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
> ---
> package/dcron/0002-system-crontab.patch | 28 +++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
> create mode 100644 package/dcron/0002-system-crontab.patch
>
> diff --git a/package/dcron/0002-system-crontab.patch b/package/dcron/0002-system-crontab.patch
> new file mode 100644
> index 0000000000..95d9606b7a
> --- /dev/null
> +++ b/package/dcron/0002-system-crontab.patch
> @@ -0,0 +1,28 @@
> +From 1fd99b71b063b1573beaf9f6b801ec5be2fbe24f Mon Sep 17 00:00:00 2001
> +From: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
> +Date: Fri, 2 Sep 2022 23:20:14 +0200
> +Subject: [PATCH] Make @hourly, @daily, ... work again
> +
> +closes #15
> +
> +Signed-off-by: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
> +[Upstream status: https://github.com/dubiousjim/dcron/pull/35]
> +---
> + database.c | 2 ++
> + 1 file changed, 2 insertions(+)
> +
> +diff --git a/database.c b/database.c
> +index 37cf17a..6ec720e 100644
> +--- a/database.c
> ++++ b/database.c
> +@@ -455,6 +455,8 @@ SynchronizeFile(const char *dpath, const char *fileName, const char *userName)
> + line.cl_Days[j] = 1;
> + for (j=0; j<12; ++j)
> + line.cl_Mons[j] = 1;
> ++ for (j=0; j<7; ++j)
> ++ line.cl_Dow[j] = ALL_DOW;
> + }
> +
> + while (*ptr == ' ' || *ptr == '\t')
> +--
> +2.35.1
> --
> 2.30.2
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH v2] package/dcron: fix /etc/cron.d/system cron jobs
2022-09-26 16:08 ` [Buildroot] [PATCH v2] " Mario Haustein
2023-04-17 6:48 ` Yann E. MORIN
@ 2023-04-23 10:37 ` Peter Korsgaard
1 sibling, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2023-04-23 10:37 UTC (permalink / raw)
To: Mario Haustein; +Cc: Alvaro G. M, buildroot
>>>>> "Mario" == Mario Haustein <mario.haustein@hrz.tu-chemnitz.de> writes:
> Jobs with the syntax @hourly, @daily, ... were not executed since the
> version bump from `v4.5` to commit `1ba33c3325df48de46263276a43ed76cf9d81518`.
> This patch fixes the bug downstream.
> Signed-off-by: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
> ---
> Changes v1 -> v2:
> - Use `git format-patch` to export the patch
> - Specify the version bump which broke dcron in the commit message
> Signed-off-by: Mario Haustein <mario.haustein@hrz.tu-chemnitz.de>
Committed to 2023.02.x and 2022.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-04-23 10:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-02 22:28 [Buildroot] [PATCH 1/1] package/dcron: fix /etc/cron.d/system cron jobs Mario Haustein
2022-09-24 8:30 ` Thomas Petazzoni
2022-09-26 16:15 ` Mario Haustein
2022-09-26 16:08 ` [Buildroot] [PATCH v2] " Mario Haustein
2023-04-17 6:48 ` Yann E. MORIN
2023-04-23 10:37 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).