* [Buildroot] [PATCH] package/python-pysftp: add missing C++ dependency from paramiko
@ 2021-07-20 10:08 Thomas Petazzoni
2021-07-25 13:37 ` Thomas Petazzoni
2021-08-05 10:06 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2021-07-20 10:08 UTC (permalink / raw)
To: buildroot
python-paramiko has a dependency on C++ support, which was added in
commit 2d7b73cf75daedd4a198a75546308fedae7c9467 in 2016.
When python-pysftp was added in commit
3b920487bad119abf5bfb10a237cedd3b5278c10 in 2020, this C++ dependency
was not propagated, even though python-pysftp selects python-paramiko.
This commit fixes this issue by propagating the dependency, which
fixes this warning:
WARNING: unmet direct dependencies detected for BR2_PACKAGE_PYTHON_PARAMIKO
Depends on [n]: (BR2_PACKAGE_PYTHON [=n] || BR2_PACKAGE_PYTHON3 [=y]) && BR2_PACKAGE_PYTHON3 [=y] && BR2_INSTALL_LIBSTDCPP [=n]
Selected by [y]:
- BR2_PACKAGE_PYTHON_PYSFTP [=y] && (BR2_PACKAGE_PYTHON [=n] || BR2_PACKAGE_PYTHON3 [=y]) && BR2_PACKAGE_PYTHON3 [=y]
That occurs with configuration with C++ disabled, but python-pysftp
enabled.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
package/python-pysftp/Config.in | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/package/python-pysftp/Config.in b/package/python-pysftp/Config.in
index de2d2df63d..5d5b731f33 100644
--- a/package/python-pysftp/Config.in
+++ b/package/python-pysftp/Config.in
@@ -1,8 +1,13 @@
config BR2_PACKAGE_PYTHON_PYSFTP
bool "python-pysftp"
depends on BR2_PACKAGE_PYTHON3 # python-paramiko -> python-bcrypt
+ depends on BR2_INSTALL_LIBSTDCPP # python-paramiko
select BR2_PACKAGE_PYTHON_PARAMIKO # runtime
help
A friendly face on SFTP.
https://bitbucket.org/dundeemt/pysftp
+
+comment "python-pysftp needs a toolchain w/ C++"
+ depends on BR2_PACKAGE_PYTHON3
+ depends on !BR2_INSTALL_LIBSTDCPP
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] package/python-pysftp: add missing C++ dependency from paramiko
2021-07-20 10:08 [Buildroot] [PATCH] package/python-pysftp: add missing C++ dependency from paramiko Thomas Petazzoni
@ 2021-07-25 13:37 ` Thomas Petazzoni
2021-08-05 10:06 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2021-07-25 13:37 UTC (permalink / raw)
To: buildroot; +Cc: Matt Weber, Asaf Kahlon
On Tue, 20 Jul 2021 12:08:28 +0200
Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> python-paramiko has a dependency on C++ support, which was added in
> commit 2d7b73cf75daedd4a198a75546308fedae7c9467 in 2016.
>
> When python-pysftp was added in commit
> 3b920487bad119abf5bfb10a237cedd3b5278c10 in 2020, this C++ dependency
> was not propagated, even though python-pysftp selects python-paramiko.
>
> This commit fixes this issue by propagating the dependency, which
> fixes this warning:
>
> WARNING: unmet direct dependencies detected for BR2_PACKAGE_PYTHON_PARAMIKO
> Depends on [n]: (BR2_PACKAGE_PYTHON [=n] || BR2_PACKAGE_PYTHON3 [=y]) && BR2_PACKAGE_PYTHON3 [=y] && BR2_INSTALL_LIBSTDCPP [=n]
> Selected by [y]:
> - BR2_PACKAGE_PYTHON_PYSFTP [=y] && (BR2_PACKAGE_PYTHON [=n] || BR2_PACKAGE_PYTHON3 [=y]) && BR2_PACKAGE_PYTHON3 [=y]
>
> That occurs with configuration with C++ disabled, but python-pysftp
> enabled.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
> package/python-pysftp/Config.in | 5 +++++
> 1 file changed, 5 insertions(+)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] package/python-pysftp: add missing C++ dependency from paramiko
2021-07-20 10:08 [Buildroot] [PATCH] package/python-pysftp: add missing C++ dependency from paramiko Thomas Petazzoni
2021-07-25 13:37 ` Thomas Petazzoni
@ 2021-08-05 10:06 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2021-08-05 10:06 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: Matt Weber, Asaf Kahlon, buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> python-paramiko has a dependency on C++ support, which was added in
> commit 2d7b73cf75daedd4a198a75546308fedae7c9467 in 2016.
> When python-pysftp was added in commit
> 3b920487bad119abf5bfb10a237cedd3b5278c10 in 2020, this C++ dependency
> was not propagated, even though python-pysftp selects python-paramiko.
> This commit fixes this issue by propagating the dependency, which
> fixes this warning:
> WARNING: unmet direct dependencies detected for BR2_PACKAGE_PYTHON_PARAMIKO
> Depends on [n]: (BR2_PACKAGE_PYTHON [=n] || BR2_PACKAGE_PYTHON3 [=y]) && BR2_PACKAGE_PYTHON3 [=y] && BR2_INSTALL_LIBSTDCPP [=n]
> Selected by [y]:
> - BR2_PACKAGE_PYTHON_PYSFTP [=y] && (BR2_PACKAGE_PYTHON [=n] || BR2_PACKAGE_PYTHON3 [=y]) && BR2_PACKAGE_PYTHON3 [=y]
> That occurs with configuration with C++ disabled, but python-pysftp
> enabled.
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Committed to 2021.02.x and 2021.05.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-05 10:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-20 10:08 [Buildroot] [PATCH] package/python-pysftp: add missing C++ dependency from paramiko Thomas Petazzoni
2021-07-25 13:37 ` Thomas Petazzoni
2021-08-05 10:06 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).