From: kalyan_t@codeaurora.org To: Rob Clark <robdclark@gmail.com> Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Krishna Manikandan <mkrishn@codeaurora.org>, linux-arm-msm <linux-arm-msm@vger.kernel.org>, Raviteja Tamatam <travitej@codeaurora.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, Douglas Anderson <dianders@chromium.org>, nganji@codeaurora.org, Sean Paul <seanpaul@chromium.org>, "Kristian H. Kristensen" <hoegsberg@chromium.org>, Stephen Boyd <swboyd@chromium.org>, freedreno <freedreno@lists.freedesktop.org> Subject: Re: [Freedreno] [v1] drm/msm/dpu: enumerate second cursor pipe for external interface Date: Mon, 13 Jul 2020 15:48:41 +0530 [thread overview] Message-ID: <c10c0f70988d42037ccaccc6b5474942@codeaurora.org> (raw) In-Reply-To: <CAF6AEGtPDh7q6Hjophdyz+Pvi93-bK5WULGeSw9P4BWRw5SWxQ@mail.gmail.com> On 2020-07-10 22:19, Rob Clark wrote: > On Thu, Jun 25, 2020 at 5:46 AM Kalyan Thota <kalyan_t@codeaurora.org> > wrote: >> >> Setup an RGB HW pipe as cursor which can be used on >> secondary interface. >> >> For SC7180 2 HW pipes are enumerated as cursors >> 1 - primary interface >> 2 - secondary interface >> >> Signed-off-by: Kalyan Thota <kalyan_t@codeaurora.org> >> --- >> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 12 ++++++------ >> 1 file changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c >> b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c >> index 8f2357d..23061fd 100644 >> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c >> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c >> @@ -117,10 +117,10 @@ >> .reg_off = 0x2AC, .bit_off = 0}, >> .clk_ctrls[DPU_CLK_CTRL_DMA0] = { >> .reg_off = 0x2AC, .bit_off = 8}, >> - .clk_ctrls[DPU_CLK_CTRL_DMA1] = { >> - .reg_off = 0x2B4, .bit_off = 8}, >> .clk_ctrls[DPU_CLK_CTRL_CURSOR0] = { >> - .reg_off = 0x2BC, .bit_off = 8}, >> + .reg_off = 0x2B4, .bit_off = 8}, >> + .clk_ctrls[DPU_CLK_CTRL_CURSOR1] = { >> + .reg_off = 0x2C4, .bit_off = 8}, > > It looks like you shifted the register offset here from 0x2bc to > 0x2c4, was that intentional? > > BR, > -R Yes Rob, the offset was wrong which i corrected in this patch. > >> }, >> }; >> >> @@ -272,10 +272,10 @@ >> sc7180_vig_sblk_0, 0, SSPP_TYPE_VIG, >> DPU_CLK_CTRL_VIG0), >> SSPP_BLK("sspp_8", SSPP_DMA0, 0x24000, DMA_SDM845_MASK, >> sdm845_dma_sblk_0, 1, SSPP_TYPE_DMA, >> DPU_CLK_CTRL_DMA0), >> - SSPP_BLK("sspp_9", SSPP_DMA1, 0x26000, DMA_SDM845_MASK, >> - sdm845_dma_sblk_1, 5, SSPP_TYPE_DMA, >> DPU_CLK_CTRL_DMA1), >> + SSPP_BLK("sspp_9", SSPP_DMA1, 0x26000, >> DMA_CURSOR_SDM845_MASK, >> + sdm845_dma_sblk_1, 5, SSPP_TYPE_DMA, >> DPU_CLK_CTRL_CURSOR0), >> SSPP_BLK("sspp_10", SSPP_DMA2, 0x28000, >> DMA_CURSOR_SDM845_MASK, >> - sdm845_dma_sblk_2, 9, SSPP_TYPE_DMA, >> DPU_CLK_CTRL_CURSOR0), >> + sdm845_dma_sblk_2, 9, SSPP_TYPE_DMA, >> DPU_CLK_CTRL_CURSOR1), >> }; >> >> /************************************************************* >> -- >> 1.9.1 >> > _______________________________________________ > Freedreno mailing list > Freedreno@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/freedreno
WARNING: multiple messages have this Message-ID (diff)
From: kalyan_t@codeaurora.org To: Rob Clark <robdclark@gmail.com> Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Krishna Manikandan <mkrishn@codeaurora.org>, Raviteja Tamatam <travitej@codeaurora.org>, linux-arm-msm <linux-arm-msm@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, Douglas Anderson <dianders@chromium.org>, Sean Paul <seanpaul@chromium.org>, "Kristian H. Kristensen" <hoegsberg@chromium.org>, Stephen Boyd <swboyd@chromium.org>, freedreno <freedreno@lists.freedesktop.org> Subject: Re: [Freedreno] [v1] drm/msm/dpu: enumerate second cursor pipe for external interface Date: Mon, 13 Jul 2020 15:48:41 +0530 [thread overview] Message-ID: <c10c0f70988d42037ccaccc6b5474942@codeaurora.org> (raw) In-Reply-To: <CAF6AEGtPDh7q6Hjophdyz+Pvi93-bK5WULGeSw9P4BWRw5SWxQ@mail.gmail.com> On 2020-07-10 22:19, Rob Clark wrote: > On Thu, Jun 25, 2020 at 5:46 AM Kalyan Thota <kalyan_t@codeaurora.org> > wrote: >> >> Setup an RGB HW pipe as cursor which can be used on >> secondary interface. >> >> For SC7180 2 HW pipes are enumerated as cursors >> 1 - primary interface >> 2 - secondary interface >> >> Signed-off-by: Kalyan Thota <kalyan_t@codeaurora.org> >> --- >> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 12 ++++++------ >> 1 file changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c >> b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c >> index 8f2357d..23061fd 100644 >> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c >> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c >> @@ -117,10 +117,10 @@ >> .reg_off = 0x2AC, .bit_off = 0}, >> .clk_ctrls[DPU_CLK_CTRL_DMA0] = { >> .reg_off = 0x2AC, .bit_off = 8}, >> - .clk_ctrls[DPU_CLK_CTRL_DMA1] = { >> - .reg_off = 0x2B4, .bit_off = 8}, >> .clk_ctrls[DPU_CLK_CTRL_CURSOR0] = { >> - .reg_off = 0x2BC, .bit_off = 8}, >> + .reg_off = 0x2B4, .bit_off = 8}, >> + .clk_ctrls[DPU_CLK_CTRL_CURSOR1] = { >> + .reg_off = 0x2C4, .bit_off = 8}, > > It looks like you shifted the register offset here from 0x2bc to > 0x2c4, was that intentional? > > BR, > -R Yes Rob, the offset was wrong which i corrected in this patch. > >> }, >> }; >> >> @@ -272,10 +272,10 @@ >> sc7180_vig_sblk_0, 0, SSPP_TYPE_VIG, >> DPU_CLK_CTRL_VIG0), >> SSPP_BLK("sspp_8", SSPP_DMA0, 0x24000, DMA_SDM845_MASK, >> sdm845_dma_sblk_0, 1, SSPP_TYPE_DMA, >> DPU_CLK_CTRL_DMA0), >> - SSPP_BLK("sspp_9", SSPP_DMA1, 0x26000, DMA_SDM845_MASK, >> - sdm845_dma_sblk_1, 5, SSPP_TYPE_DMA, >> DPU_CLK_CTRL_DMA1), >> + SSPP_BLK("sspp_9", SSPP_DMA1, 0x26000, >> DMA_CURSOR_SDM845_MASK, >> + sdm845_dma_sblk_1, 5, SSPP_TYPE_DMA, >> DPU_CLK_CTRL_CURSOR0), >> SSPP_BLK("sspp_10", SSPP_DMA2, 0x28000, >> DMA_CURSOR_SDM845_MASK, >> - sdm845_dma_sblk_2, 9, SSPP_TYPE_DMA, >> DPU_CLK_CTRL_CURSOR0), >> + sdm845_dma_sblk_2, 9, SSPP_TYPE_DMA, >> DPU_CLK_CTRL_CURSOR1), >> }; >> >> /************************************************************* >> -- >> 1.9.1 >> > _______________________________________________ > Freedreno mailing list > Freedreno@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/freedreno _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-07-13 10:18 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-25 12:45 [v1] drm/msm/dpu: enumerate second cursor pipe for external interface Kalyan Thota 2020-06-25 12:45 ` Kalyan Thota 2020-07-10 16:49 ` Rob Clark 2020-07-10 16:49 ` Rob Clark 2020-07-13 10:18 ` kalyan_t [this message] 2020-07-13 10:18 ` [Freedreno] " kalyan_t 2020-07-13 14:14 ` Rob Clark 2020-07-13 14:14 ` Rob Clark
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c10c0f70988d42037ccaccc6b5474942@codeaurora.org \ --to=kalyan_t@codeaurora.org \ --cc=devicetree@vger.kernel.org \ --cc=dianders@chromium.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=hoegsberg@chromium.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mkrishn@codeaurora.org \ --cc=nganji@codeaurora.org \ --cc=robdclark@gmail.com \ --cc=seanpaul@chromium.org \ --cc=swboyd@chromium.org \ --cc=travitej@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.