From: Jens Axboe <axboe@fb.com> To: Christoph Hellwig <hch@lst.de>, Keith Busch <keith.busch@intel.com>, "Sagi Grimberg" <sagi@grimberg.me> Cc: Max Gurtovoy <maxg@mellanox.com>, "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>, "linux-block@vger.kernel.org" <linux-block@vger.kernel.org> Subject: Re: [PATCH 01/13] block: move queues types to the block layer Date: Thu, 29 Nov 2018 19:50:09 +0000 [thread overview] Message-ID: <c20e4d66-0fc5-ab65-2805-c4b22012c1c5@fb.com> (raw) In-Reply-To: <20181129191310.9795-2-hch@lst.de> On 11/29/18 12:12 PM, Christoph Hellwig wrote: > Having another indirect all in the fast path doesn't really help > in our post-spectre world. Also having too many queue type is just > going to create confusion, so I'd rather manage them centrally. > > Note that the queue type naming and ordering changes a bit - the > first index now is the defauly queue for everything not explicitly ^^^^^^^ default > marked, the optional ones are read and poll queues. Looks fine to me, was hoping NOT to bring this into the core, but I guess it might be more manageable there in the long run. And it's hard to argue with getting rid of the flags_to_type indirect. Side not, should probably make the sysfs 'type' attribute a string at this point. -- Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: axboe@fb.com (Jens Axboe) Subject: [PATCH 01/13] block: move queues types to the block layer Date: Thu, 29 Nov 2018 19:50:09 +0000 [thread overview] Message-ID: <c20e4d66-0fc5-ab65-2805-c4b22012c1c5@fb.com> (raw) In-Reply-To: <20181129191310.9795-2-hch@lst.de> On 11/29/18 12:12 PM, Christoph Hellwig wrote: > Having another indirect all in the fast path doesn't really help > in our post-spectre world. Also having too many queue type is just > going to create confusion, so I'd rather manage them centrally. > > Note that the queue type naming and ordering changes a bit - the > first index now is the defauly queue for everything not explicitly ^^^^^^^ default > marked, the optional ones are read and poll queues. Looks fine to me, was hoping NOT to bring this into the core, but I guess it might be more manageable there in the long run. And it's hard to argue with getting rid of the flags_to_type indirect. Side not, should probably make the sysfs 'type' attribute a string at this point. -- Jens Axboe
next prev parent reply other threads:[~2018-11-29 19:50 UTC|newest] Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-29 19:12 block and nvme polling improvements V2 Christoph Hellwig 2018-11-29 19:12 ` Christoph Hellwig 2018-11-29 19:12 ` [PATCH 01/13] block: move queues types to the block layer Christoph Hellwig 2018-11-29 19:12 ` Christoph Hellwig 2018-11-29 19:50 ` Jens Axboe [this message] 2018-11-29 19:50 ` Jens Axboe 2018-11-30 7:56 ` Christoph Hellwig 2018-11-30 7:56 ` Christoph Hellwig 2018-11-30 15:20 ` Jens Axboe 2018-11-30 15:20 ` Jens Axboe 2018-11-30 15:21 ` Christoph Hellwig 2018-11-30 15:21 ` Christoph Hellwig 2018-11-29 20:19 ` Keith Busch 2018-11-29 20:19 ` Keith Busch 2018-11-29 20:25 ` Jens Axboe 2018-11-29 20:25 ` Jens Axboe 2018-11-30 8:00 ` Christoph Hellwig 2018-11-30 8:00 ` Christoph Hellwig 2018-11-30 14:40 ` Keith Busch 2018-11-30 14:40 ` Keith Busch 2018-11-30 15:20 ` Jens Axboe 2018-11-30 15:20 ` Jens Axboe 2018-11-29 19:12 ` [PATCH 02/13] nvme-pci: use atomic bitops to mark a queue enabled Christoph Hellwig 2018-11-29 19:12 ` Christoph Hellwig 2018-11-29 20:19 ` Keith Busch 2018-11-29 20:19 ` Keith Busch 2018-11-29 19:13 ` [PATCH 03/13] nvme-pci: cleanup SQ allocation a bit Christoph Hellwig 2018-11-29 19:13 ` Christoph Hellwig 2018-11-29 20:22 ` Keith Busch 2018-11-29 20:22 ` Keith Busch 2018-11-29 19:13 ` [PATCH 04/13] nvme-pci: only allow polling with separate poll queues Christoph Hellwig 2018-11-29 19:13 ` Christoph Hellwig 2018-11-29 19:13 ` [PATCH 05/13] nvme-pci: consolidate code for polling non-dedicated queues Christoph Hellwig 2018-11-29 19:13 ` Christoph Hellwig 2018-11-29 19:13 ` [PATCH 06/13] nvme-pci: refactor nvme_disable_io_queues Christoph Hellwig 2018-11-29 19:13 ` Christoph Hellwig 2018-11-29 20:37 ` Keith Busch 2018-11-29 20:37 ` Keith Busch 2018-11-29 19:13 ` [PATCH 07/13] nvme-pci: don't poll from irq context when deleting queues Christoph Hellwig 2018-11-29 19:13 ` Christoph Hellwig 2018-11-29 20:36 ` Keith Busch 2018-11-29 20:36 ` Keith Busch 2018-11-30 8:08 ` Christoph Hellwig 2018-11-30 8:08 ` Christoph Hellwig 2018-11-30 14:45 ` Keith Busch 2018-11-30 14:45 ` Keith Busch 2018-11-29 19:13 ` [PATCH 08/13] nvme-pci: remove the CQ lock for interrupt driven queues Christoph Hellwig 2018-11-29 19:13 ` Christoph Hellwig 2018-11-29 21:08 ` Keith Busch 2018-11-29 21:08 ` Keith Busch 2018-11-30 8:16 ` Christoph Hellwig 2018-11-30 8:16 ` Christoph Hellwig 2018-11-29 19:13 ` [PATCH 09/13] nvme-rdma: remove I/O polling support Christoph Hellwig 2018-11-29 19:13 ` Christoph Hellwig 2018-11-29 19:13 ` [PATCH 10/13] nvme-mpath: " Christoph Hellwig 2018-11-29 19:13 ` Christoph Hellwig 2018-11-29 19:13 ` [PATCH 11/13] block: remove ->poll_fn Christoph Hellwig 2018-11-29 19:13 ` Christoph Hellwig 2018-11-29 19:13 ` [PATCH 12/13] block: only allow polling if a poll queue_map exists Christoph Hellwig 2018-11-29 19:13 ` Christoph Hellwig 2018-11-29 19:13 ` [PATCH 13/13] block: enable polling by default if a poll map is initalized Christoph Hellwig 2018-11-29 19:13 ` Christoph Hellwig -- strict thread matches above, loose matches on Subject: below -- 2018-12-02 16:46 block and nvme polling improvements V3 Christoph Hellwig 2018-12-02 16:46 ` [PATCH 01/13] block: move queues types to the block layer Christoph Hellwig 2018-12-02 16:46 ` Christoph Hellwig 2018-12-04 0:49 ` Sagi Grimberg 2018-12-04 0:49 ` Sagi Grimberg 2018-12-04 15:00 ` Christoph Hellwig 2018-12-04 15:00 ` Christoph Hellwig 2018-12-04 17:08 ` Sagi Grimberg 2018-12-04 17:08 ` Sagi Grimberg 2018-11-21 16:23 block and nvme polling improvements Christoph Hellwig 2018-11-21 16:23 ` [PATCH 01/13] block: move queues types to the block layer Christoph Hellwig 2018-11-21 16:23 ` Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c20e4d66-0fc5-ab65-2805-c4b22012c1c5@fb.com \ --to=axboe@fb.com \ --cc=hch@lst.de \ --cc=keith.busch@intel.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=maxg@mellanox.com \ --cc=sagi@grimberg.me \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.