From: Chao Leng <lengchao@huawei.com>
To: Christoph Hellwig <hch@lst.de>
Cc: <linux-nvme@lists.infradead.org>, <kbusch@kernel.org>,
<axboe@fb.com>, <sagi@grimberg.me>, <linux-block@vger.kernel.org>,
<axboe@kernel.dk>
Subject: Re: [PATCH v3 2/5] nvme-core: introduce complete failed request
Date: Fri, 22 Jan 2021 09:46:41 +0800 [thread overview]
Message-ID: <c833e26b-623e-47f5-2493-13cb83014905@huawei.com> (raw)
In-Reply-To: <20210121084150.GB25963@lst.de>
On 2021/1/21 16:41, Christoph Hellwig wrote:
>> +static inline void nvme_complete_failed_req(struct request *req)
>
> I think the name is too generic, and the function also needs a little
> comment, especially as it forces a specific error code.
Ok, thank you for your suggestion. Use error status as a parameter may
be a better choice.
>
>> +{
>> + nvme_req(req)->status = NVME_SC_HOST_PATH_ERROR;
>> + blk_mq_set_request_complete(req);
>> + nvme_complete_rq(req);
>> +}
>
> Also no need to mark this as an inline function.
Yes, export the function is ok.
> .
>
WARNING: multiple messages have this Message-ID (diff)
From: Chao Leng <lengchao@huawei.com>
To: Christoph Hellwig <hch@lst.de>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org, sagi@grimberg.me,
linux-nvme@lists.infradead.org, axboe@fb.com, kbusch@kernel.org
Subject: Re: [PATCH v3 2/5] nvme-core: introduce complete failed request
Date: Fri, 22 Jan 2021 09:46:41 +0800 [thread overview]
Message-ID: <c833e26b-623e-47f5-2493-13cb83014905@huawei.com> (raw)
In-Reply-To: <20210121084150.GB25963@lst.de>
On 2021/1/21 16:41, Christoph Hellwig wrote:
>> +static inline void nvme_complete_failed_req(struct request *req)
>
> I think the name is too generic, and the function also needs a little
> comment, especially as it forces a specific error code.
Ok, thank you for your suggestion. Use error status as a parameter may
be a better choice.
>
>> +{
>> + nvme_req(req)->status = NVME_SC_HOST_PATH_ERROR;
>> + blk_mq_set_request_complete(req);
>> + nvme_complete_rq(req);
>> +}
>
> Also no need to mark this as an inline function.
Yes, export the function is ok.
> .
>
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-01-22 1:47 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 7:03 [PATCH v3 0/5] avoid double request completion and IO error Chao Leng
2021-01-21 7:03 ` Chao Leng
2021-01-21 7:03 ` [PATCH v3 1/5] blk-mq: introduce blk_mq_set_request_complete Chao Leng
2021-01-21 7:03 ` Chao Leng
2021-01-21 8:40 ` Christoph Hellwig
2021-01-21 8:40 ` Christoph Hellwig
2021-01-22 1:46 ` Chao Leng
2021-01-22 1:46 ` Chao Leng
2021-01-21 7:03 ` [PATCH v3 2/5] nvme-core: introduce complete failed request Chao Leng
2021-01-21 7:03 ` Chao Leng
2021-01-21 8:41 ` Christoph Hellwig
2021-01-21 8:41 ` Christoph Hellwig
2021-01-22 1:46 ` Chao Leng [this message]
2021-01-22 1:46 ` Chao Leng
2021-01-21 7:03 ` [PATCH v3 3/5] nvme-fabrics: avoid double request completion for nvmf_fail_nonready_command Chao Leng
2021-01-21 7:03 ` Chao Leng
2021-01-21 8:58 ` Hannes Reinecke
2021-01-21 8:58 ` Hannes Reinecke
2021-01-21 9:00 ` Christoph Hellwig
2021-01-21 9:00 ` Christoph Hellwig
2021-01-21 9:27 ` Hannes Reinecke
2021-01-21 9:27 ` Hannes Reinecke
2021-01-22 1:50 ` Chao Leng
2021-01-22 1:50 ` Chao Leng
2021-01-22 1:48 ` Chao Leng
2021-01-22 1:48 ` Chao Leng
2021-01-21 7:03 ` [PATCH v3 4/5] nvme-rdma: avoid IO error for nvme native multipath Chao Leng
2021-01-21 7:03 ` Chao Leng
2021-01-21 7:03 ` [PATCH v3 5/5] nvme-fc: " Chao Leng
2021-01-21 7:03 ` Chao Leng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c833e26b-623e-47f5-2493-13cb83014905@huawei.com \
--to=lengchao@huawei.com \
--cc=axboe@fb.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.