From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: luca.ceresoli@bootlin.com, alsa-devel@alsa-project.org,
linux-rockchip@lists.infradead.org
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Johan Jonker <jbx6244@gmail.com>,
Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [PATCH 4/8] arm64: dts: rockchip: add the internal audio codec
Date: Thu, 8 Sep 2022 13:53:58 +0200 [thread overview]
Message-ID: <c9adeeeb-8edd-f912-1aab-b19508187eef@linaro.org> (raw)
In-Reply-To: <20220907142124.2532620-5-luca.ceresoli@bootlin.com>
On 07/09/2022 16:21, luca.ceresoli@bootlin.com wrote:
> From: Luca Ceresoli <luca.ceresoli@bootlin.com>
>
> The RK3308 has a built-in audio codec that connects internally to i2s_8ch_2
> or i2s_8ch_3.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3308.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3308.dtsi b/arch/arm64/boot/dts/rockchip/rk3308.dtsi
> index 093b70563b23..221cde49dc98 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3308.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3308.dtsi
> @@ -808,6 +808,20 @@ cru: clock-controller@ff500000 {
> assigned-clock-rates = <32768>;
> };
>
> + acodec: acodec@ff560000 {
Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: luca.ceresoli@bootlin.com, alsa-devel@alsa-project.org,
linux-rockchip@lists.infradead.org
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Johan Jonker <jbx6244@gmail.com>,
Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [PATCH 4/8] arm64: dts: rockchip: add the internal audio codec
Date: Thu, 8 Sep 2022 13:53:58 +0200 [thread overview]
Message-ID: <c9adeeeb-8edd-f912-1aab-b19508187eef@linaro.org> (raw)
In-Reply-To: <20220907142124.2532620-5-luca.ceresoli@bootlin.com>
On 07/09/2022 16:21, luca.ceresoli@bootlin.com wrote:
> From: Luca Ceresoli <luca.ceresoli@bootlin.com>
>
> The RK3308 has a built-in audio codec that connects internally to i2s_8ch_2
> or i2s_8ch_3.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3308.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3308.dtsi b/arch/arm64/boot/dts/rockchip/rk3308.dtsi
> index 093b70563b23..221cde49dc98 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3308.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3308.dtsi
> @@ -808,6 +808,20 @@ cru: clock-controller@ff500000 {
> assigned-clock-rates = <32768>;
> };
>
> + acodec: acodec@ff560000 {
Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: luca.ceresoli@bootlin.com, alsa-devel@alsa-project.org,
linux-rockchip@lists.infradead.org
Cc: devicetree@vger.kernel.org, Heiko Stuebner <heiko@sntech.de>,
Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
Chris Morgan <macromorgan@hotmail.com>,
linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Johan Jonker <jbx6244@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/8] arm64: dts: rockchip: add the internal audio codec
Date: Thu, 8 Sep 2022 13:53:58 +0200 [thread overview]
Message-ID: <c9adeeeb-8edd-f912-1aab-b19508187eef@linaro.org> (raw)
In-Reply-To: <20220907142124.2532620-5-luca.ceresoli@bootlin.com>
On 07/09/2022 16:21, luca.ceresoli@bootlin.com wrote:
> From: Luca Ceresoli <luca.ceresoli@bootlin.com>
>
> The RK3308 has a built-in audio codec that connects internally to i2s_8ch_2
> or i2s_8ch_3.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3308.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3308.dtsi b/arch/arm64/boot/dts/rockchip/rk3308.dtsi
> index 093b70563b23..221cde49dc98 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3308.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3308.dtsi
> @@ -808,6 +808,20 @@ cru: clock-controller@ff500000 {
> assigned-clock-rates = <32768>;
> };
>
> + acodec: acodec@ff560000 {
Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: luca.ceresoli@bootlin.com, alsa-devel@alsa-project.org,
linux-rockchip@lists.infradead.org
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Johan Jonker <jbx6244@gmail.com>,
Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [PATCH 4/8] arm64: dts: rockchip: add the internal audio codec
Date: Thu, 8 Sep 2022 13:53:58 +0200 [thread overview]
Message-ID: <c9adeeeb-8edd-f912-1aab-b19508187eef@linaro.org> (raw)
In-Reply-To: <20220907142124.2532620-5-luca.ceresoli@bootlin.com>
On 07/09/2022 16:21, luca.ceresoli@bootlin.com wrote:
> From: Luca Ceresoli <luca.ceresoli@bootlin.com>
>
> The RK3308 has a built-in audio codec that connects internally to i2s_8ch_2
> or i2s_8ch_3.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3308.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3308.dtsi b/arch/arm64/boot/dts/rockchip/rk3308.dtsi
> index 093b70563b23..221cde49dc98 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3308.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3308.dtsi
> @@ -808,6 +808,20 @@ cru: clock-controller@ff500000 {
> assigned-clock-rates = <32768>;
> };
>
> + acodec: acodec@ff560000 {
Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-08 11:54 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 14:21 [PATCH 0/8] Add support for the internal RK3308 audio codec luca.ceresoli
2022-09-07 14:21 ` luca.ceresoli
2022-09-07 14:21 ` luca.ceresoli
2022-09-07 14:21 ` luca.ceresoli
2022-09-07 14:21 ` [PATCH 1/8] ASoC: rockchip: rk3308: add internal audio codec bindings luca.ceresoli
2022-09-07 14:21 ` luca.ceresoli
2022-09-07 14:21 ` luca.ceresoli
2022-09-07 14:21 ` luca.ceresoli
2022-09-08 11:53 ` Krzysztof Kozlowski
2022-09-08 11:53 ` Krzysztof Kozlowski
2022-09-08 11:53 ` Krzysztof Kozlowski
2022-09-08 11:53 ` Krzysztof Kozlowski
2022-09-07 14:21 ` [PATCH 2/8] ASoC: rockchip: rk3308: add audio card bindings luca.ceresoli
2022-09-07 14:21 ` luca.ceresoli
2022-09-07 14:21 ` luca.ceresoli
2022-09-07 14:21 ` luca.ceresoli
2022-09-08 11:49 ` Krzysztof Kozlowski
2022-09-08 11:49 ` Krzysztof Kozlowski
2022-09-08 11:49 ` Krzysztof Kozlowski
2022-09-08 11:49 ` Krzysztof Kozlowski
2022-09-08 15:20 ` Luca Ceresoli
2022-09-08 15:20 ` Luca Ceresoli
2022-09-08 15:20 ` Luca Ceresoli
2022-09-08 15:20 ` Luca Ceresoli
2022-09-08 15:28 ` Krzysztof Kozlowski
2022-09-08 15:28 ` Krzysztof Kozlowski
2022-09-08 15:28 ` Krzysztof Kozlowski
2022-09-08 15:28 ` Krzysztof Kozlowski
2022-09-07 14:21 ` [PATCH 3/8] arm64: dts: rockchip: add i2s_8ch_2 and i2s_8ch_3 luca.ceresoli
2022-09-07 14:21 ` luca.ceresoli
2022-09-07 14:21 ` luca.ceresoli
2022-09-07 14:21 ` luca.ceresoli
2022-09-07 14:21 ` [PATCH 4/8] arm64: dts: rockchip: add the internal audio codec luca.ceresoli
2022-09-07 14:21 ` luca.ceresoli
2022-09-07 14:21 ` luca.ceresoli
2022-09-07 14:21 ` luca.ceresoli
2022-09-08 11:53 ` Krzysztof Kozlowski [this message]
2022-09-08 11:53 ` Krzysztof Kozlowski
2022-09-08 11:53 ` Krzysztof Kozlowski
2022-09-08 11:53 ` Krzysztof Kozlowski
2022-09-07 14:21 ` [PATCH 5/8] ASoC: rockchip: i2s-tdm: Fix clk_id usage in .set_sysclk() luca.ceresoli
2022-09-07 14:21 ` luca.ceresoli
2022-09-07 14:21 ` luca.ceresoli
2022-09-07 14:21 ` luca.ceresoli
2022-09-08 16:36 ` Mark Brown
2022-09-08 16:36 ` Mark Brown
2022-09-08 16:36 ` Mark Brown
2022-09-08 16:36 ` Mark Brown
2022-09-07 14:21 ` [PATCH 6/8] ASoC: audio-graph: let dai_link->init be overridable luca.ceresoli
2022-09-07 14:21 ` luca.ceresoli
2022-09-07 14:21 ` luca.ceresoli
2022-09-07 14:21 ` luca.ceresoli
2022-09-07 14:21 ` [PATCH 7/8] ASoC: codecs: Add RK3308 internal audio codec driver luca.ceresoli
2022-09-07 14:21 ` luca.ceresoli
2022-09-07 14:21 ` luca.ceresoli
2022-09-07 14:21 ` luca.ceresoli
2022-09-07 17:40 ` kernel test robot
2022-09-07 17:40 ` kernel test robot
2022-09-07 17:40 ` kernel test robot
2022-09-07 19:53 ` kernel test robot
2022-09-07 19:53 ` kernel test robot
2022-09-07 19:53 ` kernel test robot
2022-09-07 19:53 ` kernel test robot
2022-09-08 13:24 ` kernel test robot
2022-09-08 13:35 ` Dan Carpenter
2022-09-08 13:35 ` Dan Carpenter
2022-09-08 13:35 ` Dan Carpenter
2022-09-08 15:33 ` Luca Ceresoli
2022-09-08 15:33 ` Luca Ceresoli
2022-09-08 15:33 ` Luca Ceresoli
2022-09-08 15:33 ` Luca Ceresoli
2022-09-08 15:33 ` Luca Ceresoli
2022-09-08 16:27 ` Mark Brown
2022-09-08 16:27 ` Mark Brown
2022-09-08 16:27 ` Mark Brown
2022-09-08 16:27 ` Mark Brown
2022-09-09 17:11 ` Luca Ceresoli
2022-09-09 17:11 ` Luca Ceresoli
2022-09-09 17:11 ` Luca Ceresoli
2022-09-09 17:11 ` Luca Ceresoli
2022-09-09 23:15 ` kernel test robot
2022-09-09 23:15 ` kernel test robot
2022-09-09 23:15 ` kernel test robot
2022-09-09 23:15 ` kernel test robot
2022-09-07 14:21 ` [PATCH 8/8] ASoC: rockchip: add new RK3308 sound card luca.ceresoli
2022-09-07 14:21 ` luca.ceresoli
2022-09-07 14:21 ` luca.ceresoli
2022-09-07 14:21 ` luca.ceresoli
2022-09-07 15:41 ` [PATCH 0/8] Add support for the internal RK3308 audio codec Mark Brown
2022-09-07 15:41 ` Mark Brown
2022-09-07 15:41 ` Mark Brown
2022-09-07 15:41 ` Mark Brown
2022-09-07 17:15 ` Luca Ceresoli
2022-09-07 17:15 ` Luca Ceresoli
2022-09-07 17:15 ` Luca Ceresoli
2022-09-07 17:15 ` Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9adeeeb-8edd-f912-1aab-b19508187eef@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frattaroli.nicolas@gmail.com \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=luca.ceresoli@bootlin.com \
--cc=macromorgan@hotmail.com \
--cc=p.zabel@pengutronix.de \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.