Re: [PATCH v2 2/4] dt-bindings: arm: amlogic: add fbx8am binding

From: Marc Gonzalez <mgonzalez@freebox.fr>
To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	AML <linux-amlogic@lists.infradead.org>,
	DT <devicetree@vger.kernel.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Pierre-Hugues Husson <phhusson@freebox.fr>
Subject: Re: [PATCH v2 2/4] dt-bindings: arm: amlogic: add fbx8am binding
Date: Tue, 13 Feb 2024 13:35:32 +0100	[thread overview]
Message-ID: <cda7afdb-f75f-4376-87b8-882297f2657e@freebox.fr> (raw)
In-Reply-To: <959b8135-a687-4781-993c-5fa5ba3b9c8e@linaro.org>

On 13/02/2024 09:41, Krzysztof Kozlowski wrote:

> On 12/02/2024 18:50, Marc Gonzalez wrote:
>
>> Add binding for the Amlogic Meson G12A-based Freebox Pop (fbx8am).
>>
>> Signed-off-by: Marc Gonzalez <mgonzalez@freebox.fr>
>> ---
>>   Documentation/devicetree/bindings/arm/amlogic.yaml | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
>> index caab7ceeda45a..fce12e44c00af 100644
>> --- a/Documentation/devicetree/bindings/arm/amlogic.yaml
>> +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
>> @@ -148,6 +148,7 @@ properties:
>>                 - amlogic,u200
>>                 - radxa,zero
>>                 - seirobotics,sei510
>> +              - freebox,fbx8am
> 
> It does not look like you tested the bindings, at least after quick look.
> Please run `make dt_binding_check` (see
> Documentation/devicetree/bindings/writing-schema.rst for instructions).
> Maybe you need to update your dtschema and yamllint.

I ran 'make dtbs' and 'make dtbs_check', and booted a board with the generated DTB.

I'm using yamllint 1.33.0 and dt-validate 2023.11

$ make clean && make -j16 dt_binding_check DT_SCHEMA_FILES=arm/amlogic.yaml
  CLEAN   Documentation/devicetree/bindings
  HOSTCC  scripts/basic/fixdep
  HOSTCC  scripts/dtc/dtc.o
  HOSTCC  scripts/dtc/flattree.o
  HOSTCC  scripts/dtc/fstree.o
  HOSTCC  scripts/dtc/data.o
  HOSTCC  scripts/dtc/livetree.o
  HOSTCC  scripts/dtc/treesource.o
  HOSTCC  scripts/dtc/srcpos.o
  HOSTCC  scripts/dtc/checks.o
  HOSTCC  scripts/dtc/util.o
  LEX     scripts/dtc/dtc-lexer.lex.c
  YACC    scripts/dtc/dtc-parser.tab.[ch]
  HOSTCC  scripts/dtc/libfdt/fdt.o
  HOSTCC  scripts/dtc/libfdt/fdt_ro.o
  HOSTCC  scripts/dtc/libfdt/fdt_wip.o
  HOSTCC  scripts/dtc/libfdt/fdt_sw.o
  HOSTCC  scripts/dtc/libfdt/fdt_rw.o
  HOSTCC  scripts/dtc/libfdt/fdt_strerror.o
  HOSTCC  scripts/dtc/libfdt/fdt_empty_tree.o
  HOSTCC  scripts/dtc/libfdt/fdt_addresses.o
  HOSTCC  scripts/dtc/libfdt/fdt_overlay.o
  HOSTCC  scripts/dtc/fdtoverlay.o
  HOSTCC  scripts/dtc/dtc-lexer.lex.o
  HOSTCC  scripts/dtc/dtc-parser.tab.o
  HOSTLD  scripts/dtc/fdtoverlay
  HOSTLD  scripts/dtc/dtc
  LINT    Documentation/devicetree/bindings
  DTEX    Documentation/devicetree/bindings/arm/amlogic.example.dts
  CHKDT   Documentation/devicetree/bindings/processed-schema.json
  SCHEMA  Documentation/devicetree/bindings/processed-schema.json
/home/mgonzalez/linux/Documentation/devicetree/bindings/net/snps,dwmac.yaml: mac-mode: missing type definition
  DTC_CHK Documentation/devicetree/bindings/arm/amlogic.example.dtb

Looks like my MUA mangled the patch.
Sorry about that, will resubmit.

Regards

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic