Re: [PATCH v2 3/4] arm64: dts: amlogic: add fbx8am board

From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Marc Gonzalez <mgonzalez@freebox.fr>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	AML <linux-amlogic@lists.infradead.org>,
	DT <devicetree@vger.kernel.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Pierre-Hugues Husson <phhusson@freebox.fr>
Subject: Re: [PATCH v2 3/4] arm64: dts: amlogic: add fbx8am board
Date: Tue, 13 Feb 2024 15:23:39 +0100	[thread overview]
Message-ID: <ea2d11e2-3d6f-4dac-aa96-b18b174af00c@linaro.org> (raw)
In-Reply-To: <b6a02f8b-8782-48bd-8916-36bbd996d4c3@freebox.fr>

On 13/02/2024 11:49, Marc Gonzalez wrote:
> On 13/02/2024 09:42, Krzysztof Kozlowski wrote:
> 
>> On 12/02/2024 18:51, Marc Gonzalez wrote:
>>
>>> The fbx8am boards are based on the Amlogic Meson G12A S905X2 SoC,
>>> and the SEI510 board design.
>>
>> ...
>>
>>> +	ao_5v: regulator-ao_5v {
>>
>> No underscores in node names.
>>
>> Didn't you get such comment before?
> 
> For the record, this submission is, mostly, a copy of meson-g12a-sei510.dts
> 
> Thus, I did not consider diverging from meson-g12a-sei510.dts
> 
> $ git grep -i ' [_a-z0-9-]*_[_a-z0-9-]* {' arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts | wc -l

I'll fix meson stuff.

> 6
> 
> $ git grep -i ' [_a-z0-9-]*_[_a-z0-9-]* {' arch/arm64/boot/dts/amlogic/meson-g12a-fbx8am.dts
> arch/arm64/boot/dts/amlogic/meson-g12a-fbx8am.dts:      ao_5v: regulator-ao_5v {
> arch/arm64/boot/dts/amlogic/meson-g12a-fbx8am.dts:      dc_in: regulator-dc_in {
> arch/arm64/boot/dts/amlogic/meson-g12a-fbx8am.dts:      emmc_1v8: regulator-emmc_1v8 {
> arch/arm64/boot/dts/amlogic/meson-g12a-fbx8am.dts:      vddao_3v3: regulator-vddao_3v3 {
> arch/arm64/boot/dts/amlogic/meson-g12a-fbx8am.dts:      vddao_3v3_t: regultor-vddao_3v3_t {
> arch/arm64/boot/dts/amlogic/meson-g12a-fbx8am.dts:      vddio_ao1v8: regulator-vddio_ao1v8 {
> 
> 
> IIUC, you're saying it is preferable to fix the node names in new trees,
> even if it means diverging? (Using dashes instead of underscores?)

IMHO, yes.

Best regards,
Krzysztof