* [Cocci] [PATCH v5] coccicheck: Support search for SmPL scripts within selected directory hierarchy
@ 2019-10-30 2:54 zhongshiqi
2019-10-30 14:00 ` Markus Elfring
0 siblings, 1 reply; 3+ messages in thread
From: zhongshiqi @ 2019-10-30 2:54 UTC (permalink / raw)
To: Julia.Lawall
Cc: wang.yi59, michal.lkml, nicolas.palix, linux-kernel, xue.zhihong,
cheng.shengyu, zhongshiqi, cocci
*Allow defining the environment variable “COCCI” as a directory to search
SmPL scripts.
*Start a corresponding file determination if it contains an acceptable
path.
Signed-off-by: zhongshiqi <zhong.shiqi@zte.com.cn>
---
Changes in v5:
1:rewrite change description as an enumeration
Changes in v4:
1:rewrite change description in another wording
Changes in v3:
1:rewrite change description
2:fix patch subject
3:modify commit log
Changes in v2:
1.fix patch subject according to the reply by Markus
<Markus.Elfring@web.de>
2.change description in “imperative mood”
scripts/coccicheck | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/scripts/coccicheck b/scripts/coccicheck
index e04d328..a1c4197 100755
--- a/scripts/coccicheck
+++ b/scripts/coccicheck
@@ -257,6 +257,10 @@ if [ "$COCCI" = "" ] ; then
for f in `find $srctree/scripts/coccinelle/ -name '*.cocci' -type f | sort`; do
coccinelle $f
done
+elif [ -d "$COCCI" ] ; then
+ for f in `find $COCCI/ -name '*.cocci' -type f | sort`; do
+ coccinelle $f
+ done
else
coccinelle $COCCI
fi
--
2.9.5
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Cocci] [PATCH v5] coccicheck: Support search for SmPL scripts within selected directory hierarchy
2019-10-30 2:54 [Cocci] [PATCH v5] coccicheck: Support search for SmPL scripts within selected directory hierarchy zhongshiqi
@ 2019-10-30 14:00 ` Markus Elfring
2019-11-01 2:25 ` [Cocci] [PATCH v5] coccicheck: Support search for SmPL scripts withinselected " zhong.shiqi
0 siblings, 1 reply; 3+ messages in thread
From: Markus Elfring @ 2019-10-30 14:00 UTC (permalink / raw)
To: Zhong Shiqi, cocci
Cc: Yi Wang, Michal Marek, Nicolas Palix, kernel-janitors,
linux-kernel, Xue Zhihong, Cheng Shengyu
I got the impression that you are struggling with difficulties (for unknown reasons)
around adding space characters at some places.
How would you like to improve this situation?
> *Allow defining the environment variable “COCCI” as a directory to search
> SmPL scripts.
>
> *Start a corresponding file determination if it contains an acceptable
> path.
* Allow defining the environment variable “COCCI” as a directory
to search SmPL scripts.
* Start a corresponding file determination if it contains
an acceptable path.
Would you like to update the provided software documentation together with
the small extension of this bash script?
Update candidates:
* https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/dev-tools/coccinelle.rst?id=23fdb198ae81f47a574296dab5167c5e136a02ba#n189
* https://bottest.wiki.kernel.org/coccicheck#controlling_which_files_are_processed_by_coccinelle
> ---
‣ Would you find the patch change log sufficient without the information
“Changes in”?
‣ I find the specification “1:” unnecessary before a single description item.
Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Cocci] [PATCH v5] coccicheck: Support search for SmPL scripts withinselected directory hierarchy
2019-10-30 14:00 ` Markus Elfring
@ 2019-11-01 2:25 ` zhong.shiqi
0 siblings, 0 replies; 3+ messages in thread
From: zhong.shiqi @ 2019-11-01 2:25 UTC (permalink / raw)
To: Markus.Elfring
Cc: wang.yi59, michal.lkml, nicolas.palix, kernel-janitors,
linux-kernel, xue.zhihong, cheng.shengyu, cocci
[-- Attachment #1.1: Type: text/plain, Size: 1376 bytes --]
> I got the impression that you are struggling with difficulties (for unknown reasons)
> around adding space characters at some places.
> How would you like to improve this situation?
Thanks for your concern,but i haven't struggled with anything.I think i'm used to
adding space characters.
> > *Allow defining the environment variable “COCCI” as a directory to search
> > SmPL scripts.
> >
> > *Start a corresponding file determination if it contains an acceptable
> > path.
>
> * Allow defining the environment variable “COCCI” as a directory
> to search SmPL scripts.
>
> * Start a corresponding file determination if it contains
> an acceptable path.
>
>
> Would you like to update the provided software documentation together with
> the small extension of this bash script?
>
> Update candidates:
> * https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/dev-tools/coccinelle.rst?id=23fdb198ae81f47a574296dab5167c5e136a02ba#n189
>
> * https://bottest.wiki.kernel.org/coccicheck#controlling_which_files_are_processed_by_coccinelle
>
>
> > ---
>
> ‣ Would you find the patch change log sufficient without the information
> “Changes in”?
>
> ‣ I find the specification “1:” unnecessary before a single description item.
>
> Regards,
> Markus
OK,i am understand. You are rigorous.
thanks,
Zhong.shiqi
[-- Attachment #2: Type: text/plain, Size: 136 bytes --]
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-01 2:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-30 2:54 [Cocci] [PATCH v5] coccicheck: Support search for SmPL scripts within selected directory hierarchy zhongshiqi
2019-10-30 14:00 ` Markus Elfring
2019-11-01 2:25 ` [Cocci] [PATCH v5] coccicheck: Support search for SmPL scripts withinselected " zhong.shiqi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).