[cocci] [PATCH] dev-tools: fix one invalid url

[cocci] [PATCH] dev-tools: fix one invalid url

[Dongliang Mu]

From: Dongliang Mu <mudongliangabcd@gmail.com>

Fix the invalid url about Semantic Patch Language

Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
---
 Documentation/dev-tools/coccinelle.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/dev-tools/coccinelle.rst b/Documentation/dev-tools/coccinelle.rst
index 9c454de5a7f7..d9976069ed12 100644
--- a/Documentation/dev-tools/coccinelle.rst
+++ b/Documentation/dev-tools/coccinelle.rst
@@ -66,7 +66,7 @@ The wiki documentation always refers to the linux-next version of the script.
 
 For Semantic Patch Language(SmPL) grammar documentation refer to:
 
-http://coccinelle.lip6.fr/documentation.php
+https://coccinelle.gitlabpages.inria.fr/website/docs/main_grammar.html
 
 Using Coccinelle on the Linux kernel
 ------------------------------------
-- 
2.25.1

Re: [cocci] [PATCH] dev-tools: fix one invalid url

[Bagas Sanjaya]

On Mon, Jun 13, 2022 at 03:12:42PM +0800, Dongliang Mu wrote:
> From: Dongliang Mu <mudongliangabcd@gmail.com>
> 
> Fix the invalid url about Semantic Patch Language
> 

I think what this patch doing is to point SPL reference URL from old
Coccinelle documentation (doc root) to actual SPL doc entry on new
Coccinelle page, right? If so, "fix invalid URL" may not be right patch
description and title.

-- 
An old man doll... just what I always wanted! - Clara

Re: [cocci] [PATCH] dev-tools: fix one invalid url

[Julia Lawall]

On Mon, 13 Jun 2022, Bagas Sanjaya wrote:

> On Mon, Jun 13, 2022 at 03:12:42PM +0800, Dongliang Mu wrote:
> > From: Dongliang Mu <mudongliangabcd@gmail.com>
> >
> > Fix the invalid url about Semantic Patch Language
> >
>
> I think what this patch doing is to point SPL reference URL from old
> Coccinelle documentation (doc root) to actual SPL doc entry on new
> Coccinelle page, right? If so, "fix invalid URL" may not be right patch
> description and title.

Agreed, thanks for the suggestion.

julia

Re: [cocci] [PATCH] dev-tools: fix one invalid url

[Dongliang Mu]

On Mon, Jun 13, 2022 at 6:12 PM Julia Lawall <julia.lawall@inria.fr> wrote:
>
>
>
> On Mon, 13 Jun 2022, Bagas Sanjaya wrote:
>
> > On Mon, Jun 13, 2022 at 03:12:42PM +0800, Dongliang Mu wrote:
> > > From: Dongliang Mu <mudongliangabcd@gmail.com>
> > >
> > > Fix the invalid url about Semantic Patch Language
> > >
> >
> > I think what this patch doing is to point SPL reference URL from old
> > Coccinelle documentation (doc root) to actual SPL doc entry on new
> > Coccinelle page, right? If so, "fix invalid URL" may not be right patch
> > description and title.
>
> Agreed, thanks for the suggestion.

Okay. Let's modify the title to "modify SPL reference URL to actual
SPL doc entry".

BTW, I modify this URL because the previous URL cannot be accessed.

>
> julia

Re: [cocci] [PATCH] dev-tools: fix one invalid url

[Jonathan Corbet]

Dongliang Mu <mudongliangabcd@gmail.com> writes:

> On Mon, Jun 13, 2022 at 6:12 PM Julia Lawall <julia.lawall@inria.fr> wrote:
>>
>>
>>
>> On Mon, 13 Jun 2022, Bagas Sanjaya wrote:
>>
>> > On Mon, Jun 13, 2022 at 03:12:42PM +0800, Dongliang Mu wrote:
>> > > From: Dongliang Mu <mudongliangabcd@gmail.com>
>> > >
>> > > Fix the invalid url about Semantic Patch Language
>> > >
>> >
>> > I think what this patch doing is to point SPL reference URL from old
>> > Coccinelle documentation (doc root) to actual SPL doc entry on new
>> > Coccinelle page, right? If so, "fix invalid URL" may not be right patch
>> > description and title.
>>
>> Agreed, thanks for the suggestion.
>
> Okay. Let's modify the title to "modify SPL reference URL to actual
> SPL doc entry".

Normally, the way to effect such a modification is to submit a new
version of the patch reflecting the change.

I've applied the original patch and made the change, but it's better not
to ask maintainers to do that.

Thanks,

jon

Re: [cocci] [PATCH] dev-tools: fix one invalid url

[Dongliang Mu]

On Sat, Jun 25, 2022 at 3:37 AM Jonathan Corbet <corbet@lwn.net> wrote:
>
> Dongliang Mu <mudongliangabcd@gmail.com> writes:
>
> > On Mon, Jun 13, 2022 at 6:12 PM Julia Lawall <julia.lawall@inria.fr> wrote:
> >>
> >>
> >>
> >> On Mon, 13 Jun 2022, Bagas Sanjaya wrote:
> >>
> >> > On Mon, Jun 13, 2022 at 03:12:42PM +0800, Dongliang Mu wrote:
> >> > > From: Dongliang Mu <mudongliangabcd@gmail.com>
> >> > >
> >> > > Fix the invalid url about Semantic Patch Language
> >> > >
> >> >
> >> > I think what this patch doing is to point SPL reference URL from old
> >> > Coccinelle documentation (doc root) to actual SPL doc entry on new
> >> > Coccinelle page, right? If so, "fix invalid URL" may not be right patch
> >> > description and title.
> >>
> >> Agreed, thanks for the suggestion.
> >
> > Okay. Let's modify the title to "modify SPL reference URL to actual
> > SPL doc entry".
>
> Normally, the way to effect such a modification is to submit a new
> version of the patch reflecting the change.

I know this rule. It seems I forget to send a v2 patch.

>
> I've applied the original patch and made the change, but it's better not
> to ask maintainers to do that.

This change is surely on my part. I am sorry to forget about this v2 patch.

>
> Thanks,
>
> jon