* Re: [Cocci] [PATCH v2 04/10] mmap locking API: use coccinelle to convert mmap_sem rwsem call sites
[not found] ` <20200327021058.221911-5-walken@google.com>
@ 2020-03-27 7:22 ` Markus Elfring
2020-03-27 7:44 ` Michel Lespinasse
0 siblings, 1 reply; 5+ messages in thread
From: Markus Elfring @ 2020-03-27 7:22 UTC (permalink / raw)
To: Michel Lespinasse, linux-mm
Cc: Davidlohr Bueso, Peter Zijlstra, Hugh Dickins, LKML,
Liam Howlett, Jason Gunthorpe, Matthew Wilcox, Ying Han,
David Rientjes, Andrew Morton, Laurent Dufour, Coccinelle,
Vlastimil Babka
> This change converts the existing mmap_sem rwsem calls to use the new
> mmap locking API instead.
>
> The change is generated using coccinelle with the following rules:
Would you like to apply only a single SmPL rule here?
> // spatch --sp-file mmap_lock_api.cocci --in-place --include-headers --dir .
Command parameters like “--jobs 8 --chunksize 1” can be also helpful
for a parallel execution of the desired software transformation.
I suggest to consider another possibility for a bit of fine-tuning in the shown
SmPL script if you would eventually care for nicer run time characteristics
for the application of such a SmPL disjunction.
How do you think about to order the elements according to a probable
function call frequency?
Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Cocci] [PATCH v2 04/10] mmap locking API: use coccinelle to convert mmap_sem rwsem call sites
2020-03-27 7:22 ` [Cocci] [PATCH v2 04/10] mmap locking API: use coccinelle to convert mmap_sem rwsem call sites Markus Elfring
@ 2020-03-27 7:44 ` Michel Lespinasse
2020-03-27 8:00 ` [Cocci] [v2 " Markus Elfring
0 siblings, 1 reply; 5+ messages in thread
From: Michel Lespinasse @ 2020-03-27 7:44 UTC (permalink / raw)
To: Markus Elfring
Cc: Davidlohr Bueso, Jason Gunthorpe, Peter Zijlstra, Hugh Dickins,
LKML, Matthew Wilcox, linux-mm, Liam Howlett, Ying Han,
David Rientjes, Andrew Morton, Laurent Dufour, Coccinelle,
Vlastimil Babka
On Fri, Mar 27, 2020 at 12:22 AM Markus Elfring <Markus.Elfring@web.de> wrote:
>
> > This change converts the existing mmap_sem rwsem calls to use the new
> > mmap locking API instead.
> >
> > The change is generated using coccinelle with the following rules:
>
> Would you like to apply only a single SmPL rule here?
I think this version of the patch is already a single rule, similar to
what you suggested ?
> > // spatch --sp-file mmap_lock_api.cocci --in-place --include-headers --dir .
>
> Command parameters like “--jobs 8 --chunksize 1” can be also helpful
> for a parallel execution of the desired software transformation.
>
> I suggest to consider another possibility for a bit of fine-tuning in the shown
> SmPL script if you would eventually care for nicer run time characteristics
> for the application of such a SmPL disjunction.
> How do you think about to order the elements according to a probable
> function call frequency?
I'm not sure it matters that much, as long as it produces the correct
end result. The run takes about 25 seconds before any optimizations,
which I find very acceptable.
--
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Cocci] [v2 04/10] mmap locking API: use coccinelle to convert mmap_sem rwsem call sites
2020-03-27 7:44 ` Michel Lespinasse
@ 2020-03-27 8:00 ` Markus Elfring
2020-03-27 8:08 ` Michel Lespinasse
0 siblings, 1 reply; 5+ messages in thread
From: Markus Elfring @ 2020-03-27 8:00 UTC (permalink / raw)
To: Michel Lespinasse, linux-mm
Cc: Davidlohr Bueso, Peter Zijlstra, Hugh Dickins, LKML,
Liam Howlett, Jason Gunthorpe, Matthew Wilcox, Ying Han,
David Rientjes, Andrew Morton, Laurent Dufour, Coccinelle,
Vlastimil Babka
>>> The change is generated using coccinelle with the following rules:
>>
>> Would you like to apply only a single SmPL rule here?
>
> I think this version of the patch is already a single rule,
> similar to what you suggested ?
Yes. - But you repeated the wording “rules” in the change description.
Are there any other software extensions still in the waiting queue?
> I'm not sure it matters that much, as long as it produces the correct
> end result. The run takes about 25 seconds before any optimizations,
> which I find very acceptable.
I am used to look also at the run time characteristics of
SmPL script execution.
The discussed SmPL code can be good enough for your current needs.
Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Cocci] [v2 04/10] mmap locking API: use coccinelle to convert mmap_sem rwsem call sites
2020-03-27 8:00 ` [Cocci] [v2 " Markus Elfring
@ 2020-03-27 8:08 ` Michel Lespinasse
0 siblings, 0 replies; 5+ messages in thread
From: Michel Lespinasse @ 2020-03-27 8:08 UTC (permalink / raw)
To: Markus Elfring
Cc: Davidlohr Bueso, Jason Gunthorpe, Peter Zijlstra, Hugh Dickins,
LKML, Matthew Wilcox, linux-mm, Liam Howlett, Ying Han,
David Rientjes, Andrew Morton, Laurent Dufour, Coccinelle,
Vlastimil Babka
On Fri, Mar 27, 2020 at 1:00 AM Markus Elfring <Markus.Elfring@web.de> wrote:
>
> >>> The change is generated using coccinelle with the following rules:
> >>
> >> Would you like to apply only a single SmPL rule here?
> >
> > I think this version of the patch is already a single rule,
> > similar to what you suggested ?
>
> Yes. - But you repeated the wording “rules” in the change description.
> Are there any other software extensions still in the waiting queue?
Ah yes, I did not change the wording before the included .cocci file.
I do not have any more coccinelle patches to push in the near future.
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Cocci] [PATCH v2 05/10] mmap locking API: convert mmap_sem call sites missed by coccinelle
[not found] ` <20200327021058.221911-6-walken@google.com>
@ 2020-03-27 8:21 ` Markus Elfring
0 siblings, 0 replies; 5+ messages in thread
From: Markus Elfring @ 2020-03-27 8:21 UTC (permalink / raw)
To: Michel Lespinasse, Coccinelle, linux-mm
Cc: Davidlohr Bueso, Peter Zijlstra, Hugh Dickins, LKML,
Liam Howlett, Jason Gunthorpe, Matthew Wilcox, Ying Han,
David Rientjes, Andrew Morton, Laurent Dufour, Vlastimil Babka
> Convert the last few remaining mmap_sem rwsem calls to use the new
> mmap locking API. These were missed by coccinelle for some reason
I find such a software situation still unfortunate.
* Should the data processing results be clarified any further
for the shown transformation approach?
* Will additional improvements be considered?
Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-03-27 18:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200327021058.221911-1-walken@google.com>
[not found] ` <20200327021058.221911-5-walken@google.com>
2020-03-27 7:22 ` [Cocci] [PATCH v2 04/10] mmap locking API: use coccinelle to convert mmap_sem rwsem call sites Markus Elfring
2020-03-27 7:44 ` Michel Lespinasse
2020-03-27 8:00 ` [Cocci] [v2 " Markus Elfring
2020-03-27 8:08 ` Michel Lespinasse
[not found] ` <20200327021058.221911-6-walken@google.com>
2020-03-27 8:21 ` [Cocci] [PATCH v2 05/10] mmap locking API: convert mmap_sem call sites missed by coccinelle Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).