From: Daniel Wagner <wagi@monom.org>
To: "Страхиња Радић" <contact@strahinja.org>
Cc: connman <connman@lists.linux.dev>
Subject: Re: [PATCH v1 2/2] service: Do not trigger wispr start when EnableOnlineCheck is disabled
Date: Mon, 30 Aug 2021 08:44:03 +0200 [thread overview]
Message-ID: <20210830064403.5r3szonne7baipa2@carbon.lan> (raw)
In-Reply-To: <20210829200849.6ttu3udd65fk7lt3@prancingpony>
On Sun, Aug 29, 2021 at 10:08:49PM +0200, Страхиња Радић wrote:
> On 21/08/29 09:53, Daniel Wagner wrote:
> > Do not try to use wispr when the user has disabled the online check.
>
> The patch you proposed seems fine to me. The gist is to let the user control if
> the online check happens or not.
Could you give them a quick test if they work for you? Thanks!
next prev parent reply other threads:[~2021-08-30 6:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-29 19:53 [PATCH v1 0/2] Disable online check for real Daniel Wagner
2021-08-29 19:53 ` [PATCH v1 1/2] service: Move wispr start code into helper Daniel Wagner
2021-08-29 19:53 ` [PATCH v1 2/2] service: Do not trigger wispr start when EnableOnlineCheck is disabled Daniel Wagner
2021-08-29 20:08 ` Страхиња Радић
2021-08-30 6:44 ` Daniel Wagner [this message]
2021-08-30 10:34 ` Страхиња Радић
2021-08-30 11:02 ` Страхиња Радић
2021-08-30 14:29 ` Daniel Wagner
2021-08-30 16:32 ` [PATCH v1 0/2] Disable online check for real Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210830064403.5r3szonne7baipa2@carbon.lan \
--to=wagi@monom.org \
--cc=connman@lists.linux.dev \
--cc=contact@strahinja.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).