connman.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Daniel Wagner <wagi@monom.org>
To: "VAUTRIN Emmanuel (Canal Plus Prestataire)"
	<Emmanuel.VAUTRIN@cpexterne.org>
Cc: "connman@lists.linux.dev" <connman@lists.linux.dev>
Subject: Re: [PATCH] build: Fix compiler maybe-uninitialized warnings
Date: Mon, 20 Sep 2021 09:22:23 +0200	[thread overview]
Message-ID: <20210920072223.l4pgmhaqsfgee6m6@beryllium.lan> (raw)
In-Reply-To: <MRZP264MB1544BB065A7FADD9BC38F69693D99@MRZP264MB1544.FRAP264.PROD.OUTLOOK.COM>

Hi Emmanuel,

On Mon, Sep 13, 2021 at 07:45:19AM +0000, VAUTRIN Emmanuel (Canal Plus Prestataire) wrote:
> > > -             provision_service_wifi(config, service, network,
> > > -                                                     ssid, ssid_len);
> > > +             provision_service_wifi(config, service, network);
> 
> > Could you split this into cleanup patch with a commit message?
> In fact, all my modifications are fixes of maybe-uninitialized warnings.

My compiler doesn't report them (gcc11). What compiler do you use and
what are the compile flags?

> In this case, ssid is not initialized.
> I thought title was explicit enough, what can I had in my comment?

Something like

"""
config: Remove unused arguments from provision_service_wifi()


gcc-10 complains with:

  ...

Remove the ssid and ssid_len argument from provision_service() as they
are not used.
"""

I know it's pretty obvious right now, but having ten commits in a row
with 'fix foo' and 'fix bar' without any explanation makes any 'git
blame' 'git log' operation really painful in two months from now. Been
there done that.

BTW, I tried to trigger the warnings and I was not able to. Now I am
trying to fix up clang compile errors...

Daniel

  reply	other threads:[~2021-09-20  7:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-13  7:17 [PATCH] build: Fix compiler maybe-uninitialized warnings VAUTRIN Emmanuel (Canal Plus Prestataire)
2021-09-13  7:27 ` Daniel Wagner
2021-09-13  7:45   ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2021-09-20  7:22     ` Daniel Wagner [this message]
2021-09-20  8:15       ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2021-10-18  7:26         ` Daniel Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210920072223.l4pgmhaqsfgee6m6@beryllium.lan \
    --to=wagi@monom.org \
    --cc=Emmanuel.VAUTRIN@cpexterne.org \
    --cc=connman@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).