From: Daniel Wagner <wagi@monom.org>
To: "VAUTRIN Emmanuel (Canal Plus Prestataire)"
<Emmanuel.VAUTRIN@cpexterne.org>
Cc: "connman@lists.linux.dev" <connman@lists.linux.dev>
Subject: Re: [PATCH] build: Fix compiler maybe-uninitialized warnings
Date: Mon, 18 Oct 2021 09:26:59 +0200 [thread overview]
Message-ID: <20211018072659.37ykm2awn7hevhlg@beryllium.lan> (raw)
In-Reply-To: <MRZP264MB154402D3255D322D8E7CBC1F93A09@MRZP264MB1544.FRAP264.PROD.OUTLOOK.COM>
Hi Emmanuel,
On Mon, Sep 20, 2021 at 08:15:26AM +0000, VAUTRIN Emmanuel (Canal Plus Prestataire) wrote:
> Hi Daniel,
> > My compiler doesn't report them (gcc11). What compiler do you use and
> > what are the compile flags?
> > (...)
> > BTW, I tried to trigger the warnings and I was not able to. Now I am
> > trying to fix up clang compile errors...
> It is on clang-12 (with -Wall -Werror,, in order to provide clean patches),
> so you will probably face the problem. I let you finish your integration.
> As said in the title, you can try the -Werror=maybe-uninitialized flag.
I've tried again just to double check. The version of clang (12.0.1) I got
doesn't even know the compile flag.
error: unknown warning option '-Werror=maybe-uninitialized'; did you mean '-Werror=uninitialized'?
Even adding '-Werror=uninitialized' didn't trigger the build failure.
Also the current head builds just fine with '-Wall -Werror'.
Anyway, could you please add some commit message to the patches
explaining the change.
Thanks,
Daniel
prev parent reply other threads:[~2021-10-18 7:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 7:17 [PATCH] build: Fix compiler maybe-uninitialized warnings VAUTRIN Emmanuel (Canal Plus Prestataire)
2021-09-13 7:27 ` Daniel Wagner
2021-09-13 7:45 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2021-09-20 7:22 ` Daniel Wagner
2021-09-20 8:15 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2021-10-18 7:26 ` Daniel Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211018072659.37ykm2awn7hevhlg@beryllium.lan \
--to=wagi@monom.org \
--cc=Emmanuel.VAUTRIN@cpexterne.org \
--cc=connman@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).