From: "VAUTRIN Emmanuel (Canal Plus Prestataire)" <Emmanuel.VAUTRIN@cpexterne.org>
To: Daniel Wagner <wagi@monom.org>
Cc: "connman@lists.linux.dev" <connman@lists.linux.dev>
Subject: RE: [PATCH] build: Fix compiler maybe-uninitialized warnings
Date: Mon, 13 Sep 2021 07:45:19 +0000 [thread overview]
Message-ID: <MRZP264MB1544BB065A7FADD9BC38F69693D99@MRZP264MB1544.FRAP264.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20210913072719.3qlnsqjzplntm265@beryllium.lan>
Hello Daniel,
> > - provision_service_wifi(config, service, network,
> > - ssid, ssid_len);
> > + provision_service_wifi(config, service, network);
> Could you split this into cleanup patch with a commit message?
In fact, all my modifications are fixes of maybe-uninitialized warnings.
In this case, ssid is not initialized.
I thought title was explicit enough, what can I had in my comment?
> > + char *dom = NULL;
> Same here (maybe including the compiler warning).
Do you really want to split patches even if they correspond to
the same activity (maybe-uninitialized warnings)?
> For the tools/* fixes this is okay. Not really important stuff :)
Indeed, just compilation stuff, I don't think it could have any
impact at usage, but it fixes the -Wall -Werror compilation.
Best Regards,
Emmanuel
next prev parent reply other threads:[~2021-09-13 7:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 7:17 [PATCH] build: Fix compiler maybe-uninitialized warnings VAUTRIN Emmanuel (Canal Plus Prestataire)
2021-09-13 7:27 ` Daniel Wagner
2021-09-13 7:45 ` VAUTRIN Emmanuel (Canal Plus Prestataire) [this message]
2021-09-20 7:22 ` Daniel Wagner
2021-09-20 8:15 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2021-10-18 7:26 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MRZP264MB1544BB065A7FADD9BC38F69693D99@MRZP264MB1544.FRAP264.PROD.OUTLOOK.COM \
--to=emmanuel.vautrin@cpexterne.org \
--cc=connman@lists.linux.dev \
--cc=wagi@monom.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).