connman.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Daniel Wagner <wagi@monom.org>
To: Jussi Laakkonen <jussi.laakkonen@jolla.com>
Cc: connman@lists.linux.dev
Subject: Re: [PATCH v1 0/2] Improve OpenVPN configuration value processing
Date: Thu, 18 Nov 2021 22:02:39 +0100	[thread overview]
Message-ID: <20211118210239.syttg5jfgbdmgfzm@beryllium.lan> (raw)
In-Reply-To: <20211116151417.14827-1-jussi.laakkonen@jolla.com>

Hi Jussi,

On Tue, Nov 16, 2021 at 05:14:15PM +0200, Jussi Laakkonen wrote:
> Rework how OpenVPN processes the configuration values by introducing a
> more clear way to classify different types of options. This makes it possible
> to add options that may have a value or can be used without a value thus,
> resorting to default value set for the option. Also the --auth-user-pass
> and alike options having a special value are handled in cleaner way.
> 
> Motivation for this was that the --comp-lzo option was not processed
> correctly with its value, and even though being listed as deprecated some
> OpenVPN providers use the value. Omitting this option even though it was
> required caused issues with both UDP and TCP VPNs:
>   write to TUN/TAP : Invalid argument (code=22)
> after which OpenVPN silently restarts itself.

Both patches applied after fixing up a warning:

vpn/plugins/openvpn.c:394:25: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]                              
  394 |                         const char *opt_to_null = ov_options[i].ov_opt_to_null;                                                             
      |                         ^~~~~                                                                                                               

Daniel

  parent reply	other threads:[~2021-11-18 21:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-16 15:14 [PATCH v1 0/2] Improve OpenVPN configuration value processing Jussi Laakkonen
2021-11-16 15:14 ` [PATCH v1 1/2] vpn-provider: Support checking if provider setting key exists Jussi Laakkonen
2021-11-16 15:14 ` [PATCH v1 2/2] openvpn: Improve configuration value processing Jussi Laakkonen
2021-11-18 21:02 ` Daniel Wagner [this message]
2021-11-19  8:09   ` [PATCH v1 0/2] Improve OpenVPN " Jussi Laakkonen
2021-11-19  8:30     ` Daniel Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211118210239.syttg5jfgbdmgfzm@beryllium.lan \
    --to=wagi@monom.org \
    --cc=connman@lists.linux.dev \
    --cc=jussi.laakkonen@jolla.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).