Re: [PATCH v1 0/2] Improve OpenVPN configuration value processing

[Jussi Laakkonen <jussi.laakkonen@jolla.com>]

Hi Daniel,

On 11/18/21 11:02 PM, Daniel Wagner wrote:
> Hi Jussi,
> 
> On Tue, Nov 16, 2021 at 05:14:15PM +0200, Jussi Laakkonen wrote:
>> Rework how OpenVPN processes the configuration values by introducing a
>> more clear way to classify different types of options. This makes it possible
>> to add options that may have a value or can be used without a value thus,
>> resorting to default value set for the option. Also the --auth-user-pass
>> and alike options having a special value are handled in cleaner way.
>>
>> Motivation for this was that the --comp-lzo option was not processed
>> correctly with its value, and even though being listed as deprecated some
>> OpenVPN providers use the value. Omitting this option even though it was
>> required caused issues with both UDP and TCP VPNs:
>>    write to TUN/TAP : Invalid argument (code=22)
>> after which OpenVPN silently restarts itself.
> 
> Both patches applied after fixing up a warning:
> 

Thanks.

> vpn/plugins/openvpn.c:394:25: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
>    394 |                         const char *opt_to_null = ov_options[i].ov_opt_to_null;
>        |                         ^~~~~
> 

Oops, sorry. My build env did not complain about that so I guess I 
overlooked that bit.

Cheers,
  Jussi