connman.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Daniel Wagner <wagi@monom.org>
To: Nicky Geerts <nicky.geerts@gmail.com>
Cc: connman@lists.linux.dev
Subject: Re: [PATCH 0/2] timeserver not resolving ntp server
Date: Fri, 4 Mar 2022 09:56:28 +0100	[thread overview]
Message-ID: <20220304085628.eiwriua74hrrgl45@beryllium.lan> (raw)
In-Reply-To: <20220228124930.4010311-1-nicky.geerts@gmail.com>

Hi Nicky,

On Mon, Feb 28, 2022 at 01:49:28PM +0100, Nicky Geerts wrote:
> This is a series of fixes for an issue where the timeserver cannot
> resolve the ntp servers.
> 
> 1. when the UDP g_io_channel in the nameserver is closed or in an
> invalid state (for example by a misbehaving external DNS server, during
> a start up sequence), DNS resolve will fail for the ntp server, and
> won't ever be able to recover
> 
> 2. when a service switches from the autoconf link local address to an
> address configured by DHCP, the timeserver will drop the notification,
> and the nameservers will not be reloaded in the timeserver's resolv instance.

Thanks for the excellent problem description. It really helps. The
changes look good though they seem to have the wrong ident level. Could
you check if you have used tabs?

Thanks,
Daniel

  parent reply	other threads:[~2022-03-04  8:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-28 12:49 [PATCH 0/2] timeserver not resolving ntp server Nicky Geerts
2022-02-28 12:49 ` [PATCH 1/2] timeserver: refresh the nameservers before each lookup Nicky Geerts
2022-02-28 12:49 ` [PATCH 2/2] timeserver: include the reason why a timeserver sync is requested Nicky Geerts
2022-03-04  8:56 ` Daniel Wagner [this message]
2022-03-07  8:44 ` [PATCH 1/2] timeserver: refresh the nameservers before each lookup Nicky Geerts
2022-03-07  9:19   ` Daniel Wagner
2022-03-07  8:44 ` [PATCH 2/2] timeserver: include the reason why a timeserver sync is requested Nicky Geerts
2022-03-07  9:20   ` Daniel Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220304085628.eiwriua74hrrgl45@beryllium.lan \
    --to=wagi@monom.org \
    --cc=connman@lists.linux.dev \
    --cc=nicky.geerts@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).