connman.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Daniel Wagner <wagi@monom.org>
To: Nicky Geerts <nicky.geerts@gmail.com>
Cc: connman@lists.linux.dev
Subject: Re: [PATCH 2/2] timeserver: include the reason why a timeserver sync is requested
Date: Mon, 7 Mar 2022 10:20:13 +0100	[thread overview]
Message-ID: <20220307092013.t4s3belmfkhfxe4s@beryllium.lan> (raw)
In-Reply-To: <20220307084432.62446-3-nicky.geerts@gmail.com>

On Mon, Mar 07, 2022 at 09:44:32AM +0100, Nicky Geerts wrote:
> Except for the initial connman_timeserver_start call, and potential
> updated of the default service, all subsequent calls to resynchronise
> the timeserver are blocked because of the check whether service equals
> ts_service in __connman_timeserver_sync.
> 
> DHCP updates, which could replace the timeserver and nameservers, and state
> change updates are ignored.
> 
> As previously suggested by Daniel Wagner on Nov 19th 2019 in a mail to
> Vivien Henriet, it would be best to pass the reason of the sync call,
> and add the logic in __connman_timeserver_sync.

Patch applied.

FWIW, I added a few newlines so the lines are not over 80 chars.

Thanks,
Daniel

      reply	other threads:[~2022-03-07  9:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-28 12:49 [PATCH 0/2] timeserver not resolving ntp server Nicky Geerts
2022-02-28 12:49 ` [PATCH 1/2] timeserver: refresh the nameservers before each lookup Nicky Geerts
2022-02-28 12:49 ` [PATCH 2/2] timeserver: include the reason why a timeserver sync is requested Nicky Geerts
2022-03-04  8:56 ` [PATCH 0/2] timeserver not resolving ntp server Daniel Wagner
2022-03-07  8:44 ` [PATCH 1/2] timeserver: refresh the nameservers before each lookup Nicky Geerts
2022-03-07  9:19   ` Daniel Wagner
2022-03-07  8:44 ` [PATCH 2/2] timeserver: include the reason why a timeserver sync is requested Nicky Geerts
2022-03-07  9:20   ` Daniel Wagner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220307092013.t4s3belmfkhfxe4s@beryllium.lan \
    --to=wagi@monom.org \
    --cc=connman@lists.linux.dev \
    --cc=nicky.geerts@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).