connman.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Daniel Wagner <wagi@monom.org>
To: Nicky Geerts <nicky.geerts@gmail.com>
Cc: connman@lists.linux.dev
Subject: Re: [PATCH 1/2] timeserver: refresh the nameservers before each lookup
Date: Mon, 7 Mar 2022 10:19:01 +0100	[thread overview]
Message-ID: <20220307091901.qnipr6x3vanzldh7@beryllium.lan> (raw)
In-Reply-To: <20220307084432.62446-2-nicky.geerts@gmail.com>

Hi Nicky,

On Mon, Mar 07, 2022 at 09:44:31AM +0100, Nicky Geerts wrote:
> There is a possibility where the UDP channel connections in the resolv
> instance are being closed because of how the external DNS service might
> respond, and are never opened again.  The DNS resolve will keep failing,
> and there is no automatic recovery from this.
> 
> Similar to the behavior of the WISPR module, refresh the nameservers in
> the resolv instance before each DNS request.

Patch applied.

I had to fix a few small fix though:

src/timeserver.c: In function ‘ts_reset’:
src/timeserver.c:398:13: error: unused variable ‘i’ [-Werror=unused-variable]
  398 |         int i;
      |             ^
src/timeserver.c: In function ‘timeserver_start’:
src/timeserver.c:471:13: error: unused variable ‘i’ [-Werror=unused-variable]
  471 |         int i;
      |             ^

and couple of white space damages.

Thanks,
Daniel

  reply	other threads:[~2022-03-07  9:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-28 12:49 [PATCH 0/2] timeserver not resolving ntp server Nicky Geerts
2022-02-28 12:49 ` [PATCH 1/2] timeserver: refresh the nameservers before each lookup Nicky Geerts
2022-02-28 12:49 ` [PATCH 2/2] timeserver: include the reason why a timeserver sync is requested Nicky Geerts
2022-03-04  8:56 ` [PATCH 0/2] timeserver not resolving ntp server Daniel Wagner
2022-03-07  8:44 ` [PATCH 1/2] timeserver: refresh the nameservers before each lookup Nicky Geerts
2022-03-07  9:19   ` Daniel Wagner [this message]
2022-03-07  8:44 ` [PATCH 2/2] timeserver: include the reason why a timeserver sync is requested Nicky Geerts
2022-03-07  9:20   ` Daniel Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220307091901.qnipr6x3vanzldh7@beryllium.lan \
    --to=wagi@monom.org \
    --cc=connman@lists.linux.dev \
    --cc=nicky.geerts@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).