connman.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Ryan Smith <ryan.smith@density.io>
To: connman@lists.linux.dev
Cc: Ryan Smith <ryan.smith@density.io>
Subject: [PATCH v1 1/2] dhcp: Set proxy properly when applying DHCP lease
Date: Mon, 11 Apr 2022 11:32:16 -0600	[thread overview]
Message-ID: <20220411173217.505144-1-ryan.smith@density.io> (raw)

When DHCP Option 252 (PAC file URL) is included,
the service should be updated. Doing so sets the proxy
method to 'auto', updates the ipconfig object, and
notifies PACrunner (if included) that the proxy setting
has changed.

Currently, only the ipconfig object is updated. This patch
calls the proper function to perform these actions.
---
 src/dhcp.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/dhcp.c b/src/dhcp.c
index 11274269..bf100b9b 100644
--- a/src/dhcp.c
+++ b/src/dhcp.c
@@ -422,8 +422,7 @@ static bool apply_lease_available_on_network(GDHCPClient *dhcp_client,
 		g_free(dhcp->pac);
 		dhcp->pac = pac;
 
-		__connman_ipconfig_set_proxy_autoconfig(dhcp->ipconfig,
-								dhcp->pac);
+		__connman_service_set_proxy_autoconfig(service, dhcp->pac);
 	}
 
 	if (connman_setting_get_bool("Enable6to4"))
-- 
2.25.1


             reply	other threads:[~2022-04-11 17:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-11 17:32 Ryan Smith [this message]
2022-04-11 17:32 ` [PATCH v1 2/2] wispr: Fix online check when using WPAD/PAC Ryan Smith
2022-04-14 19:01   ` Daniel Wagner
2022-04-14 20:44     ` Ryan Smith
2022-05-16  6:35       ` Daniel Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220411173217.505144-1-ryan.smith@density.io \
    --to=ryan.smith@density.io \
    --cc=connman@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).