connman.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Daniel Wagner <wagi@monom.org>
To: Ryan Smith <ryan.smith@density.io>
Cc: connman@lists.linux.dev
Subject: Re: [PATCH v1 2/2] wispr: Fix online check when using WPAD/PAC
Date: Thu, 14 Apr 2022 21:01:36 +0200	[thread overview]
Message-ID: <20220414190136.zebsvyjysfyem3tz@beryllium.lan> (raw)
In-Reply-To: <20220411173217.505144-2-ryan.smith@density.io>

Hi Rayn,

On Mon, Apr 11, 2022 at 11:32:17AM -0600, Ryan Smith wrote:
> A PAC file can return multiple proxies in response to a query.
> They are separated by a semicolon and, possibly, a space.
> 
> 'PROXY proxy1.example.com:3128; PROXY proxy2.example.com; DIRECT'
> 
> Currently, this is not handled, and the inclusion of more than
> one proxy causes the online check to fail. This fix parses the
> first proxy in the list and uses it.

Patch patches applied. I took the liberty and refactored parse_proxy()
slighly to much the style. Also we are still stuck pre C99 (I know...)
so the declaration have to go to the beginning of the block.

Please let me know if I screwed it up.

Thanks,
Daniel

  reply	other threads:[~2022-04-14 19:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-11 17:32 [PATCH v1 1/2] dhcp: Set proxy properly when applying DHCP lease Ryan Smith
2022-04-11 17:32 ` [PATCH v1 2/2] wispr: Fix online check when using WPAD/PAC Ryan Smith
2022-04-14 19:01   ` Daniel Wagner [this message]
2022-04-14 20:44     ` Ryan Smith
2022-05-16  6:35       ` Daniel Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220414190136.zebsvyjysfyem3tz@beryllium.lan \
    --to=wagi@monom.org \
    --cc=connman@lists.linux.dev \
    --cc=ryan.smith@density.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).