From: Ryan Smith <ryan.smith@density.io>
To: Daniel Wagner <wagi@monom.org>
Cc: connman@lists.linux.dev
Subject: Re: [PATCH v1 2/2] wispr: Fix online check when using WPAD/PAC
Date: Thu, 14 Apr 2022 14:44:49 -0600 [thread overview]
Message-ID: <CAM7Wg-Xhvm9zFJx4wnr5pVo_VDGTh+UK9GSbDX_HB+uAVk0kiw@mail.gmail.com> (raw)
In-Reply-To: <20220414190136.zebsvyjysfyem3tz@beryllium.lan>
It looks good to me. Thanks for the quick response!
-Ryan
On Thu, Apr 14, 2022 at 1:01 PM Daniel Wagner <wagi@monom.org> wrote:
>
> Hi Rayn,
>
> On Mon, Apr 11, 2022 at 11:32:17AM -0600, Ryan Smith wrote:
> > A PAC file can return multiple proxies in response to a query.
> > They are separated by a semicolon and, possibly, a space.
> >
> > 'PROXY proxy1.example.com:3128; PROXY proxy2.example.com; DIRECT'
> >
> > Currently, this is not handled, and the inclusion of more than
> > one proxy causes the online check to fail. This fix parses the
> > first proxy in the list and uses it.
>
> Patch patches applied. I took the liberty and refactored parse_proxy()
> slighly to much the style. Also we are still stuck pre C99 (I know...)
> so the declaration have to go to the beginning of the block.
>
> Please let me know if I screwed it up.
>
> Thanks,
> Daniel
next prev parent reply other threads:[~2022-04-14 20:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 17:32 [PATCH v1 1/2] dhcp: Set proxy properly when applying DHCP lease Ryan Smith
2022-04-11 17:32 ` [PATCH v1 2/2] wispr: Fix online check when using WPAD/PAC Ryan Smith
2022-04-14 19:01 ` Daniel Wagner
2022-04-14 20:44 ` Ryan Smith [this message]
2022-05-16 6:35 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM7Wg-Xhvm9zFJx4wnr5pVo_VDGTh+UK9GSbDX_HB+uAVk0kiw@mail.gmail.com \
--to=ryan.smith@density.io \
--cc=connman@lists.linux.dev \
--cc=wagi@monom.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).