From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Walker Chen <walker.chen@starfivetech.com>, linux-riscv@lists.infradead.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org Cc: Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor.dooley@microchip.com>, Emil Renner Berthing <emil.renner.berthing@canonical.com>, "Rafael J . Wysocki" <rafael@kernel.org>, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH v2 1/3] dt-bindings: power: Add starfive,jh71xx-pmu Date: Thu, 8 Dec 2022 09:59:27 +0100 [thread overview] Message-ID: <d0226fa9-9253-72fc-2fb0-5bfbbcba5d86@linaro.org> (raw) In-Reply-To: <20221208084523.9733-2-walker.chen@starfivetech.com> On 08/12/2022 09:45, Walker Chen wrote: > Add bindings for Power Management Unit (PMU) on the StarFive JH71XX SoC. > > Signed-off-by: Walker Chen <walker.chen@starfivetech.com> > --- > .../bindings/power/starfive,jh71xx-pmu.yaml | 45 +++++++++++++++++++ > .../dt-bindings/power/starfive,jh7110-pmu.h | 17 +++++++ > 2 files changed, 62 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/starfive,jh71xx-pmu.yaml Filename matching compatible, so: starfive,jh7110-pmu.yaml > create mode 100644 include/dt-bindings/power/starfive,jh7110-pmu.h > > diff --git a/Documentation/devicetree/bindings/power/starfive,jh71xx-pmu.yaml b/Documentation/devicetree/bindings/power/starfive,jh71xx-pmu.yaml > new file mode 100644 > index 000000000000..f308ae136a57 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/starfive,jh71xx-pmu.yaml > @@ -0,0 +1,45 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/power/starfive,jh71xx-pmu.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: StarFive JH71xx Power Management Unit > + > +maintainers: > + - Walker Chen <walker.chen@starfivetech.com> > + > +description: | > + StarFive JH71xx SoCs include support for multiple power domains which can be > + powered on/off by software based on different application scenes to save power. > + > +properties: > + compatible: > + - enum: Wrong indentation. Does not look like you tested the bindings. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). > + - starfive,jh7110-pmu > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + "#power-domain-cells": > + const: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - "#power-domain-cells" > + Best regards, Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Walker Chen <walker.chen@starfivetech.com>, linux-riscv@lists.infradead.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org Cc: Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor.dooley@microchip.com>, Emil Renner Berthing <emil.renner.berthing@canonical.com>, "Rafael J . Wysocki" <rafael@kernel.org>, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH v2 1/3] dt-bindings: power: Add starfive,jh71xx-pmu Date: Thu, 8 Dec 2022 09:59:27 +0100 [thread overview] Message-ID: <d0226fa9-9253-72fc-2fb0-5bfbbcba5d86@linaro.org> (raw) In-Reply-To: <20221208084523.9733-2-walker.chen@starfivetech.com> On 08/12/2022 09:45, Walker Chen wrote: > Add bindings for Power Management Unit (PMU) on the StarFive JH71XX SoC. > > Signed-off-by: Walker Chen <walker.chen@starfivetech.com> > --- > .../bindings/power/starfive,jh71xx-pmu.yaml | 45 +++++++++++++++++++ > .../dt-bindings/power/starfive,jh7110-pmu.h | 17 +++++++ > 2 files changed, 62 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/starfive,jh71xx-pmu.yaml Filename matching compatible, so: starfive,jh7110-pmu.yaml > create mode 100644 include/dt-bindings/power/starfive,jh7110-pmu.h > > diff --git a/Documentation/devicetree/bindings/power/starfive,jh71xx-pmu.yaml b/Documentation/devicetree/bindings/power/starfive,jh71xx-pmu.yaml > new file mode 100644 > index 000000000000..f308ae136a57 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/starfive,jh71xx-pmu.yaml > @@ -0,0 +1,45 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/power/starfive,jh71xx-pmu.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: StarFive JH71xx Power Management Unit > + > +maintainers: > + - Walker Chen <walker.chen@starfivetech.com> > + > +description: | > + StarFive JH71xx SoCs include support for multiple power domains which can be > + powered on/off by software based on different application scenes to save power. > + > +properties: > + compatible: > + - enum: Wrong indentation. Does not look like you tested the bindings. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). > + - starfive,jh7110-pmu > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + "#power-domain-cells": > + const: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - "#power-domain-cells" > + Best regards, Krzysztof _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-12-08 8:59 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-12-08 8:45 [RESEND PATCH v2 0/3] JH7110 PMU Support Walker Chen 2022-12-08 8:45 ` Walker Chen 2022-12-08 8:45 ` [RESEND PATCH v2 1/3] dt-bindings: power: Add starfive,jh71xx-pmu Walker Chen 2022-12-08 8:45 ` Walker Chen 2022-12-08 8:59 ` Krzysztof Kozlowski [this message] 2022-12-08 8:59 ` Krzysztof Kozlowski 2022-12-12 2:46 ` Walker Chen 2022-12-12 2:46 ` Walker Chen 2022-12-08 9:03 ` Krzysztof Kozlowski 2022-12-08 9:03 ` Krzysztof Kozlowski 2022-12-12 3:19 ` Walker Chen 2022-12-12 3:19 ` Walker Chen 2022-12-08 13:31 ` Rob Herring 2022-12-08 13:31 ` Rob Herring 2022-12-12 6:33 ` Walker Chen 2022-12-12 6:33 ` Walker Chen 2022-12-08 8:45 ` [RESEND PATCH v2 2/3] soc: starfive: Add StarFive JH71XX pmu driver Walker Chen 2022-12-08 8:45 ` Walker Chen 2022-12-19 20:40 ` Conor Dooley 2022-12-19 20:40 ` Conor Dooley 2022-12-28 2:08 ` Walker Chen 2022-12-28 2:08 ` Walker Chen 2022-12-28 19:50 ` Conor Dooley 2022-12-28 19:50 ` Conor Dooley 2023-01-09 6:32 ` Walker Chen 2023-01-09 6:32 ` Walker Chen 2022-12-08 8:45 ` [RESEND PATCH v2 3/3] riscv: dts: starfive: add pmu controller node Walker Chen 2022-12-08 8:45 ` Walker Chen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=d0226fa9-9253-72fc-2fb0-5bfbbcba5d86@linaro.org \ --to=krzysztof.kozlowski@linaro.org \ --cc=conor.dooley@microchip.com \ --cc=devicetree@vger.kernel.org \ --cc=emil.renner.berthing@canonical.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=rafael@kernel.org \ --cc=robh+dt@kernel.org \ --cc=walker.chen@starfivetech.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.