From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Peter Griffin <peter.griffin@linaro.org>, Rob Herring <robh+dt@kernel.org> Cc: krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, conor+dt@kernel.org, sboyd@kernel.org, tomasz.figa@gmail.com, s.nawrocki@samsung.com, linus.walleij@linaro.org, wim@linux-watchdog.org, linux@roeck-us.net, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, olof@lixom.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, cw00.choi@samsung.com, alim.akhtar@samsung.com, tudor.ambarus@linaro.org, andre.draszik@linaro.org, semen.protsenko@linaro.org, saravanak@google.com, willmcvicker@google.com, soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org, kernel-team@android.com, linux-serial@vger.kernel.org Subject: Re: [PATCH v7 08/16] clk: samsung: clk-gs101: Add cmu_top, cmu_misc and cmu_apm support Date: Tue, 12 Dec 2023 20:38:40 +0100 [thread overview] Message-ID: <d23cc32c-8a5b-48aa-be4d-608fbbb9ac3a@linaro.org> (raw) In-Reply-To: <CADrjBPrkso2cM8zKq-WU8WC3P3A9YoS6nqX-f6XvSNS-EofK9g@mail.gmail.com> On 11/12/2023 20:46, Peter Griffin wrote: >>> +#include <linux/platform_device.h> > > You are correct, this header isn't required. If a new series is > required I will remove it. I dropped it while applying. > > Whilst you're here I'd like to draw your attention to [PATCH 2/16] > where I've removed your reviewed-by tag in v7 because I added the ect > node documentation in google.yaml. The empty ect node is required to > be present by the bootloader or the device will boot loop. Can you > re-review that patch? > > The alternative is to remove the empty ect node, and the binding > documentation for it and add your Reviewed-by tag back again. But then > an upstream kernel won't boot 'out the box' on a pixel 6 which seems > less than ideal default behaviour. Best regards, Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Peter Griffin <peter.griffin@linaro.org>, Rob Herring <robh+dt@kernel.org> Cc: krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, conor+dt@kernel.org, sboyd@kernel.org, tomasz.figa@gmail.com, s.nawrocki@samsung.com, linus.walleij@linaro.org, wim@linux-watchdog.org, linux@roeck-us.net, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, olof@lixom.net, gregkh@linuxfoundation.org, jirislaby@kernel.org, cw00.choi@samsung.com, alim.akhtar@samsung.com, tudor.ambarus@linaro.org, andre.draszik@linaro.org, semen.protsenko@linaro.org, saravanak@google.com, willmcvicker@google.com, soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org, kernel-team@android.com, linux-serial@vger.kernel.org Subject: Re: [PATCH v7 08/16] clk: samsung: clk-gs101: Add cmu_top, cmu_misc and cmu_apm support Date: Tue, 12 Dec 2023 20:38:40 +0100 [thread overview] Message-ID: <d23cc32c-8a5b-48aa-be4d-608fbbb9ac3a@linaro.org> (raw) In-Reply-To: <CADrjBPrkso2cM8zKq-WU8WC3P3A9YoS6nqX-f6XvSNS-EofK9g@mail.gmail.com> On 11/12/2023 20:46, Peter Griffin wrote: >>> +#include <linux/platform_device.h> > > You are correct, this header isn't required. If a new series is > required I will remove it. I dropped it while applying. > > Whilst you're here I'd like to draw your attention to [PATCH 2/16] > where I've removed your reviewed-by tag in v7 because I added the ect > node documentation in google.yaml. The empty ect node is required to > be present by the bootloader or the device will boot loop. Can you > re-review that patch? > > The alternative is to remove the empty ect node, and the binding > documentation for it and add your Reviewed-by tag back again. But then > an upstream kernel won't boot 'out the box' on a pixel 6 which seems > less than ideal default behaviour. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-12-12 19:38 UTC|newest] Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-12-11 16:23 [PATCH v7 00/16] Add minimal Tensor/GS101 SoC support and Oriole/Pixel6 board Peter Griffin 2023-12-11 16:23 ` Peter Griffin 2023-12-11 16:23 ` [PATCH v7 01/16] dt-bindings: watchdog: Document Google gs101 watchdog bindings Peter Griffin 2023-12-11 16:23 ` Peter Griffin 2023-12-12 19:39 ` (subset) " Krzysztof Kozlowski 2023-12-12 19:39 ` Krzysztof Kozlowski 2023-12-11 16:23 ` [PATCH v7 02/16] dt-bindings: arm: google: Add bindings for Google ARM platforms Peter Griffin 2023-12-11 16:23 ` Peter Griffin 2023-12-13 14:32 ` Rob Herring 2023-12-13 14:32 ` Rob Herring 2023-12-13 14:34 ` Peter Griffin 2023-12-13 14:34 ` Peter Griffin 2023-12-13 19:16 ` (subset) " Krzysztof Kozlowski 2023-12-13 19:16 ` Krzysztof Kozlowski 2023-12-11 16:23 ` [PATCH v7 03/16] dt-bindings: serial: samsung: Add google-gs101-uart compatible Peter Griffin 2023-12-11 16:23 ` Peter Griffin 2023-12-12 19:39 ` (subset) " Krzysztof Kozlowski 2023-12-12 19:39 ` Krzysztof Kozlowski 2023-12-11 16:23 ` [PATCH v7 04/16] dt-bindings: serial: samsung: Make samsung,uart-fifosize a required property Peter Griffin 2023-12-11 16:23 ` Peter Griffin 2023-12-12 19:39 ` (subset) " Krzysztof Kozlowski 2023-12-12 19:39 ` Krzysztof Kozlowski 2023-12-11 16:23 ` [PATCH v7 05/16] dt-bindings: soc: samsung: usi: add google,gs101-usi compatible Peter Griffin 2023-12-11 16:23 ` Peter Griffin 2023-12-12 19:39 ` (subset) " Krzysztof Kozlowski 2023-12-12 19:39 ` Krzysztof Kozlowski 2023-12-11 16:23 ` [PATCH v7 06/16] dt-bindings: clock: google,gs101: fix incorrect numbering and DGB suffix Peter Griffin 2023-12-11 16:23 ` Peter Griffin 2023-12-11 16:36 ` André Draszik 2023-12-11 16:36 ` André Draszik 2023-12-11 22:38 ` Sam Protsenko 2023-12-11 22:38 ` Sam Protsenko 2023-12-11 23:57 ` Chanwoo Choi 2023-12-11 23:57 ` Chanwoo Choi 2023-12-12 19:39 ` (subset) " Krzysztof Kozlowski 2023-12-12 19:39 ` Krzysztof Kozlowski 2023-12-11 16:23 ` [PATCH v7 07/16] clk: samsung: clk-pll: Add support for pll_{0516,0517,518} Peter Griffin 2023-12-11 16:23 ` Peter Griffin 2023-12-12 19:39 ` (subset) " Krzysztof Kozlowski 2023-12-12 19:39 ` Krzysztof Kozlowski 2023-12-11 16:23 ` [PATCH v7 08/16] clk: samsung: clk-gs101: Add cmu_top, cmu_misc and cmu_apm support Peter Griffin 2023-12-11 16:42 ` Rob Herring 2023-12-11 16:42 ` Rob Herring 2023-12-11 19:46 ` Peter Griffin 2023-12-11 19:46 ` Peter Griffin 2023-12-12 19:38 ` Krzysztof Kozlowski [this message] 2023-12-12 19:38 ` Krzysztof Kozlowski 2023-12-12 19:43 ` Peter Griffin 2023-12-12 19:43 ` Peter Griffin 2023-12-12 19:39 ` (subset) " Krzysztof Kozlowski 2023-12-12 19:39 ` Krzysztof Kozlowski 2023-12-11 16:23 ` [PATCH v7 09/16] pinctrl: samsung: Add gs101 SoC pinctrl configuration Peter Griffin 2023-12-11 16:23 ` Peter Griffin 2023-12-11 21:02 ` Linus Walleij 2023-12-11 21:02 ` Linus Walleij 2023-12-12 19:17 ` (subset) " Krzysztof Kozlowski 2023-12-12 19:17 ` Krzysztof Kozlowski 2023-12-13 16:24 ` Alim Akhtar 2023-12-13 16:24 ` Alim Akhtar 2023-12-11 16:23 ` [PATCH v7 10/16] watchdog: s3c2410_wdt: Add support for WTCON register DBGACK_MASK bit Peter Griffin 2023-12-11 16:23 ` Peter Griffin 2023-12-13 16:32 ` Alim Akhtar 2023-12-13 16:32 ` Alim Akhtar 2023-12-13 19:16 ` (subset) " Krzysztof Kozlowski 2023-12-13 19:16 ` Krzysztof Kozlowski 2023-12-11 16:23 ` [PATCH v7 11/16] watchdog: s3c2410_wdt: Update QUIRK macros to use BIT macro Peter Griffin 2023-12-11 16:23 ` Peter Griffin 2023-12-13 16:34 ` Alim Akhtar 2023-12-13 16:34 ` Alim Akhtar 2023-12-13 19:13 ` Peter Griffin 2023-12-13 19:13 ` Peter Griffin 2023-12-13 19:19 ` Krzysztof Kozlowski 2023-12-13 19:19 ` Krzysztof Kozlowski 2023-12-13 19:16 ` (subset) " Krzysztof Kozlowski 2023-12-13 19:16 ` Krzysztof Kozlowski 2023-12-11 16:23 ` [PATCH v7 12/16] watchdog: s3c2410_wdt: Add support for Google gs101 SoC Peter Griffin 2023-12-11 16:23 ` Peter Griffin 2023-12-12 21:18 ` Guenter Roeck 2023-12-12 21:18 ` Guenter Roeck 2023-12-13 16:42 ` Alim Akhtar 2023-12-13 16:42 ` Alim Akhtar 2023-12-13 19:14 ` Krzysztof Kozlowski 2023-12-13 19:14 ` Krzysztof Kozlowski 2023-12-13 19:16 ` (subset) " Krzysztof Kozlowski 2023-12-13 19:16 ` Krzysztof Kozlowski 2023-12-11 16:23 ` [PATCH v7 13/16] tty: serial: samsung: Add gs101 compatible and common fifoszdt_serial_drv_data Peter Griffin 2023-12-11 16:23 ` Peter Griffin 2023-12-12 19:39 ` (subset) " Krzysztof Kozlowski 2023-12-12 19:39 ` Krzysztof Kozlowski 2023-12-13 16:44 ` Alim Akhtar 2023-12-13 16:44 ` Alim Akhtar 2023-12-11 16:23 ` [PATCH v7 14/16] arm64: dts: exynos: google: Add initial Google gs101 SoC support Peter Griffin 2023-12-11 16:23 ` Peter Griffin 2023-12-13 19:16 ` (subset) " Krzysztof Kozlowski 2023-12-13 19:16 ` Krzysztof Kozlowski 2023-12-11 16:23 ` [PATCH v7 15/16] arm64: dts: exynos: google: Add initial Oriole/pixel 6 board support Peter Griffin 2023-12-11 16:23 ` Peter Griffin 2023-12-13 16:59 ` Alim Akhtar 2023-12-13 16:59 ` Alim Akhtar 2023-12-13 19:16 ` (subset) " Krzysztof Kozlowski 2023-12-13 19:16 ` Krzysztof Kozlowski 2023-12-11 16:23 ` [PATCH v7 16/16] MAINTAINERS: add entry for Google Tensor SoC Peter Griffin 2023-12-11 16:23 ` Peter Griffin 2023-12-13 17:00 ` Alim Akhtar 2023-12-13 17:00 ` Alim Akhtar 2023-12-13 19:16 ` (subset) " Krzysztof Kozlowski 2023-12-13 19:16 ` Krzysztof Kozlowski 2023-12-21 17:41 ` [PATCH v7 00/16] Add minimal Tensor/GS101 SoC support and Oriole/Pixel6 board patchwork-bot+linux-soc 2023-12-22 12:01 ` patchwork-bot+linux-soc
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=d23cc32c-8a5b-48aa-be4d-608fbbb9ac3a@linaro.org \ --to=krzysztof.kozlowski@linaro.org \ --cc=alim.akhtar@samsung.com \ --cc=andre.draszik@linaro.org \ --cc=arnd@arndb.de \ --cc=catalin.marinas@arm.com \ --cc=conor+dt@kernel.org \ --cc=cw00.choi@samsung.com \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=jirislaby@kernel.org \ --cc=kernel-team@android.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=linux-watchdog@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=mturquette@baylibre.com \ --cc=olof@lixom.net \ --cc=peter.griffin@linaro.org \ --cc=robh+dt@kernel.org \ --cc=s.nawrocki@samsung.com \ --cc=saravanak@google.com \ --cc=sboyd@kernel.org \ --cc=semen.protsenko@linaro.org \ --cc=soc@kernel.org \ --cc=tomasz.figa@gmail.com \ --cc=tudor.ambarus@linaro.org \ --cc=will@kernel.org \ --cc=willmcvicker@google.com \ --cc=wim@linux-watchdog.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.