From: Lukasz Stelmach <l.stelmach@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>, Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, "Kukjin Kim" <kgene@kernel.org>,
"Russell King" <linux@armlinux.org.uk>,
netdev@vger.kernel.org, "Heiner Kallweit" <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Andrew Lunn" <andrew@lunn.ch>,
"Jakub Kicinski" <kuba@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org,
"Marek Szyprowski" <m.szyprowski@samsung.com>,
"Bartłomiej Żolnierkiewicz" <b.zolnierkie@samsung.com>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
jim.cromie@gmail.com, "Rob Herring" <robh+dt@kernel.org>
Subject: Re: [PATCH v3 2/5] dt-bindings: net: Add bindings for AX88796C SPI Ethernet Adapter
Date: Fri, 23 Oct 2020 20:21:25 +0200 [thread overview]
Message-ID: <dleftjwnzgyfa2.fsf%l.stelmach@samsung.com> (raw)
In-Reply-To: <CAJKOXPeNhXrBa0ZK-k37uhs5izukrhHN-rkxgsjiQBHCMmZs7g@mail.gmail.com> (Krzysztof Kozlowski's message of "Fri, 23 Oct 2020 18:27:18 +0200")
[-- Attachment #1: Type: text/plain, Size: 1770 bytes --]
It was <2020-10-23 pią 18:27>, when Krzysztof Kozlowski wrote:
> On Fri, 23 Oct 2020 at 18:05, Rob Herring <robh@kernel.org> wrote:
>>
>> On Wed, 21 Oct 2020 23:49:07 +0200, Łukasz Stelmach wrote:
>> > Add bindings for AX88796C SPI Ethernet Adapter.
>> >
>> > Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
>> > ---
>> > .../bindings/net/asix,ax88796c.yaml | 69 +++++++++++++++++++
>> > 1 file changed, 69 insertions(+)
>> > create mode 100644 Documentation/devicetree/bindings/net/asix,ax88796c.yaml
>> >
>>
>>
>> My bot found errors running 'make dt_binding_check' on your patch:
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> ./Documentation/devicetree/bindings/net/asix,ax88796c.yaml: $id:
>> relative path/filename doesn't match actual path or filename
>> expected:
>> https://protect2.fireeye.com/v1/url?k=b676d09f-eb1194b9-b6775bd0-0cc47a31384a-e1cc7da4db18c501&q=1&e=ea7ae062-8c39-4ee3-82fa-37d28062f086&u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fnet%2Fasix%2Cax88796c.yaml%23
>> Documentation/devicetree/bindings/net/asix,ax88796c.example.dts:20:18:
>> fatal error: dt-bindings/interrupt-controller/gpio.h: No such file
>> or directory
Fixed.
> Łukasz,
>
> So you really did not compile/test these patches... It's the second
> build failure in the patchset. All sent patches should at least be
> compiled on the latest kernel, if you cannot test them. However this
> patchset should be testable - Artik5 should boot on mainline kernel
Yes, I messed up a bit. I made moved some code around without changing
it just before sending and I didn't run dt_binding_check. My fault, I am
sorry.
--
Łukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Lukasz Stelmach <l.stelmach@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>, Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"Andrew Lunn" <andrew@lunn.ch>,
jim.cromie@gmail.com, netdev@vger.kernel.org,
"Bartłomiej Żolnierkiewicz" <b.zolnierkie@samsung.com>,
"Russell King" <linux@armlinux.org.uk>,
"Rob Herring" <robh+dt@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Kukjin Kim" <kgene@kernel.org>,
"Jakub Kicinski" <kuba@kernel.org>,
"Marek Szyprowski" <m.szyprowski@samsung.com>,
"David S. Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org,
"Heiner Kallweit" <hkallweit1@gmail.com>
Subject: Re: [PATCH v3 2/5] dt-bindings: net: Add bindings for AX88796C SPI Ethernet Adapter
Date: Fri, 23 Oct 2020 20:21:25 +0200 [thread overview]
Message-ID: <dleftjwnzgyfa2.fsf%l.stelmach@samsung.com> (raw)
In-Reply-To: <CAJKOXPeNhXrBa0ZK-k37uhs5izukrhHN-rkxgsjiQBHCMmZs7g@mail.gmail.com> (Krzysztof Kozlowski's message of "Fri, 23 Oct 2020 18:27:18 +0200")
[-- Attachment #1.1: Type: text/plain, Size: 1770 bytes --]
It was <2020-10-23 pią 18:27>, when Krzysztof Kozlowski wrote:
> On Fri, 23 Oct 2020 at 18:05, Rob Herring <robh@kernel.org> wrote:
>>
>> On Wed, 21 Oct 2020 23:49:07 +0200, Łukasz Stelmach wrote:
>> > Add bindings for AX88796C SPI Ethernet Adapter.
>> >
>> > Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
>> > ---
>> > .../bindings/net/asix,ax88796c.yaml | 69 +++++++++++++++++++
>> > 1 file changed, 69 insertions(+)
>> > create mode 100644 Documentation/devicetree/bindings/net/asix,ax88796c.yaml
>> >
>>
>>
>> My bot found errors running 'make dt_binding_check' on your patch:
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> ./Documentation/devicetree/bindings/net/asix,ax88796c.yaml: $id:
>> relative path/filename doesn't match actual path or filename
>> expected:
>> https://protect2.fireeye.com/v1/url?k=b676d09f-eb1194b9-b6775bd0-0cc47a31384a-e1cc7da4db18c501&q=1&e=ea7ae062-8c39-4ee3-82fa-37d28062f086&u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fnet%2Fasix%2Cax88796c.yaml%23
>> Documentation/devicetree/bindings/net/asix,ax88796c.example.dts:20:18:
>> fatal error: dt-bindings/interrupt-controller/gpio.h: No such file
>> or directory
Fixed.
> Łukasz,
>
> So you really did not compile/test these patches... It's the second
> build failure in the patchset. All sent patches should at least be
> compiled on the latest kernel, if you cannot test them. However this
> patchset should be testable - Artik5 should boot on mainline kernel
Yes, I messed up a bit. I made moved some code around without changing
it just before sending and I didn't run dt_binding_check. My fault, I am
sorry.
--
Łukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-23 18:22 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20201021214930eucas1p1cf406b35bbe4b643db287643e4a5b85b@eucas1p1.samsung.com>
2020-10-21 21:49 ` [PATCH v3 0/5] AX88796C SPI Ethernet Adapter Łukasz Stelmach
2020-10-21 21:49 ` Łukasz Stelmach
[not found] ` <CGME20201021214933eucas1p26e8ee82f237e977e8b3324145a929a1a@eucas1p2.samsung.com>
2020-10-21 21:49 ` [PATCH v3 1/5] dt-bindings: vendor-prefixes: Add asix prefix Łukasz Stelmach
2020-10-21 21:49 ` Łukasz Stelmach
2020-10-22 6:53 ` Krzysztof Kozlowski
2020-10-22 6:53 ` Krzysztof Kozlowski
2020-10-26 15:10 ` Rob Herring
2020-10-26 15:10 ` Rob Herring
[not found] ` <CGME20201021214933eucas1p152c8fc594793aca56a1cbf008f8415a4@eucas1p1.samsung.com>
2020-10-21 21:49 ` [PATCH v3 2/5] dt-bindings: net: Add bindings for AX88796C SPI Ethernet Adapter Łukasz Stelmach
2020-10-21 21:49 ` Łukasz Stelmach
2020-10-22 6:55 ` Krzysztof Kozlowski
2020-10-22 6:55 ` Krzysztof Kozlowski
2020-10-23 16:05 ` Rob Herring
2020-10-23 16:05 ` Rob Herring
2020-10-23 16:27 ` Krzysztof Kozlowski
2020-10-23 16:27 ` Krzysztof Kozlowski
[not found] ` <CGME20201023182136eucas1p28518b30e23ae4204840c3d5526bd3400@eucas1p2.samsung.com>
2020-10-23 18:21 ` Lukasz Stelmach [this message]
2020-10-23 18:21 ` Lukasz Stelmach
[not found] ` <CGME20201021214933eucas1p2fd4e5ccc172f3e22fe0d7009d8b2742d@eucas1p2.samsung.com>
2020-10-21 21:49 ` [PATCH v3 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver Łukasz Stelmach
2020-10-21 21:49 ` Łukasz Stelmach
2020-10-22 0:45 ` kernel test robot
2020-10-22 0:45 ` kernel test robot
2020-10-22 7:15 ` Marek Szyprowski
2020-10-22 7:15 ` Marek Szyprowski
[not found] ` <CGME20201022100133eucas1p132ef97a9ac767bd357f50034c47d6d1a@eucas1p1.samsung.com>
2020-10-22 10:01 ` Lukasz Stelmach
2020-10-22 10:01 ` Lukasz Stelmach
[not found] ` <CGME20201021214934eucas1p273214a19e3a775512ab3090d243260db@eucas1p2.samsung.com>
2020-10-21 21:49 ` [PATCH v3 4/5] ARM: dts: exynos: Add Ethernet to Artik 5 board Łukasz Stelmach
2020-10-21 21:49 ` Łukasz Stelmach
[not found] ` <CGME20201021214934eucas1p2d4acc48c40f37763c276d8d275fa9c15@eucas1p2.samsung.com>
2020-10-21 21:49 ` [PATCH v3 5/5] ARM: defconfig: Enable ax88796c driver Łukasz Stelmach
2020-10-21 21:49 ` Łukasz Stelmach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dleftjwnzgyfa2.fsf%l.stelmach@samsung.com \
--to=l.stelmach@samsung.com \
--cc=andrew@lunn.ch \
--cc=b.zolnierkie@samsung.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=hkallweit1@gmail.com \
--cc=jim.cromie@gmail.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.