Re: [PATCH v3 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

From: Lukasz Stelmach <l.stelmach@samsung.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
	jim.cromie@gmail.com, "Heiner Kallweit" <hkallweit1@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Kukjin Kim" <kgene@kernel.org>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Russell King" <linux@armlinux.org.uk>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org,
	"Bartłomiej Żolnierkiewicz" <b.zolnierkie@samsung.com>
Subject: Re: [PATCH v3 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver
Date: Thu, 22 Oct 2020 12:01:23 +0200	[thread overview]
Message-ID: <dleftjzh4ezij0.fsf%l.stelmach@samsung.com> (raw)
In-Reply-To: <633bbf18-1aec-4b2a-7967-898cde1930aa@samsung.com> (Marek Szyprowski's message of "Thu, 22 Oct 2020 09:15:50 +0200")

[-- Attachment #1: Type: text/plain, Size: 2291 bytes --]

It was <2020-10-22 czw 09:15>, when Marek Szyprowski wrote:
> On 21.10.2020 23:49, Łukasz Stelmach wrote:
>> ASIX AX88796[1] is a versatile ethernet adapter chip, that can be
>> connected to a CPU with a 8/16-bit bus or with an SPI. This driver
>> supports SPI connection.
>>
>> The driver has been ported from the vendor kernel for ARTIK5[2]
>> boards. Several changes were made to adapt it to the current kernel
>> which include:
>>
>> + updated DT configuration,
>> + clock configuration moved to DT,
>> + new timer, ethtool and gpio APIs,
>> + dev_* instead of pr_* and custom printk() wrappers,
>> + removed awkward vendor power managemtn.
>>
>> [1] https://www.asix.com.tw/products.php?op=pItemdetail&PItemID=104;65;86&PLine=65
>> [2] https://git.tizen.org/cgit/profile/common/platform/kernel/linux-3.10-artik/
>>
>> The other ax88796 driver is for NE2000 compatible AX88796L chip. These
>> chips are not compatible. Hence, two separate drivers are required.
>>
>> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
>
> coś zaszalałeś, jak dobry koreański kod - push bez kompilacji ;)
>
> drivers/net/ethernet/asix/ax88796c_main.c:758:13: error: static 
> declaration of ‘ax88796c_set_csums’ follows non-static declaration
>   static void ax88796c_set_csums(struct ax88796c_device *ax_local)
>               ^
> In file included from drivers/net/ethernet/asix/ax88796c_main.c:12:0:
> drivers/net/ethernet/asix/ax88796c_ioctl.h:24:6: note: previous 
> declaration of ‘ax88796c_set_csums’ was here
>   void ax88796c_set_csums(struct ax88796c_device *ax_local);
>        ^
> scripts/Makefile.build:283: recipe for target 
> 'drivers/net/ethernet/asix/ax88796c_main.o' failed
> make[4]: *** [drivers/net/ethernet/asix/ax88796c_main.o] Error 1
> scripts/Makefile.build:500: recipe for target 
> 'drivers/net/ethernet/asix' failed
> make[3]: *** [drivers/net/ethernet/asix] Error 2
> scripts/Makefile.build:500: recipe for target 'drivers/net/ethernet' failed
> make[2]: *** [drivers/net/ethernet] Error 2
> scripts/Makefile.build:500: recipe for target 'drivers/net' failed
> make[1]: *** [drivers/net] Error 2

Fixed. Thanks.

-- 
Łukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]