dm-devel.redhat.com archive mirror
 help / color / mirror / Atom feed
* [dm-devel] [PATCH] multipathd.socket: add missing conditions from service unit
@ 2021-09-24  9:34 Luca BRUNO
  2021-09-24 12:27 ` Martin Wilck
  0 siblings, 1 reply; 2+ messages in thread
From: Luca BRUNO @ 2021-09-24  9:34 UTC (permalink / raw)
  To: dm-devel; +Cc: mwilck

This aligns 'multipathd' socket and service units, by adding the
start conditions that are set on the service but not on the socket.
It should help avoiding situations where the socket unit ends up
marked as failed after hitting its retry-limit.

Fixes: https://github.com/opensvc/multipath-tools/issues/15
Signed-off-by: Luca BRUNO <luca.bruno@coreos.com>
---
 multipathd/multipathd.socket | 3 +++
 1 file changed, 3 insertions(+)

diff --git multipathd/multipathd.socket multipathd/multipathd.socket
index 0ed4a1f7..c777e5e3 100644
--- multipathd/multipathd.socket
+++ multipathd/multipathd.socket
@@ -1,6 +1,9 @@
 [Unit]
 Description=multipathd control socket
 DefaultDependencies=no
+ConditionKernelCommandLine=!nompath
+ConditionKernelCommandLine=!multipath=off
+ConditionVirtualization=!container
 Before=sockets.target
 
 [Socket]
-- 
2.30.2

--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dm-devel] [PATCH] multipathd.socket: add missing conditions from service unit
  2021-09-24  9:34 [dm-devel] [PATCH] multipathd.socket: add missing conditions from service unit Luca BRUNO
@ 2021-09-24 12:27 ` Martin Wilck
  0 siblings, 0 replies; 2+ messages in thread
From: Martin Wilck @ 2021-09-24 12:27 UTC (permalink / raw)
  To: Luca BRUNO, dm-devel

On Fri, 2021-09-24 at 09:34 +0000, Luca BRUNO wrote:
> This aligns 'multipathd' socket and service units, by adding the
> start conditions that are set on the service but not on the socket.
> It should help avoiding situations where the socket unit ends up
> marked as failed after hitting its retry-limit.
> 
> Fixes: https://github.com/opensvc/multipath-tools/issues/15
> Signed-off-by: Luca BRUNO <luca.bruno@coreos.com>
> ---
>  multipathd/multipathd.socket | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git multipathd/multipathd.socket multipathd/multipathd.socket
> index 0ed4a1f7..c777e5e3 100644
> --- multipathd/multipathd.socket
> +++ multipathd/multipathd.socket
> @@ -1,6 +1,9 @@
>  [Unit]
>  Description=multipathd control socket
>  DefaultDependencies=no
> +ConditionKernelCommandLine=!nompath
> +ConditionKernelCommandLine=!multipath=off
> +ConditionVirtualization=!container
>  Before=sockets.target
>  
>  [Socket]

Thanks!

I'll apply this to
https://github.com/openSUSE/multipath-tools/tree/queue

>From there it'll be submitted to the main repo.

Reviewed-by: Martin Wilck <mwilck@suse.com>



--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-24 12:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-24  9:34 [dm-devel] [PATCH] multipathd.socket: add missing conditions from service unit Luca BRUNO
2021-09-24 12:27 ` Martin Wilck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).