dmaengine Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH -next] dmaengine: idxd: fix PCI_MSI build errors
@ 2020-07-14  6:35 Randy Dunlap
  2020-07-14 14:58 ` Dave Jiang
  0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2020-07-14  6:35 UTC (permalink / raw)
  To: LKML, dmaengine; +Cc: Dave Jiang, Vinod Koul

From: Randy Dunlap <rdunlap@infradead.org>

Fix build errors when CONFIG_PCI_MSI is not enabled by making the
driver depend on PCI_MSI:

ld: drivers/dma/idxd/device.o: in function `idxd_mask_msix_vector':
device.c:(.text+0x26f): undefined reference to `pci_msi_mask_irq'
ld: drivers/dma/idxd/device.o: in function `idxd_unmask_msix_vector':
device.c:(.text+0x2af): undefined reference to `pci_msi_unmask_irq'

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Dave Jiang <dave.jiang@intel.com>
Cc: dmaengine@vger.kernel.org
Cc: Vinod Koul <vkoul@kernel.org>
---
 drivers/dma/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- mmotm-2020-0713-1949.orig/drivers/dma/Kconfig
+++ mmotm-2020-0713-1949/drivers/dma/Kconfig
@@ -285,6 +285,7 @@ config INTEL_IDMA64
 config INTEL_IDXD
 	tristate "Intel Data Accelerators support"
 	depends on PCI && X86_64
+	depends on PCI_MSI
 	depends on SBITMAP
 	select DMA_ENGINE
 	help



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] dmaengine: idxd: fix PCI_MSI build errors
  2020-07-14  6:35 [PATCH -next] dmaengine: idxd: fix PCI_MSI build errors Randy Dunlap
@ 2020-07-14 14:58 ` Dave Jiang
  2020-07-15  6:03   ` Vinod Koul
  0 siblings, 1 reply; 3+ messages in thread
From: Dave Jiang @ 2020-07-14 14:58 UTC (permalink / raw)
  To: Vinod Koul; +Cc: Randy Dunlap, LKML, dmaengine



On 7/13/2020 11:35 PM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix build errors when CONFIG_PCI_MSI is not enabled by making the
> driver depend on PCI_MSI:
> 
> ld: drivers/dma/idxd/device.o: in function `idxd_mask_msix_vector':
> device.c:(.text+0x26f): undefined reference to `pci_msi_mask_irq'
> ld: drivers/dma/idxd/device.o: in function `idxd_unmask_msix_vector':
> device.c:(.text+0x2af): undefined reference to `pci_msi_unmask_irq'
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Dave Jiang <dave.jiang@intel.com>
> Cc: dmaengine@vger.kernel.org
> Cc: Vinod Koul <vkoul@kernel.org>

Vinod, I submitted this fix patch last week:
https://patchwork.kernel.org/patch/11649231/

But I think maybe Randy's patch may be more preferable? You can apply this one 
and ignore my submission.

> ---
>   drivers/dma/Kconfig |    1 +
>   1 file changed, 1 insertion(+)
> 
> --- mmotm-2020-0713-1949.orig/drivers/dma/Kconfig
> +++ mmotm-2020-0713-1949/drivers/dma/Kconfig
> @@ -285,6 +285,7 @@ config INTEL_IDMA64
>   config INTEL_IDXD
>   	tristate "Intel Data Accelerators support"
>   	depends on PCI && X86_64
> +	depends on PCI_MSI
>   	depends on SBITMAP
>   	select DMA_ENGINE
>   	help
> 
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] dmaengine: idxd: fix PCI_MSI build errors
  2020-07-14 14:58 ` Dave Jiang
@ 2020-07-15  6:03   ` Vinod Koul
  0 siblings, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2020-07-15  6:03 UTC (permalink / raw)
  To: Dave Jiang; +Cc: Randy Dunlap, LKML, dmaengine

On 14-07-20, 07:58, Dave Jiang wrote:
> 
> 
> On 7/13/2020 11:35 PM, Randy Dunlap wrote:
> > From: Randy Dunlap <rdunlap@infradead.org>
> > 
> > Fix build errors when CONFIG_PCI_MSI is not enabled by making the
> > driver depend on PCI_MSI:
> > 
> > ld: drivers/dma/idxd/device.o: in function `idxd_mask_msix_vector':
> > device.c:(.text+0x26f): undefined reference to `pci_msi_mask_irq'
> > ld: drivers/dma/idxd/device.o: in function `idxd_unmask_msix_vector':
> > device.c:(.text+0x2af): undefined reference to `pci_msi_unmask_irq'
> > 
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > Cc: Dave Jiang <dave.jiang@intel.com>
> > Cc: dmaengine@vger.kernel.org
> > Cc: Vinod Koul <vkoul@kernel.org>
> 
> Vinod, I submitted this fix patch last week:
> https://patchwork.kernel.org/patch/11649231/
> 
> But I think maybe Randy's patch may be more preferable? You can apply this
> one and ignore my submission.

Ok, Applied this one, thanks
-- 
~Vinod

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-14  6:35 [PATCH -next] dmaengine: idxd: fix PCI_MSI build errors Randy Dunlap
2020-07-14 14:58 ` Dave Jiang
2020-07-15  6:03   ` Vinod Koul

dmaengine Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dmaengine/0 dmaengine/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dmaengine dmaengine/ https://lore.kernel.org/dmaengine \
		dmaengine@vger.kernel.org
	public-inbox-index dmaengine

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.dmaengine


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git