[PATCH] dmaengine: sh: rz-dmac: Remove unused rz_dmac_chan.*_word_size

[PATCH] dmaengine: sh: rz-dmac: Remove unused rz_dmac_chan.*_word_size

[Geert Uytterhoeven]

The src_word_size and dst_word_size members of the rz_dmac_chan
structure were never used, so they can be removed.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/dma/sh/rz-dmac.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/dma/sh/rz-dmac.c b/drivers/dma/sh/rz-dmac.c
index 6b62e01ba658ac13..9479f29692d3e3d7 100644
--- a/drivers/dma/sh/rz-dmac.c
+++ b/drivers/dma/sh/rz-dmac.c
@@ -67,8 +67,6 @@ struct rz_dmac_chan {
 	struct rz_dmac_desc *desc;
 	int descs_allocated;
 
-	enum dma_slave_buswidth src_word_size;
-	enum dma_slave_buswidth dst_word_size;
 	dma_addr_t src_per_address;
 	dma_addr_t dst_per_address;
 
@@ -603,9 +601,7 @@ static int rz_dmac_config(struct dma_chan *chan,
 	u32 val;
 
 	channel->src_per_address = config->src_addr;
-	channel->src_word_size = config->src_addr_width;
 	channel->dst_per_address = config->dst_addr;
-	channel->dst_word_size = config->dst_addr_width;
 
 	val = rz_dmac_ds_to_val_mapping(config->dst_addr_width);
 	if (val == CHCFG_DS_INVALID)
-- 
2.34.1

RE: [PATCH] dmaengine: sh: rz-dmac: Remove unused rz_dmac_chan.*_word_size

[Biju Das]

Hi Geert,

Thanks for the patch.

> -----Original Message-----
> From: Geert Uytterhoeven <geert+renesas@glider.be>
> Sent: Monday, March 27, 2023 10:49 AM
> To: Vinod Koul <vkoul@kernel.org>; Biju Das <biju.das.jz@bp.renesas.com>
> Cc: dmaengine@vger.kernel.org; linux-renesas-soc@vger.kernel.org; Geert
> Uytterhoeven <geert+renesas@glider.be>
> Subject: [PATCH] dmaengine: sh: rz-dmac: Remove unused
> rz_dmac_chan.*_word_size
> 
> The src_word_size and dst_word_size members of the rz_dmac_chan structure
> were never used, so they can be removed.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>


Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>

Cheers,
Biju
> ---
>  drivers/dma/sh/rz-dmac.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/dma/sh/rz-dmac.c b/drivers/dma/sh/rz-dmac.c index
> 6b62e01ba658ac13..9479f29692d3e3d7 100644
> --- a/drivers/dma/sh/rz-dmac.c
> +++ b/drivers/dma/sh/rz-dmac.c
> @@ -67,8 +67,6 @@ struct rz_dmac_chan {
>  	struct rz_dmac_desc *desc;
>  	int descs_allocated;
> 
> -	enum dma_slave_buswidth src_word_size;
> -	enum dma_slave_buswidth dst_word_size;
>  	dma_addr_t src_per_address;
>  	dma_addr_t dst_per_address;
> 
> @@ -603,9 +601,7 @@ static int rz_dmac_config(struct dma_chan *chan,
>  	u32 val;
> 
>  	channel->src_per_address = config->src_addr;
> -	channel->src_word_size = config->src_addr_width;
>  	channel->dst_per_address = config->dst_addr;
> -	channel->dst_word_size = config->dst_addr_width;
> 
>  	val = rz_dmac_ds_to_val_mapping(config->dst_addr_width);
>  	if (val == CHCFG_DS_INVALID)
> --
> 2.34.1

Re: [PATCH] dmaengine: sh: rz-dmac: Remove unused rz_dmac_chan.*_word_size

[Vinod Koul]

On 27-03-23, 11:48, Geert Uytterhoeven wrote:
> The src_word_size and dst_word_size members of the rz_dmac_chan
> structure were never used, so they can be removed.

Applied, thanks

-- 
~Vinod