From: Vinod Koul <vkoul@kernel.org>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
dmaengine@vger.kernel.org,
Chris Brandt <chris.brandt@renesas.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v4 2/4] drivers: dma: sh: Add DMAC driver for RZ/G2L SoC
Date: Tue, 27 Jul 2021 18:10:15 +0530 [thread overview]
Message-ID: <YP/+r4HzCaAZbUWh@matsya> (raw)
In-Reply-To: <20210719092535.4474-3-biju.das.jz@bp.renesas.com>
On 19-07-21, 10:25, Biju Das wrote:
> +struct rz_dmac_chan {
> + struct virt_dma_chan vc;
> + void __iomem *ch_base;
> + void __iomem *ch_cmn_base;
> + unsigned int index;
> + int irq;
> + struct rz_dmac_desc *desc;
> + int descs_allocated;
> +
> + enum dma_slave_buswidth src_word_size;
> + enum dma_slave_buswidth dst_word_size;
> + dma_addr_t src_per_address;
> + dma_addr_t dst_per_address;
> +
> + u32 chcfg;
> + u32 chctrl;
> + int mid_rid;
> +
> + struct list_head ld_free;
> + struct list_head ld_queue;
> + struct list_head ld_active;
> +
> + struct {
> + struct rz_lmdesc *base;
> + struct rz_lmdesc *head;
> + struct rz_lmdesc *tail;
> + int valid;
> + dma_addr_t base_dma;
> + } lmdesc;
should this be not part of rz_dmac_desc than channel?
> +static int rz_dmac_config(struct dma_chan *chan,
> + struct dma_slave_config *config)
> +{
> + struct rz_dmac_chan *channel = to_rz_dmac_chan(chan);
> + u32 *ch_cfg;
> +
> + channel->src_per_address = config->src_addr;
> + channel->src_word_size = config->src_addr_width;
> + channel->dst_per_address = config->dst_addr;
> + channel->dst_word_size = config->dst_addr_width;
> +
> + if (config->peripheral_config) {
> + ch_cfg = config->peripheral_config;
> + channel->chcfg = *ch_cfg;
> + }
can you explain what this the ch_cfg here and what does it represent?
--
~Vinod
next prev parent reply other threads:[~2021-07-27 12:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-19 9:25 [PATCH v4 0/4] Add RZ/G2L DMAC support Biju Das
2021-07-19 9:25 ` [PATCH v4 2/4] drivers: dma: sh: Add DMAC driver for RZ/G2L SoC Biju Das
2021-07-27 7:56 ` Biju Das
2021-07-27 12:40 ` Vinod Koul [this message]
2021-07-27 13:45 ` Biju Das
2021-07-28 6:20 ` Vinod Koul
2021-07-28 7:00 ` Biju Das
2021-07-28 11:05 ` Vinod Koul
2021-07-28 11:58 ` Biju Das
2021-07-28 12:34 ` Geert Uytterhoeven
2021-07-28 12:42 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YP/+r4HzCaAZbUWh@matsya \
--to=vkoul@kernel.org \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=chris.brandt@renesas.com \
--cc=dmaengine@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).