DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Xing, Beilei" <beilei.xing@intel.com>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>,
	"Doherty, Declan" <declan.doherty@intel.com>
Cc: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
	"Byrne, Stephen1" <stephen1.byrne@intel.com>,
	"Zhang, Helin" <helin.zhang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v5 11/14] net/i40e: display Flow Director packet
Date: Wed, 15 Jan 2020 10:58:33 +0000
Message-ID: <12bc3749-ea29-ec14-b756-63c7e18702de@intel.com> (raw)
In-Reply-To: <DM6PR11MB39146068DB2149656D868831EF370@DM6PR11MB3914.namprd11.prod.outlook.com>

On 1/15/2020 9:18 AM, Iremonger, Bernard wrote:
> Hi Ferruh,
> 
>> -----Original Message-----
>> From: Yigit, Ferruh <ferruh.yigit@intel.com>
>> Sent: Tuesday, January 14, 2020 6:53 PM
>> To: Iremonger, Bernard <bernard.iremonger@intel.com>; dev@dpdk.org;
>> Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
>> Doherty, Declan <declan.doherty@intel.com>
>> Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>; Byrne, Stephen1
>> <stephen1.byrne@intel.com>; Zhang, Helin <helin.zhang@intel.com>
>> Subject: Re: [dpdk-dev] [PATCH v5 11/14] net/i40e: display Flow Director
>> packet
>>
>> On 1/14/2020 1:55 PM, Bernard Iremonger wrote:
>>> include rte_config.h in i40e_fdir.c
>>> In debug mode call rte_hexdump in i40e_flow_fdir_construct_pkt() and
>>> in i40e_fdir_construct_pkt()
>>>
>>> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
>>> ---
>>>  drivers/net/i40e/i40e_fdir.c | 12 ++++++++++--
>>>  1 file changed, 10 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/net/i40e/i40e_fdir.c
>>> b/drivers/net/i40e/i40e_fdir.c index 5f85703..67bb28c 100644
>>> --- a/drivers/net/i40e/i40e_fdir.c
>>> +++ b/drivers/net/i40e/i40e_fdir.c
>>> @@ -21,6 +21,10 @@
>>>  #include <rte_tcp.h>
>>>  #include <rte_sctp.h>
>>>  #include <rte_hash_crc.h>
>>> +#include <rte_config.h>
>>> +#ifdef RTE_LIBRTE_I40E_DEBUG_FD
>>> +#include <rte_hexdump.h>
>>> +#endif
>>>
>>>  #include "i40e_logs.h"
>>>  #include "base/i40e_type.h"
>>> @@ -954,7 +958,9 @@ i40e_fdir_construct_pkt(struct i40e_pf *pf,
>>>   &fdir_input->flow_ext.flexbytes[dst],
>>>   size * sizeof(uint16_t));
>>>  }
>>> -
>>> +#ifdef RTE_LIBRTE_I40E_DEBUG_FD
>>> +rte_hexdump(stdout, NULL, raw_pkt, len); #endif
>>>  return 0;
>>>  }
>>>
>>> @@ -1415,7 +1421,9 @@ i40e_flow_fdir_construct_pkt(struct i40e_pf *pf,
>>>   &fdir_input->flow_ext.flexbytes[dst],
>>>   size * sizeof(uint16_t));
>>>  }
>>> -
>>> +#ifdef RTE_LIBRTE_I40E_DEBUG_FD
>>> +rte_hexdump(stdout, NULL, raw_pkt, len); #endif
>>>  return 0;
>>>  }
>>>
>>>
>>
>> Hi Bernard,
>>
>> These are not data path functions, right?
> This code is only used when adding flow rules,  so not in data path.
> 
>  If so instead of adding new config option, can we add dynamic debugging for it?
> Adding new config option seems ok to me,  why change to dynamic debugging?
> 

Compile time options are OK for developer but bad for deployment, when you are
deploying your product you have to disable this config option, and on the target
platform there if a problem occurs there won't be any way to enable the debug to
see what is happening.
So it is useful only on the machine that you are both compiling and running
application, even that case it is a trouble to terminate application, re-compile
it and run again, most probably same loop again to turn off the debug back.

Also it is bad for testing, if you want to do the all code path, someone needs
to test both enabling and disabling this config option. If not, it is possible
by time enabling this config option even won't compile and nobody will detect it.

Since we already have dynamic log support, why not add a new logtype, lets say
"pmd.net.i40e.fd" and have ability to enable/disable it without terminating app?



  reply index

Thread overview: 134+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-10 12:57 [dpdk-dev] [PATCH 0/9] net/i40e: ESP support Bernard Iremonger
2019-12-10 12:57 ` [dpdk-dev] [PATCH 1/9] app/testpmd: parse flow command line for ESP Bernard Iremonger
2019-12-10 21:12   ` Ori Kam
2019-12-11  9:24     ` Iremonger, Bernard
2019-12-10 12:57 ` [dpdk-dev] [PATCH 2/9] app/testpmd: dump Rx and Tx mbuf Bernard Iremonger
2019-12-10 12:57 ` [dpdk-dev] [PATCH 3/9] net/i40e: improve RSS debug Bernard Iremonger
2019-12-10 12:57 ` [dpdk-dev] [PATCH 4/9] net/i40e: handle ESP tunnel Bernard Iremonger
2019-12-10 12:57 ` [dpdk-dev] [PATCH 5/9] net/i40e: process ESP flows Bernard Iremonger
2019-12-10 12:57 ` [dpdk-dev] [PATCH 6/9] net/i40e: display Flow Director packet Bernard Iremonger
2019-12-10 12:57 ` [dpdk-dev] [PATCH 7/9] librte_ethdev: add ESP and AH flow types to RSS Bernard Iremonger
2019-12-10 18:27   ` Stephen Hemminger
2019-12-10 12:57 ` [dpdk-dev] [PATCH 8/9] doc: release note for ESP Bernard Iremonger
2019-12-10 12:57 ` [dpdk-dev] [PATCH 9/9] doc: update i40e user guide Bernard Iremonger
2019-12-17 10:15 ` [dpdk-dev] [PATCH v2 00/10] net/i40e: ESP support Bernard Iremonger
2020-01-09 12:16   ` [dpdk-dev] [PATCH v3 0/9] " Bernard Iremonger
2020-01-10 15:20     ` [dpdk-dev] [PATCH v4 00/14] " Bernard Iremonger
2020-01-14 13:55       ` [dpdk-dev] [PATCH v5 " Bernard Iremonger
2020-01-15  1:47         ` Zhang, Qi Z
2020-01-14 13:55       ` [dpdk-dev] [PATCH v5 01/14] app/testpmd: parse flow command line for ESP Bernard Iremonger
2020-01-14 19:03         ` Ferruh Yigit
2020-01-15  9:08           ` Iremonger, Bernard
2020-01-15 15:53         ` [dpdk-dev] [PATCH v6 00/13] net/i40e: ESP support Bernard Iremonger
2020-01-16 12:44           ` [dpdk-dev] [PATCH v7 00/10] " Bernard Iremonger
2020-01-16 17:42             ` Ferruh Yigit
2020-01-21 16:10               ` Iremonger, Bernard
2020-01-16 12:44           ` [dpdk-dev] [PATCH v7 01/10] app/testpmd: parse flow command line for ESP Bernard Iremonger
2020-01-16 12:44           ` [dpdk-dev] [PATCH v7 02/10] app/testpmd: improve debug Bernard Iremonger
2020-01-16 13:46             ` Ananyev, Konstantin
2020-01-16 12:44           ` [dpdk-dev] [PATCH v7 03/10] net/i40e: improve RSS debug Bernard Iremonger
2020-01-16 12:44           ` [dpdk-dev] [PATCH v7 04/10] net/i40e: handle ESP tunnel Bernard Iremonger
2020-01-16 12:44           ` [dpdk-dev] [PATCH v7 05/10] net/i40e: support ipsec-ah profile Bernard Iremonger
2020-01-16 12:44           ` [dpdk-dev] [PATCH v7 06/10] net/i40e: support ESP in customized code Bernard Iremonger
2020-01-16 12:44           ` [dpdk-dev] [PATCH v7 07/10] net/i40e: support ESP flows Bernard Iremonger
2020-01-16 12:44           ` [dpdk-dev] [PATCH v7 08/10] net/i40e: support ESP in Flow Director Bernard Iremonger
2020-01-16 12:44           ` [dpdk-dev] [PATCH v7 09/10] config: add debug to I40E " Bernard Iremonger
2020-01-16 12:44           ` [dpdk-dev] [PATCH v7 10/10] net/i40e: display Flow Director packet Bernard Iremonger
2020-01-15 15:53         ` [dpdk-dev] [PATCH v6 01/13] app/testpmd: parse flow command line for ESP Bernard Iremonger
2020-01-15 15:53         ` [dpdk-dev] [PATCH v6 02/13] app/testpmd: improve debug Bernard Iremonger
2020-01-15 15:53         ` [dpdk-dev] [PATCH v6 03/13] app/testpmd: dump Rx and Tx mbuf Bernard Iremonger
2020-01-15 16:28           ` Ferruh Yigit
2020-01-15 16:52             ` Iremonger, Bernard
2020-01-15 15:53         ` [dpdk-dev] [PATCH v6 04/13] net/i40e: improve RSS debug Bernard Iremonger
2020-01-15 15:53         ` [dpdk-dev] [PATCH v6 05/13] net/i40e: handle ESP tunnel Bernard Iremonger
2020-01-15 15:53         ` [dpdk-dev] [PATCH v6 06/13] net/i40e: support ipsec-ah profile Bernard Iremonger
2020-01-15 15:53         ` [dpdk-dev] [PATCH v6 07/13] net/i40e: support ESP in customized code Bernard Iremonger
2020-01-15 15:53         ` [dpdk-dev] [PATCH v6 08/13] net/i40e: support ESP flows Bernard Iremonger
2020-01-15 15:53         ` [dpdk-dev] [PATCH v6 09/13] net/i40e: support ESP in Flow Director Bernard Iremonger
2020-01-15 15:53         ` [dpdk-dev] [PATCH v6 10/13] config: add debug to I40E " Bernard Iremonger
2020-01-15 16:17           ` Ferruh Yigit
2020-01-15 17:26             ` Iremonger, Bernard
2020-01-16 15:38               ` Ferruh Yigit
2020-01-15 15:53         ` [dpdk-dev] [PATCH v6 11/13] net/i40e: display Flow Director packet Bernard Iremonger
2020-01-15 15:53         ` [dpdk-dev] [PATCH v6 12/13] doc: release note for ESP Bernard Iremonger
2020-01-15 16:20           ` Ferruh Yigit
2020-01-15 16:58             ` Iremonger, Bernard
2020-01-15 15:53         ` [dpdk-dev] [PATCH v6 13/13] doc: update i40e user guide Bernard Iremonger
2020-01-14 13:55       ` [dpdk-dev] [PATCH v5 02/14] app/testpmd: improve debug Bernard Iremonger
2020-01-14 13:55       ` [dpdk-dev] [PATCH v5 03/14] app/testpmd: dump Rx and Tx mbuf Bernard Iremonger
2020-01-14 13:55       ` [dpdk-dev] [PATCH v5 04/14] net/i40e: improve RSS debug Bernard Iremonger
2020-01-14 13:55       ` [dpdk-dev] [PATCH v5 05/14] net/i40e: handle ESP tunnel Bernard Iremonger
2020-01-14 13:55       ` [dpdk-dev] [PATCH v5 06/14] net/i40e: support ipsec-ah profile Bernard Iremonger
2020-01-14 13:55       ` [dpdk-dev] [PATCH v5 07/14] net/i40e: support ESP in customised code Bernard Iremonger
2020-01-15  1:24         ` Zhang, Qi Z
2020-01-14 13:55       ` [dpdk-dev] [PATCH v5 08/14] net/i40e: support ESP flows Bernard Iremonger
2020-01-14 13:55       ` [dpdk-dev] [PATCH v5 09/14] net/i40e: support ESP in Flow Director Bernard Iremonger
2020-01-14 13:55       ` [dpdk-dev] [PATCH v5 10/14] config: add debug to I40E " Bernard Iremonger
2020-01-14 13:55       ` [dpdk-dev] [PATCH v5 11/14] net/i40e: display Flow Director packet Bernard Iremonger
2020-01-14 18:52         ` Ferruh Yigit
2020-01-15  9:18           ` Iremonger, Bernard
2020-01-15 10:58             ` Ferruh Yigit [this message]
2020-01-15 15:08               ` Iremonger, Bernard
2020-01-15  0:20         ` Zhang, Qi Z
2020-01-15  1:32           ` Zhang, Qi Z
2020-01-15  9:25           ` Iremonger, Bernard
2020-01-14 13:55       ` [dpdk-dev] [PATCH v5 12/14] librte_ethdev: add ESP and AH flow types to RSS Bernard Iremonger
2020-01-14 18:45         ` Ferruh Yigit
2020-01-15  9:13           ` Andrew Rybchenko
2020-01-15 10:44             ` Ferruh Yigit
2020-01-15 10:55               ` Andrew Rybchenko
2020-01-15 12:28                 ` Ferruh Yigit
2020-01-15 14:11                   ` Iremonger, Bernard
2020-01-15 14:36                     ` Ferruh Yigit
2020-01-15  0:13         ` Zhang, Qi Z
2020-01-15  9:41           ` Iremonger, Bernard
2020-01-14 13:55       ` [dpdk-dev] [PATCH v5 13/14] doc: release note for ESP Bernard Iremonger
2020-01-14 13:55       ` [dpdk-dev] [PATCH v5 14/14] doc: update i40e user guide Bernard Iremonger
2020-01-10 15:20     ` [dpdk-dev] [PATCH v4 01/14] app/testpmd: parse flow command line for ESP Bernard Iremonger
2020-01-10 15:20     ` [dpdk-dev] [PATCH v4 02/14] app/testpmd: improve debug Bernard Iremonger
2020-01-10 15:20     ` [dpdk-dev] [PATCH v4 03/14] app/testpmd: dump Rx and Tx mbuf Bernard Iremonger
2020-01-10 15:20     ` [dpdk-dev] [PATCH v4 04/14] net/i40e: improve RSS debug Bernard Iremonger
2020-01-10 15:20     ` [dpdk-dev] [PATCH v4 05/14] net/i40e: handle ESP tunnel Bernard Iremonger
2020-01-10 15:20     ` [dpdk-dev] [PATCH v4 06/14] net/i40e: support ipsec-ah profile Bernard Iremonger
2020-01-10 15:20     ` [dpdk-dev] [PATCH v4 07/14] net/i40e: support ESP in customised code Bernard Iremonger
2020-01-10 15:20     ` [dpdk-dev] [PATCH v4 08/14] net/i40e: support ESP flows Bernard Iremonger
2020-01-10 15:20     ` [dpdk-dev] [PATCH v4 09/14] net/i40e: support ESP in Flow Director Bernard Iremonger
2020-01-10 15:20     ` [dpdk-dev] [PATCH v4 10/14] config: add debug to I40E " Bernard Iremonger
2020-01-10 15:20     ` [dpdk-dev] [PATCH v4 11/14] net/i40e: display Flow Director packet Bernard Iremonger
2020-01-10 15:20     ` [dpdk-dev] [PATCH v4 12/14] librte_ethdev: add ESP and AH flow types to RSS Bernard Iremonger
2020-01-10 15:20     ` [dpdk-dev] [PATCH v4 13/14] doc: release note for ESP Bernard Iremonger
2020-01-10 15:20     ` [dpdk-dev] [PATCH v4 14/14] doc: update i40e user guide Bernard Iremonger
2020-01-09 12:16   ` [dpdk-dev] [PATCH v3 1/9] app/testpmd: parse flow command line for ESP Bernard Iremonger
2020-01-09 12:16   ` [dpdk-dev] [PATCH v3 2/9] app/testpmd: dump Rx and Tx mbuf Bernard Iremonger
2020-01-09 12:16   ` [dpdk-dev] [PATCH v3 3/9] net/i40e: improve RSS debug Bernard Iremonger
2020-01-09 13:44     ` Zhang, Qi Z
2020-01-09 12:16   ` [dpdk-dev] [PATCH v3 4/9] net/i40e: handle ESP tunnel Bernard Iremonger
2020-01-09 14:08     ` Zhang, Qi Z
2020-01-09 14:21       ` Iremonger, Bernard
2020-01-09 12:16   ` [dpdk-dev] [PATCH v3 5/9] net/i40e: process ESP flows Bernard Iremonger
2020-01-09 14:00     ` Zhang, Qi Z
2020-01-13 11:56       ` Iremonger, Bernard
2020-01-09 12:16   ` [dpdk-dev] [PATCH v3 6/9] net/i40e: display Flow Director packet Bernard Iremonger
2020-01-09 12:44     ` Zhang, Qi Z
2020-01-09 14:02       ` Iremonger, Bernard
2020-01-09 14:11         ` Zhang, Qi Z
2020-01-09 14:30           ` Iremonger, Bernard
2020-01-09 23:07         ` Ananyev, Konstantin
2020-01-10  9:20           ` Iremonger, Bernard
2020-01-09 12:16   ` [dpdk-dev] [PATCH v3 7/9] librte_ethdev: add ESP and AH flow types to RSS Bernard Iremonger
2020-01-09 12:16   ` [dpdk-dev] [PATCH v3 8/9] doc: release note for ESP Bernard Iremonger
2020-01-09 12:16   ` [dpdk-dev] [PATCH v3 9/9] doc: update i40e user guide Bernard Iremonger
2019-12-17 10:15 ` [dpdk-dev] [PATCH v2 01/10] app/testpmd: parse flow command line for ESP Bernard Iremonger
2020-01-08 14:43   ` Ori Kam
2020-01-08 16:16     ` Iremonger, Bernard
2020-01-09  6:29       ` Ori Kam
2020-01-09  9:16         ` Iremonger, Bernard
2019-12-17 10:15 ` [dpdk-dev] [PATCH v2 02/10] app/testpmd: improve debug code Bernard Iremonger
2019-12-17 10:15 ` [dpdk-dev] [PATCH v2 03/10] app/testpmd: dump Rx and Tx mbuf Bernard Iremonger
2019-12-17 10:15 ` [dpdk-dev] [PATCH v2 04/10] net/i40e: improve RSS debug Bernard Iremonger
2019-12-17 10:15 ` [dpdk-dev] [PATCH v2 05/10] net/i40e: handle ESP tunnel Bernard Iremonger
2019-12-17 10:15 ` [dpdk-dev] [PATCH v2 06/10] net/i40e: process ESP flows Bernard Iremonger
2019-12-17 10:15 ` [dpdk-dev] [PATCH v2 07/10] net/i40e: display Flow Director packet Bernard Iremonger
2019-12-17 10:15 ` [dpdk-dev] [PATCH v2 08/10] librte_ethdev: add ESP and AH flow types to RSS Bernard Iremonger
2019-12-17 10:15 ` [dpdk-dev] [PATCH v2 09/10] doc: release note for ESP Bernard Iremonger
2019-12-17 10:15 ` [dpdk-dev] [PATCH v2 10/10] doc: update i40e user guide Bernard Iremonger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12bc3749-ea29-ec14-b756-63c7e18702de@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=bernard.iremonger@intel.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=helin.zhang@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=stephen1.byrne@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org
	public-inbox-index dpdk-dev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git