From: "Iremonger, Bernard" <bernard.iremonger@intel.com> To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, Andrew Rybchenko <arybchenko@solarflare.com>, "dev@dpdk.org" <dev@dpdk.org>, "Xing, Beilei" <beilei.xing@intel.com>, "Zhang, Qi Z" <qi.z.zhang@intel.com>, "Doherty, Declan" <declan.doherty@intel.com> Cc: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, "Byrne, Stephen1" <stephen1.byrne@intel.com>, "Zhang, Helin" <helin.zhang@intel.com>, Ori Kam <orika@mellanox.com>, Thomas Monjalon <thomas@monjalon.net>, "Richardson, Bruce" <bruce.richardson@intel.com>, "Kinsella, Ray" <ray.kinsella@intel.com>, David Marchand <dmarchan@redhat.com>, Luca Boccassi <bluca@debian.org>, Jerin Jacob <jerin.jacob@caviumnetworks.com>, "Olivier MATZ" <olivier.matz@6wind.com> Subject: Re: [dpdk-dev] [PATCH v5 12/14] librte_ethdev: add ESP and AH flow types to RSS Date: Wed, 15 Jan 2020 14:11:02 +0000 Message-ID: <DM6PR11MB39149AB58EAF096128645C4CEF370@DM6PR11MB3914.namprd11.prod.outlook.com> (raw) In-Reply-To: <de350322-b5c1-ab4b-3016-ef8ddfeff633@intel.com> Hi Ferruh, <snip> > Subject: Re: [dpdk-dev] [PATCH v5 12/14] librte_ethdev: add ESP and AH > flow types to RSS > > On 1/15/2020 10:55 AM, Andrew Rybchenko wrote: > > On 1/15/20 1:44 PM, Ferruh Yigit wrote: > >> On 1/15/2020 9:13 AM, Andrew Rybchenko wrote: > >>> On 1/14/20 9:45 PM, Ferruh Yigit wrote: > >>>> On 1/14/2020 1:55 PM, Bernard Iremonger wrote: > >>>>> Add macros for the following protocols in the DDP esp-ah profile: > >>>>> ESP > >>>>> AH > >>>>> > >>>>> Add the following RSS macro for IPsec: > >>>>> ETH_RSS_IPSEC > >>>>> > >>>>> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com> > >>>> +Ori and other ethdev maintainers. > >>>> > >>>> Ori, can you please check this patch? > >>>> > >>>>> --- > >>>>> lib/librte_ethdev/rte_ethdev.h | 14 +++++++++++++- > >>>>> 1 file changed, 13 insertions(+), 1 deletion(-) > >>>>> > >>>>> diff --git a/lib/librte_ethdev/rte_ethdev.h > >>>>> b/lib/librte_ethdev/rte_ethdev.h index 18a9def..208ec90 100644 > >>>>> --- a/lib/librte_ethdev/rte_ethdev.h > >>>>> +++ b/lib/librte_ethdev/rte_ethdev.h > >>>>> @@ -484,7 +484,9 @@ struct rte_eth_rss_conf { > >>>>> #define RTE_ETH_FLOW_NVGRE 21 /**< NVGRE protocol > based flow */ > >>>>> #define RTE_ETH_FLOW_VXLAN_GPE 22 /**< VXLAN-GPE > protocol based flow */ > >>>>> #define RTE_ETH_FLOW_GTPU 23 /**< GTPU protocol based > flow */ > >>>>> -#define RTE_ETH_FLOW_MAX 24 > >>>>> +#define RTE_ETH_FLOW_AH 24 /**< AH protocol based flow > */ > >>>>> +#define RTE_ETH_FLOW_ESP 25 /**< ESP protocol based > flow */ > >>>>> +#define RTE_ETH_FLOW_MAX 26 > >>> Isn't changing RTE_ETH_FLOW_MAX value breaking ABI? > >>> Is v20.11 target release of the patch? > >> I can't see how this can cause an ABI break, unless the > >> 'RTE_ETH_FLOW_MAX' value used as size of an array in the middle of a > struct. > >> There is 'struct rte_eth_fdir_flex_conf' but the array is at the end > >> there, so it should be OK, unless that struct is not in the middle of another > struct. > > > > rte_eth_fdir_flex_conf -> rte_fdir_conf -> rte_eth_conf (in the > > middle) > > Yes, this looks like an ABI break and this is very annoying not able to even add > a new RTE_FLOW type. > > We need to find a proper way to handle this, at first glance I can see stop > using _MAX macros for the array size can work and perhaps we can use > another big enough hardcoded value for all similar array size. Any other > option? > > But we can do this on 20.11, we need a solution until that time. This patch is required to handle RSS for the esp-ah.pkg DDP profile, it does not affect the i40e FD and testpmd changes in this patch set. The esp-ah.pkg DDP profile is not released yet. Given that the merge deadline is today, I propose to drop this patch from the v6 patch set. > > > > >> And there are values calculated from 'RTE_ETH_FLOW_MAX', like > >> 'RTE_FLOW_MASK_ARRAY_SIZE', same concern applies there, it very hard > to follow. > >> > >> Bernard, > >> > >> Can you please run the ABI version script to be sure this is not breaking > the ABI? > >> > >> > >>>>> > >>>>> /* > >>>>> * Below macros are defined for RSS offload types, they can be > >>>>> used to @@ -511,6 +513,12 @@ struct rte_eth_rss_conf { > >>>>> #define ETH_RSS_GENEVE (1ULL << 20) > >>>>> #define ETH_RSS_NVGRE (1ULL << 21) > >>>>> #define ETH_RSS_GTPU (1ULL << 23) > >>>>> +#define ETH_RSS_AH (1ULL << 24) > >>>>> +#define ETH_RSS_ESP (1ULL << 25) > >>>>> + > >>>>> + > >>>>> + > >>>>> + > >>>>> > >>>>> /* > >>>>> * We use the following macros to combine with above ETH_RSS_* > >>>>> for @@ -571,6 +579,10 @@ rte_eth_rss_hf_refine(uint64_t rss_hf) > >>>>> ETH_RSS_NONFRAG_IPV4_SCTP | \ > >>>>> ETH_RSS_NONFRAG_IPV6_SCTP) > >>>>> > >>>>> +#define ETH_RSS_IPSEC ( \ > >>>>> + ETH_RSS_AH | \ > >>>>> + ETH_RSS_ESP) > >>>>> + > >>>>> #define ETH_RSS_TUNNEL ( \ > >>>>> ETH_RSS_VXLAN | \ > >>>>> ETH_RSS_GENEVE | \ > >>>>> > > Regards, Bernard.
next prev parent reply index Thread overview: 134+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-10 12:57 [dpdk-dev] [PATCH 0/9] net/i40e: ESP support Bernard Iremonger 2019-12-10 12:57 ` [dpdk-dev] [PATCH 1/9] app/testpmd: parse flow command line for ESP Bernard Iremonger 2019-12-10 21:12 ` Ori Kam 2019-12-11 9:24 ` Iremonger, Bernard 2019-12-10 12:57 ` [dpdk-dev] [PATCH 2/9] app/testpmd: dump Rx and Tx mbuf Bernard Iremonger 2019-12-10 12:57 ` [dpdk-dev] [PATCH 3/9] net/i40e: improve RSS debug Bernard Iremonger 2019-12-10 12:57 ` [dpdk-dev] [PATCH 4/9] net/i40e: handle ESP tunnel Bernard Iremonger 2019-12-10 12:57 ` [dpdk-dev] [PATCH 5/9] net/i40e: process ESP flows Bernard Iremonger 2019-12-10 12:57 ` [dpdk-dev] [PATCH 6/9] net/i40e: display Flow Director packet Bernard Iremonger 2019-12-10 12:57 ` [dpdk-dev] [PATCH 7/9] librte_ethdev: add ESP and AH flow types to RSS Bernard Iremonger 2019-12-10 18:27 ` Stephen Hemminger 2019-12-10 12:57 ` [dpdk-dev] [PATCH 8/9] doc: release note for ESP Bernard Iremonger 2019-12-10 12:57 ` [dpdk-dev] [PATCH 9/9] doc: update i40e user guide Bernard Iremonger 2019-12-17 10:15 ` [dpdk-dev] [PATCH v2 00/10] net/i40e: ESP support Bernard Iremonger 2020-01-09 12:16 ` [dpdk-dev] [PATCH v3 0/9] " Bernard Iremonger 2020-01-10 15:20 ` [dpdk-dev] [PATCH v4 00/14] " Bernard Iremonger 2020-01-14 13:55 ` [dpdk-dev] [PATCH v5 " Bernard Iremonger 2020-01-15 1:47 ` Zhang, Qi Z 2020-01-14 13:55 ` [dpdk-dev] [PATCH v5 01/14] app/testpmd: parse flow command line for ESP Bernard Iremonger 2020-01-14 19:03 ` Ferruh Yigit 2020-01-15 9:08 ` Iremonger, Bernard 2020-01-15 15:53 ` [dpdk-dev] [PATCH v6 00/13] net/i40e: ESP support Bernard Iremonger 2020-01-16 12:44 ` [dpdk-dev] [PATCH v7 00/10] " Bernard Iremonger 2020-01-16 17:42 ` Ferruh Yigit 2020-01-21 16:10 ` Iremonger, Bernard 2020-01-16 12:44 ` [dpdk-dev] [PATCH v7 01/10] app/testpmd: parse flow command line for ESP Bernard Iremonger 2020-01-16 12:44 ` [dpdk-dev] [PATCH v7 02/10] app/testpmd: improve debug Bernard Iremonger 2020-01-16 13:46 ` Ananyev, Konstantin 2020-01-16 12:44 ` [dpdk-dev] [PATCH v7 03/10] net/i40e: improve RSS debug Bernard Iremonger 2020-01-16 12:44 ` [dpdk-dev] [PATCH v7 04/10] net/i40e: handle ESP tunnel Bernard Iremonger 2020-01-16 12:44 ` [dpdk-dev] [PATCH v7 05/10] net/i40e: support ipsec-ah profile Bernard Iremonger 2020-01-16 12:44 ` [dpdk-dev] [PATCH v7 06/10] net/i40e: support ESP in customized code Bernard Iremonger 2020-01-16 12:44 ` [dpdk-dev] [PATCH v7 07/10] net/i40e: support ESP flows Bernard Iremonger 2020-01-16 12:44 ` [dpdk-dev] [PATCH v7 08/10] net/i40e: support ESP in Flow Director Bernard Iremonger 2020-01-16 12:44 ` [dpdk-dev] [PATCH v7 09/10] config: add debug to I40E " Bernard Iremonger 2020-01-16 12:44 ` [dpdk-dev] [PATCH v7 10/10] net/i40e: display Flow Director packet Bernard Iremonger 2020-01-15 15:53 ` [dpdk-dev] [PATCH v6 01/13] app/testpmd: parse flow command line for ESP Bernard Iremonger 2020-01-15 15:53 ` [dpdk-dev] [PATCH v6 02/13] app/testpmd: improve debug Bernard Iremonger 2020-01-15 15:53 ` [dpdk-dev] [PATCH v6 03/13] app/testpmd: dump Rx and Tx mbuf Bernard Iremonger 2020-01-15 16:28 ` Ferruh Yigit 2020-01-15 16:52 ` Iremonger, Bernard 2020-01-15 15:53 ` [dpdk-dev] [PATCH v6 04/13] net/i40e: improve RSS debug Bernard Iremonger 2020-01-15 15:53 ` [dpdk-dev] [PATCH v6 05/13] net/i40e: handle ESP tunnel Bernard Iremonger 2020-01-15 15:53 ` [dpdk-dev] [PATCH v6 06/13] net/i40e: support ipsec-ah profile Bernard Iremonger 2020-01-15 15:53 ` [dpdk-dev] [PATCH v6 07/13] net/i40e: support ESP in customized code Bernard Iremonger 2020-01-15 15:53 ` [dpdk-dev] [PATCH v6 08/13] net/i40e: support ESP flows Bernard Iremonger 2020-01-15 15:53 ` [dpdk-dev] [PATCH v6 09/13] net/i40e: support ESP in Flow Director Bernard Iremonger 2020-01-15 15:53 ` [dpdk-dev] [PATCH v6 10/13] config: add debug to I40E " Bernard Iremonger 2020-01-15 16:17 ` Ferruh Yigit 2020-01-15 17:26 ` Iremonger, Bernard 2020-01-16 15:38 ` Ferruh Yigit 2020-01-15 15:53 ` [dpdk-dev] [PATCH v6 11/13] net/i40e: display Flow Director packet Bernard Iremonger 2020-01-15 15:53 ` [dpdk-dev] [PATCH v6 12/13] doc: release note for ESP Bernard Iremonger 2020-01-15 16:20 ` Ferruh Yigit 2020-01-15 16:58 ` Iremonger, Bernard 2020-01-15 15:53 ` [dpdk-dev] [PATCH v6 13/13] doc: update i40e user guide Bernard Iremonger 2020-01-14 13:55 ` [dpdk-dev] [PATCH v5 02/14] app/testpmd: improve debug Bernard Iremonger 2020-01-14 13:55 ` [dpdk-dev] [PATCH v5 03/14] app/testpmd: dump Rx and Tx mbuf Bernard Iremonger 2020-01-14 13:55 ` [dpdk-dev] [PATCH v5 04/14] net/i40e: improve RSS debug Bernard Iremonger 2020-01-14 13:55 ` [dpdk-dev] [PATCH v5 05/14] net/i40e: handle ESP tunnel Bernard Iremonger 2020-01-14 13:55 ` [dpdk-dev] [PATCH v5 06/14] net/i40e: support ipsec-ah profile Bernard Iremonger 2020-01-14 13:55 ` [dpdk-dev] [PATCH v5 07/14] net/i40e: support ESP in customised code Bernard Iremonger 2020-01-15 1:24 ` Zhang, Qi Z 2020-01-14 13:55 ` [dpdk-dev] [PATCH v5 08/14] net/i40e: support ESP flows Bernard Iremonger 2020-01-14 13:55 ` [dpdk-dev] [PATCH v5 09/14] net/i40e: support ESP in Flow Director Bernard Iremonger 2020-01-14 13:55 ` [dpdk-dev] [PATCH v5 10/14] config: add debug to I40E " Bernard Iremonger 2020-01-14 13:55 ` [dpdk-dev] [PATCH v5 11/14] net/i40e: display Flow Director packet Bernard Iremonger 2020-01-14 18:52 ` Ferruh Yigit 2020-01-15 9:18 ` Iremonger, Bernard 2020-01-15 10:58 ` Ferruh Yigit 2020-01-15 15:08 ` Iremonger, Bernard 2020-01-15 0:20 ` Zhang, Qi Z 2020-01-15 1:32 ` Zhang, Qi Z 2020-01-15 9:25 ` Iremonger, Bernard 2020-01-14 13:55 ` [dpdk-dev] [PATCH v5 12/14] librte_ethdev: add ESP and AH flow types to RSS Bernard Iremonger 2020-01-14 18:45 ` Ferruh Yigit 2020-01-15 9:13 ` Andrew Rybchenko 2020-01-15 10:44 ` Ferruh Yigit 2020-01-15 10:55 ` Andrew Rybchenko 2020-01-15 12:28 ` Ferruh Yigit 2020-01-15 14:11 ` Iremonger, Bernard [this message] 2020-01-15 14:36 ` Ferruh Yigit 2020-01-15 0:13 ` Zhang, Qi Z 2020-01-15 9:41 ` Iremonger, Bernard 2020-01-14 13:55 ` [dpdk-dev] [PATCH v5 13/14] doc: release note for ESP Bernard Iremonger 2020-01-14 13:55 ` [dpdk-dev] [PATCH v5 14/14] doc: update i40e user guide Bernard Iremonger 2020-01-10 15:20 ` [dpdk-dev] [PATCH v4 01/14] app/testpmd: parse flow command line for ESP Bernard Iremonger 2020-01-10 15:20 ` [dpdk-dev] [PATCH v4 02/14] app/testpmd: improve debug Bernard Iremonger 2020-01-10 15:20 ` [dpdk-dev] [PATCH v4 03/14] app/testpmd: dump Rx and Tx mbuf Bernard Iremonger 2020-01-10 15:20 ` [dpdk-dev] [PATCH v4 04/14] net/i40e: improve RSS debug Bernard Iremonger 2020-01-10 15:20 ` [dpdk-dev] [PATCH v4 05/14] net/i40e: handle ESP tunnel Bernard Iremonger 2020-01-10 15:20 ` [dpdk-dev] [PATCH v4 06/14] net/i40e: support ipsec-ah profile Bernard Iremonger 2020-01-10 15:20 ` [dpdk-dev] [PATCH v4 07/14] net/i40e: support ESP in customised code Bernard Iremonger 2020-01-10 15:20 ` [dpdk-dev] [PATCH v4 08/14] net/i40e: support ESP flows Bernard Iremonger 2020-01-10 15:20 ` [dpdk-dev] [PATCH v4 09/14] net/i40e: support ESP in Flow Director Bernard Iremonger 2020-01-10 15:20 ` [dpdk-dev] [PATCH v4 10/14] config: add debug to I40E " Bernard Iremonger 2020-01-10 15:20 ` [dpdk-dev] [PATCH v4 11/14] net/i40e: display Flow Director packet Bernard Iremonger 2020-01-10 15:20 ` [dpdk-dev] [PATCH v4 12/14] librte_ethdev: add ESP and AH flow types to RSS Bernard Iremonger 2020-01-10 15:20 ` [dpdk-dev] [PATCH v4 13/14] doc: release note for ESP Bernard Iremonger 2020-01-10 15:20 ` [dpdk-dev] [PATCH v4 14/14] doc: update i40e user guide Bernard Iremonger 2020-01-09 12:16 ` [dpdk-dev] [PATCH v3 1/9] app/testpmd: parse flow command line for ESP Bernard Iremonger 2020-01-09 12:16 ` [dpdk-dev] [PATCH v3 2/9] app/testpmd: dump Rx and Tx mbuf Bernard Iremonger 2020-01-09 12:16 ` [dpdk-dev] [PATCH v3 3/9] net/i40e: improve RSS debug Bernard Iremonger 2020-01-09 13:44 ` Zhang, Qi Z 2020-01-09 12:16 ` [dpdk-dev] [PATCH v3 4/9] net/i40e: handle ESP tunnel Bernard Iremonger 2020-01-09 14:08 ` Zhang, Qi Z 2020-01-09 14:21 ` Iremonger, Bernard 2020-01-09 12:16 ` [dpdk-dev] [PATCH v3 5/9] net/i40e: process ESP flows Bernard Iremonger 2020-01-09 14:00 ` Zhang, Qi Z 2020-01-13 11:56 ` Iremonger, Bernard 2020-01-09 12:16 ` [dpdk-dev] [PATCH v3 6/9] net/i40e: display Flow Director packet Bernard Iremonger 2020-01-09 12:44 ` Zhang, Qi Z 2020-01-09 14:02 ` Iremonger, Bernard 2020-01-09 14:11 ` Zhang, Qi Z 2020-01-09 14:30 ` Iremonger, Bernard 2020-01-09 23:07 ` Ananyev, Konstantin 2020-01-10 9:20 ` Iremonger, Bernard 2020-01-09 12:16 ` [dpdk-dev] [PATCH v3 7/9] librte_ethdev: add ESP and AH flow types to RSS Bernard Iremonger 2020-01-09 12:16 ` [dpdk-dev] [PATCH v3 8/9] doc: release note for ESP Bernard Iremonger 2020-01-09 12:16 ` [dpdk-dev] [PATCH v3 9/9] doc: update i40e user guide Bernard Iremonger 2019-12-17 10:15 ` [dpdk-dev] [PATCH v2 01/10] app/testpmd: parse flow command line for ESP Bernard Iremonger 2020-01-08 14:43 ` Ori Kam 2020-01-08 16:16 ` Iremonger, Bernard 2020-01-09 6:29 ` Ori Kam 2020-01-09 9:16 ` Iremonger, Bernard 2019-12-17 10:15 ` [dpdk-dev] [PATCH v2 02/10] app/testpmd: improve debug code Bernard Iremonger 2019-12-17 10:15 ` [dpdk-dev] [PATCH v2 03/10] app/testpmd: dump Rx and Tx mbuf Bernard Iremonger 2019-12-17 10:15 ` [dpdk-dev] [PATCH v2 04/10] net/i40e: improve RSS debug Bernard Iremonger 2019-12-17 10:15 ` [dpdk-dev] [PATCH v2 05/10] net/i40e: handle ESP tunnel Bernard Iremonger 2019-12-17 10:15 ` [dpdk-dev] [PATCH v2 06/10] net/i40e: process ESP flows Bernard Iremonger 2019-12-17 10:15 ` [dpdk-dev] [PATCH v2 07/10] net/i40e: display Flow Director packet Bernard Iremonger 2019-12-17 10:15 ` [dpdk-dev] [PATCH v2 08/10] librte_ethdev: add ESP and AH flow types to RSS Bernard Iremonger 2019-12-17 10:15 ` [dpdk-dev] [PATCH v2 09/10] doc: release note for ESP Bernard Iremonger 2019-12-17 10:15 ` [dpdk-dev] [PATCH v2 10/10] doc: update i40e user guide Bernard Iremonger
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=DM6PR11MB39149AB58EAF096128645C4CEF370@DM6PR11MB3914.namprd11.prod.outlook.com \ --to=bernard.iremonger@intel.com \ --cc=arybchenko@solarflare.com \ --cc=beilei.xing@intel.com \ --cc=bluca@debian.org \ --cc=bruce.richardson@intel.com \ --cc=declan.doherty@intel.com \ --cc=dev@dpdk.org \ --cc=dmarchan@redhat.com \ --cc=ferruh.yigit@intel.com \ --cc=helin.zhang@intel.com \ --cc=jerin.jacob@caviumnetworks.com \ --cc=konstantin.ananyev@intel.com \ --cc=olivier.matz@6wind.com \ --cc=orika@mellanox.com \ --cc=qi.z.zhang@intel.com \ --cc=ray.kinsella@intel.com \ --cc=stephen1.byrne@intel.com \ --cc=thomas@monjalon.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK-dev Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \ dev@dpdk.org public-inbox-index dpdk-dev Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git