From: Ori Kam <orika@mellanox.com> To: "Iremonger, Bernard" <bernard.iremonger@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "Xing, Beilei" <beilei.xing@intel.com>, "Zhang, Qi Z" <qi.z.zhang@intel.com>, "Doherty, Declan" <declan.doherty@intel.com> Cc: "Ananyev, Konstantin" <konstantin.ananyev@intel.com> Subject: Re: [dpdk-dev] [PATCH v2 01/10] app/testpmd: parse flow command line for ESP Date: Thu, 9 Jan 2020 06:29:28 +0000 Message-ID: <AM4PR05MB3425C565A398CB8BE6E2DA45DB390@AM4PR05MB3425.eurprd05.prod.outlook.com> (raw) In-Reply-To: <DM6PR11MB39145D48956A79941B35F75EEF3E0@DM6PR11MB3914.namprd11.prod.outlook.com> Hi, > -----Original Message----- > From: Iremonger, Bernard <bernard.iremonger@intel.com> > Sent: Wednesday, January 8, 2020 6:17 PM > To: Ori Kam <orika@mellanox.com>; dev@dpdk.org; Xing, Beilei > <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Doherty, > Declan <declan.doherty@intel.com> > Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com> > Subject: RE: [dpdk-dev] [PATCH v2 01/10] app/testpmd: parse flow > command line for ESP > > Hi Ori, > > Thanks for the review. > > <snip> > > > Subject: RE: [dpdk-dev] [PATCH v2 01/10] app/testpmd: parse flow > > command line for ESP > > > > Hi just small comment inside. > > Thanks, > > Ori > > > > > -----Original Message----- > > > From: dev <dev-bounces@dpdk.org> On Behalf Of Bernard Iremonger > > > Sent: Tuesday, December 17, 2019 12:16 PM > > > To: dev@dpdk.org; beilei.xing@intel.com; qi.z.zhang@intel.com; > > > declan.doherty@intel.com > > > Cc: konstantin.ananyev@intel.com; bernard.iremonger@intel.com > > > Subject: [dpdk-dev] [PATCH v2 01/10] app/testpmd: parse flow > command > > > line for ESP > > > > > > add ITEM_ESP > > > add ITEM_ESP_SPI > > > add debug to cmdline_flow.c > > > > > > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com> > > > --- > > > app/test-pmd/cmdline_flow.c | 37 > > > ++++++++++++++++++++++++++++++++++--- > > > 1 file changed, 34 insertions(+), 3 deletions(-) > > > > > > diff --git a/app/test-pmd/cmdline_flow.c b/app/test- > pmd/cmdline_flow.c > > > index 99dade7..f1b0610 100644 > > > --- a/app/test-pmd/cmdline_flow.c > > > +++ b/app/test-pmd/cmdline_flow.c > > > @@ -213,6 +213,8 @@ enum index { > > > ITEM_TAG, > > > ITEM_TAG_DATA, > > > ITEM_TAG_INDEX, > > > + ITEM_ESP, > > > + ITEM_ESP_SPI, > > > > > > /* Validate/create actions. */ > > > ACTIONS, > > > @@ -746,6 +748,7 @@ static const enum index next_item[] = { > > > ITEM_PPPOE_PROTO_ID, > > > ITEM_HIGIG2, > > > ITEM_TAG, > > > + ITEM_ESP, > > > END_SET, > > > ZERO, > > > }; > > > @@ -1017,6 +1020,12 @@ static const enum index item_higig2[] = { > > > ZERO, > > > }; > > > > > > +static const enum index item_esp[] = { > > > + ITEM_ESP_SPI, > > > + ITEM_NEXT, > > > + ZERO, > > > +}; > > > + > > > static const enum index next_set_raw[] = { > > > SET_RAW_INDEX, > > > ITEM_ETH, > > > @@ -2593,6 +2602,20 @@ static const struct token token_list[] = { > > > NEXT_ENTRY(ITEM_PARAM_IS)), > > > .args = ARGS(ARGS_ENTRY(struct rte_flow_item_tag, > > index)), > > > }, > > > + [ITEM_ESP] = { > > > + .name = "esp", > > > + .help = "match ESP header", > > > + .priv = PRIV_ITEM(ESP, sizeof(struct rte_flow_item_esp)), > > > + .next = NEXT(item_esp), > > > + .call = parse_vc, > > > + }, > > > + [ITEM_ESP_SPI] = { > > > + .name = "spi", > > > + .help = "security policy index", > > > + .next = NEXT(item_esp, NEXT_ENTRY(UNSIGNED), > > > item_param), > > > + .args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_esp, > > > + hdr.spi)), > > > + }, > > > /* Validate/create actions. */ > > > [ACTIONS] = { > > > .name = "actions", > > > @@ -6052,6 +6075,9 @@ cmd_flow_tok(cmdline_parse_token_hdr_t > > **hdr, > > > static void cmd_flow_parsed(const struct buffer *in) { > > > + printf("Flow command line parsed successfully for > > > command=%d.\n", > > > + in->command); > > > + > > > > Why adding this printf? > > It is useful to know that the parsing of the flow command line is successful > before going into the PMD code. > I will remove in the v3 if you think it is too verbose. > I think it is to verbose, due to the fact that in normal case the parsing will succeed, Which means there will be a lot of print (In our testing we can have more then 200K commands). So I prefer to remove it, but if you think it is critical you can use the verbose_level with high value. If you remove it feel free to add my ack on v3. > > > > > switch (in->command) { > > > case VALIDATE: > > > port_flow_validate(in->port, &in->args.vc.attr, @@ -6230,14 > > > +6256,15 @@ flow_item_default_mask(const struct rte_flow_item > *item) > > > case RTE_FLOW_ITEM_TYPE_GTP: > > > mask = &rte_flow_item_gtp_mask; > > > break; > > > - case RTE_FLOW_ITEM_TYPE_ESP: > > > - mask = &rte_flow_item_esp_mask; > > > - break; > > > case RTE_FLOW_ITEM_TYPE_GTP_PSC: > > > mask = &rte_flow_item_gtp_psc_mask; > > > break; > > > case RTE_FLOW_ITEM_TYPE_PPPOE_PROTO_ID: > > > mask = &rte_flow_item_pppoe_proto_id_mask; > > > + break; > > > + case RTE_FLOW_ITEM_TYPE_ESP: > > > + mask = &rte_flow_item_esp_mask; > > > + break; > > > default: > > > break; > > > } > > > @@ -6327,6 +6354,10 @@ cmd_set_raw_parsed(const struct buffer *in) > > > case RTE_FLOW_ITEM_TYPE_GENEVE: > > > size = sizeof(struct rte_flow_item_geneve); > > > break; > > > + case RTE_FLOW_ITEM_TYPE_ESP: > > > + size = sizeof(struct rte_flow_item_esp); > > > + proto = 0x32; > > > + break; > > > default: > > > printf("Error - Not supported item\n"); > > > *total_size = 0; > > > -- > > > 2.7.4 > > Regards, > > Bernard.
next prev parent reply index Thread overview: 134+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-10 12:57 [dpdk-dev] [PATCH 0/9] net/i40e: ESP support Bernard Iremonger 2019-12-10 12:57 ` [dpdk-dev] [PATCH 1/9] app/testpmd: parse flow command line for ESP Bernard Iremonger 2019-12-10 21:12 ` Ori Kam 2019-12-11 9:24 ` Iremonger, Bernard 2019-12-10 12:57 ` [dpdk-dev] [PATCH 2/9] app/testpmd: dump Rx and Tx mbuf Bernard Iremonger 2019-12-10 12:57 ` [dpdk-dev] [PATCH 3/9] net/i40e: improve RSS debug Bernard Iremonger 2019-12-10 12:57 ` [dpdk-dev] [PATCH 4/9] net/i40e: handle ESP tunnel Bernard Iremonger 2019-12-10 12:57 ` [dpdk-dev] [PATCH 5/9] net/i40e: process ESP flows Bernard Iremonger 2019-12-10 12:57 ` [dpdk-dev] [PATCH 6/9] net/i40e: display Flow Director packet Bernard Iremonger 2019-12-10 12:57 ` [dpdk-dev] [PATCH 7/9] librte_ethdev: add ESP and AH flow types to RSS Bernard Iremonger 2019-12-10 18:27 ` Stephen Hemminger 2019-12-10 12:57 ` [dpdk-dev] [PATCH 8/9] doc: release note for ESP Bernard Iremonger 2019-12-10 12:57 ` [dpdk-dev] [PATCH 9/9] doc: update i40e user guide Bernard Iremonger 2019-12-17 10:15 ` [dpdk-dev] [PATCH v2 00/10] net/i40e: ESP support Bernard Iremonger 2020-01-09 12:16 ` [dpdk-dev] [PATCH v3 0/9] " Bernard Iremonger 2020-01-10 15:20 ` [dpdk-dev] [PATCH v4 00/14] " Bernard Iremonger 2020-01-14 13:55 ` [dpdk-dev] [PATCH v5 " Bernard Iremonger 2020-01-15 1:47 ` Zhang, Qi Z 2020-01-14 13:55 ` [dpdk-dev] [PATCH v5 01/14] app/testpmd: parse flow command line for ESP Bernard Iremonger 2020-01-14 19:03 ` Ferruh Yigit 2020-01-15 9:08 ` Iremonger, Bernard 2020-01-15 15:53 ` [dpdk-dev] [PATCH v6 00/13] net/i40e: ESP support Bernard Iremonger 2020-01-16 12:44 ` [dpdk-dev] [PATCH v7 00/10] " Bernard Iremonger 2020-01-16 17:42 ` Ferruh Yigit 2020-01-21 16:10 ` Iremonger, Bernard 2020-01-16 12:44 ` [dpdk-dev] [PATCH v7 01/10] app/testpmd: parse flow command line for ESP Bernard Iremonger 2020-01-16 12:44 ` [dpdk-dev] [PATCH v7 02/10] app/testpmd: improve debug Bernard Iremonger 2020-01-16 13:46 ` Ananyev, Konstantin 2020-01-16 12:44 ` [dpdk-dev] [PATCH v7 03/10] net/i40e: improve RSS debug Bernard Iremonger 2020-01-16 12:44 ` [dpdk-dev] [PATCH v7 04/10] net/i40e: handle ESP tunnel Bernard Iremonger 2020-01-16 12:44 ` [dpdk-dev] [PATCH v7 05/10] net/i40e: support ipsec-ah profile Bernard Iremonger 2020-01-16 12:44 ` [dpdk-dev] [PATCH v7 06/10] net/i40e: support ESP in customized code Bernard Iremonger 2020-01-16 12:44 ` [dpdk-dev] [PATCH v7 07/10] net/i40e: support ESP flows Bernard Iremonger 2020-01-16 12:44 ` [dpdk-dev] [PATCH v7 08/10] net/i40e: support ESP in Flow Director Bernard Iremonger 2020-01-16 12:44 ` [dpdk-dev] [PATCH v7 09/10] config: add debug to I40E " Bernard Iremonger 2020-01-16 12:44 ` [dpdk-dev] [PATCH v7 10/10] net/i40e: display Flow Director packet Bernard Iremonger 2020-01-15 15:53 ` [dpdk-dev] [PATCH v6 01/13] app/testpmd: parse flow command line for ESP Bernard Iremonger 2020-01-15 15:53 ` [dpdk-dev] [PATCH v6 02/13] app/testpmd: improve debug Bernard Iremonger 2020-01-15 15:53 ` [dpdk-dev] [PATCH v6 03/13] app/testpmd: dump Rx and Tx mbuf Bernard Iremonger 2020-01-15 16:28 ` Ferruh Yigit 2020-01-15 16:52 ` Iremonger, Bernard 2020-01-15 15:53 ` [dpdk-dev] [PATCH v6 04/13] net/i40e: improve RSS debug Bernard Iremonger 2020-01-15 15:53 ` [dpdk-dev] [PATCH v6 05/13] net/i40e: handle ESP tunnel Bernard Iremonger 2020-01-15 15:53 ` [dpdk-dev] [PATCH v6 06/13] net/i40e: support ipsec-ah profile Bernard Iremonger 2020-01-15 15:53 ` [dpdk-dev] [PATCH v6 07/13] net/i40e: support ESP in customized code Bernard Iremonger 2020-01-15 15:53 ` [dpdk-dev] [PATCH v6 08/13] net/i40e: support ESP flows Bernard Iremonger 2020-01-15 15:53 ` [dpdk-dev] [PATCH v6 09/13] net/i40e: support ESP in Flow Director Bernard Iremonger 2020-01-15 15:53 ` [dpdk-dev] [PATCH v6 10/13] config: add debug to I40E " Bernard Iremonger 2020-01-15 16:17 ` Ferruh Yigit 2020-01-15 17:26 ` Iremonger, Bernard 2020-01-16 15:38 ` Ferruh Yigit 2020-01-15 15:53 ` [dpdk-dev] [PATCH v6 11/13] net/i40e: display Flow Director packet Bernard Iremonger 2020-01-15 15:53 ` [dpdk-dev] [PATCH v6 12/13] doc: release note for ESP Bernard Iremonger 2020-01-15 16:20 ` Ferruh Yigit 2020-01-15 16:58 ` Iremonger, Bernard 2020-01-15 15:53 ` [dpdk-dev] [PATCH v6 13/13] doc: update i40e user guide Bernard Iremonger 2020-01-14 13:55 ` [dpdk-dev] [PATCH v5 02/14] app/testpmd: improve debug Bernard Iremonger 2020-01-14 13:55 ` [dpdk-dev] [PATCH v5 03/14] app/testpmd: dump Rx and Tx mbuf Bernard Iremonger 2020-01-14 13:55 ` [dpdk-dev] [PATCH v5 04/14] net/i40e: improve RSS debug Bernard Iremonger 2020-01-14 13:55 ` [dpdk-dev] [PATCH v5 05/14] net/i40e: handle ESP tunnel Bernard Iremonger 2020-01-14 13:55 ` [dpdk-dev] [PATCH v5 06/14] net/i40e: support ipsec-ah profile Bernard Iremonger 2020-01-14 13:55 ` [dpdk-dev] [PATCH v5 07/14] net/i40e: support ESP in customised code Bernard Iremonger 2020-01-15 1:24 ` Zhang, Qi Z 2020-01-14 13:55 ` [dpdk-dev] [PATCH v5 08/14] net/i40e: support ESP flows Bernard Iremonger 2020-01-14 13:55 ` [dpdk-dev] [PATCH v5 09/14] net/i40e: support ESP in Flow Director Bernard Iremonger 2020-01-14 13:55 ` [dpdk-dev] [PATCH v5 10/14] config: add debug to I40E " Bernard Iremonger 2020-01-14 13:55 ` [dpdk-dev] [PATCH v5 11/14] net/i40e: display Flow Director packet Bernard Iremonger 2020-01-14 18:52 ` Ferruh Yigit 2020-01-15 9:18 ` Iremonger, Bernard 2020-01-15 10:58 ` Ferruh Yigit 2020-01-15 15:08 ` Iremonger, Bernard 2020-01-15 0:20 ` Zhang, Qi Z 2020-01-15 1:32 ` Zhang, Qi Z 2020-01-15 9:25 ` Iremonger, Bernard 2020-01-14 13:55 ` [dpdk-dev] [PATCH v5 12/14] librte_ethdev: add ESP and AH flow types to RSS Bernard Iremonger 2020-01-14 18:45 ` Ferruh Yigit 2020-01-15 9:13 ` Andrew Rybchenko 2020-01-15 10:44 ` Ferruh Yigit 2020-01-15 10:55 ` Andrew Rybchenko 2020-01-15 12:28 ` Ferruh Yigit 2020-01-15 14:11 ` Iremonger, Bernard 2020-01-15 14:36 ` Ferruh Yigit 2020-01-15 0:13 ` Zhang, Qi Z 2020-01-15 9:41 ` Iremonger, Bernard 2020-01-14 13:55 ` [dpdk-dev] [PATCH v5 13/14] doc: release note for ESP Bernard Iremonger 2020-01-14 13:55 ` [dpdk-dev] [PATCH v5 14/14] doc: update i40e user guide Bernard Iremonger 2020-01-10 15:20 ` [dpdk-dev] [PATCH v4 01/14] app/testpmd: parse flow command line for ESP Bernard Iremonger 2020-01-10 15:20 ` [dpdk-dev] [PATCH v4 02/14] app/testpmd: improve debug Bernard Iremonger 2020-01-10 15:20 ` [dpdk-dev] [PATCH v4 03/14] app/testpmd: dump Rx and Tx mbuf Bernard Iremonger 2020-01-10 15:20 ` [dpdk-dev] [PATCH v4 04/14] net/i40e: improve RSS debug Bernard Iremonger 2020-01-10 15:20 ` [dpdk-dev] [PATCH v4 05/14] net/i40e: handle ESP tunnel Bernard Iremonger 2020-01-10 15:20 ` [dpdk-dev] [PATCH v4 06/14] net/i40e: support ipsec-ah profile Bernard Iremonger 2020-01-10 15:20 ` [dpdk-dev] [PATCH v4 07/14] net/i40e: support ESP in customised code Bernard Iremonger 2020-01-10 15:20 ` [dpdk-dev] [PATCH v4 08/14] net/i40e: support ESP flows Bernard Iremonger 2020-01-10 15:20 ` [dpdk-dev] [PATCH v4 09/14] net/i40e: support ESP in Flow Director Bernard Iremonger 2020-01-10 15:20 ` [dpdk-dev] [PATCH v4 10/14] config: add debug to I40E " Bernard Iremonger 2020-01-10 15:20 ` [dpdk-dev] [PATCH v4 11/14] net/i40e: display Flow Director packet Bernard Iremonger 2020-01-10 15:20 ` [dpdk-dev] [PATCH v4 12/14] librte_ethdev: add ESP and AH flow types to RSS Bernard Iremonger 2020-01-10 15:20 ` [dpdk-dev] [PATCH v4 13/14] doc: release note for ESP Bernard Iremonger 2020-01-10 15:20 ` [dpdk-dev] [PATCH v4 14/14] doc: update i40e user guide Bernard Iremonger 2020-01-09 12:16 ` [dpdk-dev] [PATCH v3 1/9] app/testpmd: parse flow command line for ESP Bernard Iremonger 2020-01-09 12:16 ` [dpdk-dev] [PATCH v3 2/9] app/testpmd: dump Rx and Tx mbuf Bernard Iremonger 2020-01-09 12:16 ` [dpdk-dev] [PATCH v3 3/9] net/i40e: improve RSS debug Bernard Iremonger 2020-01-09 13:44 ` Zhang, Qi Z 2020-01-09 12:16 ` [dpdk-dev] [PATCH v3 4/9] net/i40e: handle ESP tunnel Bernard Iremonger 2020-01-09 14:08 ` Zhang, Qi Z 2020-01-09 14:21 ` Iremonger, Bernard 2020-01-09 12:16 ` [dpdk-dev] [PATCH v3 5/9] net/i40e: process ESP flows Bernard Iremonger 2020-01-09 14:00 ` Zhang, Qi Z 2020-01-13 11:56 ` Iremonger, Bernard 2020-01-09 12:16 ` [dpdk-dev] [PATCH v3 6/9] net/i40e: display Flow Director packet Bernard Iremonger 2020-01-09 12:44 ` Zhang, Qi Z 2020-01-09 14:02 ` Iremonger, Bernard 2020-01-09 14:11 ` Zhang, Qi Z 2020-01-09 14:30 ` Iremonger, Bernard 2020-01-09 23:07 ` Ananyev, Konstantin 2020-01-10 9:20 ` Iremonger, Bernard 2020-01-09 12:16 ` [dpdk-dev] [PATCH v3 7/9] librte_ethdev: add ESP and AH flow types to RSS Bernard Iremonger 2020-01-09 12:16 ` [dpdk-dev] [PATCH v3 8/9] doc: release note for ESP Bernard Iremonger 2020-01-09 12:16 ` [dpdk-dev] [PATCH v3 9/9] doc: update i40e user guide Bernard Iremonger 2019-12-17 10:15 ` [dpdk-dev] [PATCH v2 01/10] app/testpmd: parse flow command line for ESP Bernard Iremonger 2020-01-08 14:43 ` Ori Kam 2020-01-08 16:16 ` Iremonger, Bernard 2020-01-09 6:29 ` Ori Kam [this message] 2020-01-09 9:16 ` Iremonger, Bernard 2019-12-17 10:15 ` [dpdk-dev] [PATCH v2 02/10] app/testpmd: improve debug code Bernard Iremonger 2019-12-17 10:15 ` [dpdk-dev] [PATCH v2 03/10] app/testpmd: dump Rx and Tx mbuf Bernard Iremonger 2019-12-17 10:15 ` [dpdk-dev] [PATCH v2 04/10] net/i40e: improve RSS debug Bernard Iremonger 2019-12-17 10:15 ` [dpdk-dev] [PATCH v2 05/10] net/i40e: handle ESP tunnel Bernard Iremonger 2019-12-17 10:15 ` [dpdk-dev] [PATCH v2 06/10] net/i40e: process ESP flows Bernard Iremonger 2019-12-17 10:15 ` [dpdk-dev] [PATCH v2 07/10] net/i40e: display Flow Director packet Bernard Iremonger 2019-12-17 10:15 ` [dpdk-dev] [PATCH v2 08/10] librte_ethdev: add ESP and AH flow types to RSS Bernard Iremonger 2019-12-17 10:15 ` [dpdk-dev] [PATCH v2 09/10] doc: release note for ESP Bernard Iremonger 2019-12-17 10:15 ` [dpdk-dev] [PATCH v2 10/10] doc: update i40e user guide Bernard Iremonger
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=AM4PR05MB3425C565A398CB8BE6E2DA45DB390@AM4PR05MB3425.eurprd05.prod.outlook.com \ --to=orika@mellanox.com \ --cc=beilei.xing@intel.com \ --cc=bernard.iremonger@intel.com \ --cc=declan.doherty@intel.com \ --cc=dev@dpdk.org \ --cc=konstantin.ananyev@intel.com \ --cc=qi.z.zhang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK-dev Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \ dev@dpdk.org public-inbox-index dpdk-dev Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git