DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
* [dpdk-dev] [PATCH] net/octeontx: use logtype_init for failed probe
@ 2019-07-16 18:47 Stephen Hemminger
  2019-07-19  3:37 ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran
  0 siblings, 1 reply; 4+ messages in thread
From: Stephen Hemminger @ 2019-07-16 18:47 UTC (permalink / raw)
  To: jerinj; +Cc: dev

All log messages should use driver logtype. RTE_LOGTYPE_PMD is
planned to be deprecated in the future.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/octeontx/octeontx_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c
index 1b853399dfe4..27eed47bb0cb 100644
--- a/drivers/net/octeontx/octeontx_ethdev.c
+++ b/drivers/net/octeontx/octeontx_ethdev.c
@@ -1175,7 +1175,7 @@ octeontx_probe(struct rte_vdev_device *dev)
 	    strlen(rte_vdev_device_args(dev)) == 0) {
 		eth_dev = rte_eth_dev_attach_secondary(dev_name);
 		if (!eth_dev) {
-			RTE_LOG(ERR, PMD, "Failed to probe %s\n", dev_name);
+			PMD_INIT_LOG(ERR, "Failed to probe %s", dev_name);
 			return -1;
 		}
 		/* TODO: request info from primary to set up Rx and Tx */
-- 
2.20.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [EXT] [PATCH] net/octeontx: use logtype_init for failed probe
  2019-07-16 18:47 [dpdk-dev] [PATCH] net/octeontx: use logtype_init for failed probe Stephen Hemminger
@ 2019-07-19  3:37 ` " Jerin Jacob Kollanukkaran
  2019-07-19 16:59   ` Stephen Hemminger
  0 siblings, 1 reply; 4+ messages in thread
From: Jerin Jacob Kollanukkaran @ 2019-07-19  3:37 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: dev



> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Wednesday, July 17, 2019 12:18 AM
> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> Cc: dev@dpdk.org
> Subject: [EXT] [PATCH] net/octeontx: use logtype_init for failed probe

> All log messages should use driver logtype. RTE_LOGTYPE_PMD is planned to
> be deprecated in the future.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---

Please fix

$ ./devtools/check-git-log.sh
Wrong headline format:
        net/octeontx: use logtype_init for failed probe
		
		

>  drivers/net/octeontx/octeontx_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/octeontx/octeontx_ethdev.c
> b/drivers/net/octeontx/octeontx_ethdev.c
> index 1b853399dfe4..27eed47bb0cb 100644
> --- a/drivers/net/octeontx/octeontx_ethdev.c
> +++ b/drivers/net/octeontx/octeontx_ethdev.c
> @@ -1175,7 +1175,7 @@ octeontx_probe(struct rte_vdev_device *dev)
>  	    strlen(rte_vdev_device_args(dev)) == 0) {
>  		eth_dev = rte_eth_dev_attach_secondary(dev_name);
>  		if (!eth_dev) {
> -			RTE_LOG(ERR, PMD, "Failed to probe %s\n",
> dev_name);
> +			PMD_INIT_LOG(ERR, "Failed to probe %s",
> dev_name);
>  			return -1;
>  		}
>  		/* TODO: request info from primary to set up Rx and Tx */
> --
> 2.20.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [EXT] [PATCH] net/octeontx: use logtype_init for failed probe
  2019-07-19  3:37 ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran
@ 2019-07-19 16:59   ` Stephen Hemminger
  2019-07-22  8:05     ` Jerin Jacob Kollanukkaran
  0 siblings, 1 reply; 4+ messages in thread
From: Stephen Hemminger @ 2019-07-19 16:59 UTC (permalink / raw)
  To: Jerin Jacob Kollanukkaran; +Cc: dev

On Fri, 19 Jul 2019 03:37:26 +0000
Jerin Jacob Kollanukkaran <jerinj@marvell.com> wrote:

> > -----Original Message-----
> > From: Stephen Hemminger <stephen@networkplumber.org>
> > Sent: Wednesday, July 17, 2019 12:18 AM
> > To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> > Cc: dev@dpdk.org
> > Subject: [EXT] [PATCH] net/octeontx: use logtype_init for failed probe  
> 
> > All log messages should use driver logtype. RTE_LOGTYPE_PMD is planned to
> > be deprecated in the future.
> > 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---  
> 
> Please fix
> 
> $ ./devtools/check-git-log.sh
> Wrong headline format:
>         net/octeontx: use logtype_init for failed probe
> 		

OK but

That rule in check-git-log is still ridiculous because it rejects perfectly good
commit subjects. The intention is good "stop automated bots" but the implementation
rejects too many good patches.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [EXT] [PATCH] net/octeontx: use logtype_init for failed probe
  2019-07-19 16:59   ` Stephen Hemminger
@ 2019-07-22  8:05     ` Jerin Jacob Kollanukkaran
  0 siblings, 0 replies; 4+ messages in thread
From: Jerin Jacob Kollanukkaran @ 2019-07-22  8:05 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: dev

> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Friday, July 19, 2019 10:29 PM
> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> Cc: dev@dpdk.org
> Subject: Re: [EXT] [PATCH] net/octeontx: use logtype_init for failed probe
> 
> On Fri, 19 Jul 2019 03:37:26 +0000
> Jerin Jacob Kollanukkaran <jerinj@marvell.com> wrote:
> 
> > > -----Original Message-----
> > > From: Stephen Hemminger <stephen@networkplumber.org>
> > > Sent: Wednesday, July 17, 2019 12:18 AM
> > > To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> > > Cc: dev@dpdk.org
> > > Subject: [EXT] [PATCH] net/octeontx: use logtype_init for failed
> > > probe
> >
> > > All log messages should use driver logtype. RTE_LOGTYPE_PMD is
> > > planned to be deprecated in the future.
> > >
> > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > > ---
> >
> > Please fix
> >
> > $ ./devtools/check-git-log.sh
> > Wrong headline format:
> >         net/octeontx: use logtype_init for failed probe
> >

Changed the git commit to:
net/octeontx: use driver logtype

Applied to dpdk-next-net-mrvl/master. Thanks


> 
> OK but
> 
> That rule in check-git-log is still ridiculous because it rejects perfectly good
> commit subjects. The intention is good "stop automated bots" but the
> implementation rejects too many good patches.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-16 18:47 [dpdk-dev] [PATCH] net/octeontx: use logtype_init for failed probe Stephen Hemminger
2019-07-19  3:37 ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran
2019-07-19 16:59   ` Stephen Hemminger
2019-07-22  8:05     ` Jerin Jacob Kollanukkaran

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org dpdk-dev@archiver.kernel.org
	public-inbox-index dpdk-dev


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox