DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
* [dpdk-dev] [PATCH] eal: update comment about --no-huge option
@ 2019-07-17  8:56 Thomas Monjalon
  2019-07-17 12:35 ` Burakov, Anatoly
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2019-07-17  8:56 UTC (permalink / raw)
  To: anatoly.burakov; +Cc: dev

The old comment, on top of the function rte_eal_has_hugepages(),
is really outdated and not generic enough.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 lib/librte_eal/common/include/rte_eal.h | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/lib/librte_eal/common/include/rte_eal.h b/lib/librte_eal/common/include/rte_eal.h
index 34245b053..b7cf91214 100644
--- a/lib/librte_eal/common/include/rte_eal.h
+++ b/lib/librte_eal/common/include/rte_eal.h
@@ -448,10 +448,7 @@ rte_set_application_usage_hook(rte_usage_hook_t usage_func);
 
 /**
  * Whether EAL is using huge pages (disabled by --no-huge option).
- * The no-huge mode cannot be used with UIO poll-mode drivers like igb/ixgbe.
- * It is useful for NIC drivers (e.g. librte_pmd_mlx4, librte_pmd_vmxnet3) or
- * crypto drivers (e.g. librte_crypto_nitrox) provided by third-parties such
- * as 6WIND.
+ * The no-huge mode is not compatible with all drivers or features.
  *
  * @return
  *   Nonzero if hugepages are enabled.
-- 
2.21.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] eal: update comment about --no-huge option
  2019-07-17  8:56 [dpdk-dev] [PATCH] eal: update comment about --no-huge option Thomas Monjalon
@ 2019-07-17 12:35 ` Burakov, Anatoly
  2019-07-17 17:58   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Burakov, Anatoly @ 2019-07-17 12:35 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev

On 17-Jul-19 9:56 AM, Thomas Monjalon wrote:
> The old comment, on top of the function rte_eal_has_hugepages(),
> is really outdated and not generic enough.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

-- 
Thanks,
Anatoly

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] eal: update comment about --no-huge option
  2019-07-17 12:35 ` Burakov, Anatoly
@ 2019-07-17 17:58   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2019-07-17 17:58 UTC (permalink / raw)
  To: dev; +Cc: Burakov, Anatoly

17/07/2019 14:35, Burakov, Anatoly:
> On 17-Jul-19 9:56 AM, Thomas Monjalon wrote:
> > The old comment, on top of the function rte_eal_has_hugepages(),
> > is really outdated and not generic enough.
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> 
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

Applied




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-17  8:56 [dpdk-dev] [PATCH] eal: update comment about --no-huge option Thomas Monjalon
2019-07-17 12:35 ` Burakov, Anatoly
2019-07-17 17:58   ` Thomas Monjalon

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org
	public-inbox-index dpdk-dev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git