From: Thomas Monjalon <thomas@monjalon.net> To: Ray Kinsella <mdr@ashroe.eu>, stephen@networkplumber.org, Haiyue Wang <haiyue.wang@intel.com> Cc: dev@dpdk.org, ferruh.yigit@intel.com, viacheslavo@mellanox.com, edwin.verplanke@intel.com Subject: Re: [dpdk-dev] [RFC v2 1/3] ethdev: add the API for getting trace information Date: Sat, 26 Oct 2019 18:45:37 +0200 Message-ID: <8407813.BflZntU1Eb@xps> (raw) In-Reply-To: <eb450632-013a-99c1-9946-1b06e8d8b006@ashroe.eu> 13/08/2019 14:51, Ray Kinsella: > On 13/08/2019 04:24, Stephen Hemminger wrote: > > On Tue, 13 Aug 2019 11:06:10 +0800 > > Haiyue Wang <haiyue.wang@intel.com> wrote: > > > >> Enhance the PMD to support retrieving trace information like > >> Rx/Tx burst selection etc. > >> > >> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com> [...] > >> int > >> +rte_eth_trace_info_get(uint16_t port_id, uint16_t queue_id, > >> + enum rte_eth_trace type, char *buf, int sz) [...] > > The bigger problem is that this information is like a log message > > and unstructured, which makes it device specific and useless for automation. > > IMHO - this is much better implemented as a capability bitfield, that > can be queried. Now I see where this idea comes from. Ray, Stephen, structuring shuch information is really a bad idea. The Rx/Tx functions are not like capabilities, they are full of smart tricks written by brillant engineers. Please do not try to put ideas in some categories. We will have more and more new types of optimization and ideas when the hardware will evolve. And, more importantly, there is no need of automation or processing with this information.
next prev parent reply index Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-13 3:06 [dpdk-dev] [RFC v2 0/3] show the Rx/Tx burst description field Haiyue Wang 2019-08-13 3:06 ` [dpdk-dev] [RFC v2 1/3] ethdev: add the API for getting trace information Haiyue Wang 2019-08-13 3:24 ` Stephen Hemminger 2019-08-13 4:37 ` Wang, Haiyue 2019-08-13 9:57 ` David Marchand 2019-08-13 11:21 ` Wang, Haiyue 2019-08-13 12:51 ` Ray Kinsella 2019-09-06 14:21 ` Ferruh Yigit 2019-09-07 2:42 ` Wang, Haiyue 2019-09-09 11:23 ` Ferruh Yigit 2019-09-09 12:40 ` Bruce Richardson 2019-09-09 12:50 ` Ferruh Yigit 2019-09-09 13:17 ` Ferruh Yigit 2019-09-10 4:36 ` Wang, Haiyue 2019-09-10 8:06 ` Ferruh Yigit 2019-09-10 8:37 ` Wang, Haiyue 2019-09-10 9:14 ` Ferruh Yigit 2019-09-10 11:41 ` Wang, Haiyue 2019-09-10 15:00 ` Ferruh Yigit 2019-09-10 15:17 ` Wang, Haiyue 2019-09-10 15:33 ` Ferruh Yigit 2019-09-10 15:35 ` Wang, Haiyue 2019-09-10 14:19 ` Wang, Haiyue 2019-09-10 15:03 ` Ferruh Yigit 2019-09-10 15:18 ` Wang, Haiyue 2019-09-10 15:36 ` Ferruh Yigit 2019-09-10 15:38 ` Wang, Haiyue 2019-09-10 15:06 ` Ferruh Yigit 2019-09-10 15:21 ` Wang, Haiyue 2019-09-10 15:35 ` Ferruh Yigit 2019-09-10 15:37 ` Wang, Haiyue 2019-10-26 16:45 ` Thomas Monjalon [this message] 2019-10-27 4:10 ` Wang, Haiyue 2019-08-15 9:07 ` Ray Kinsella 2019-08-13 3:06 ` [dpdk-dev] [RFC v2 2/3] testpmd: show the Rx/Tx burst description Haiyue Wang 2019-08-13 3:06 ` [dpdk-dev] [RFC v2 3/3] net/ice: support the Rx/Tx burst description trace Haiyue Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=8407813.BflZntU1Eb@xps \ --to=thomas@monjalon.net \ --cc=dev@dpdk.org \ --cc=edwin.verplanke@intel.com \ --cc=ferruh.yigit@intel.com \ --cc=haiyue.wang@intel.com \ --cc=mdr@ashroe.eu \ --cc=stephen@networkplumber.org \ --cc=viacheslavo@mellanox.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK-dev Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \ dev@dpdk.org public-inbox-index dpdk-dev Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git